A small documentation PR on github

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

A small documentation PR on github

Alexander Kjeldaas

Hi devs!

I created a small documentation PR for the GHC FFI on github and noticed that there's another one-liner PR from May 2019 that was not merged.


Just checking that simple PRs are still accepted on github.

Alexander


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: A small documentation PR on github

Hécate

Hi Alexander, and thank you for the heads-up!

The development process has largely migrated to the GHC GitLab instance, so the pull-requests may receive less attentions on GitHub.
I encourage you to read our process https://gitlab.haskell.org/ghc/ghc/-/issues/17929#merge-requests-etiquette so that the PRs receive
all the love they deserve!

Cheers!
Hécate

Le 03/07/2020 à 12:20, Alexander Kjeldaas a écrit :

Hi devs!

I created a small documentation PR for the GHC FFI on github and noticed that there's another one-liner PR from May 2019 that was not merged.


Just checking that simple PRs are still accepted on github.

Alexander


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: A small documentation PR on github

Ben Gamari-2
In reply to this post by Alexander Kjeldaas
Alexander Kjeldaas <[hidden email]> writes:

> Hi devs!
>
> I created a small documentation PR for the GHC FFI on github and noticed
> that there's another one-liner PR from May 2019 that was not merged.
>
> https://github.com/ghc/ghc/pull/260
> https://github.com/ghc/ghc/pull/255
>
> Just checking that simple PRs are still accepted on github.
>
An excellent point. In my mind the move to GitLab has addressed the
principle reason why we started accepted small PRs on GitHub. My sense
is that we should move these PRs to GitLab and formally stop accepting
PRs via GitHub.

If there is no objection I will do this in three days.

Cheers,

- Ben


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: A small documentation PR on github

Moritz Angermann-2
The performance of GH is still better than GL. Reading the code on GH is faster and easier to navigate than GL. This might be an artifact of my location? The GL UI feels a lot more sluggish. Though GH is doing their part with service downtimes recently as well. 

Making a small change on GH to a file is almost comically trivial. Press Edit, make the change, commit and open the PR. All from within the browser in a few seconds. Wasn’t this this primary motivation for allowing documentation PRs on GH?

On Sat, 4 Jul 2020 at 2:18 AM, Ben Gamari <[hidden email]> wrote:
Alexander Kjeldaas <[hidden email]> writes:

> Hi devs!
>
> I created a small documentation PR for the GHC FFI on github and noticed
> that there's another one-liner PR from May 2019 that was not merged.
>
> https://github.com/ghc/ghc/pull/260
> https://github.com/ghc/ghc/pull/255
>
> Just checking that simple PRs are still accepted on github.
>
An excellent point. In my mind the move to GitLab has addressed the
principle reason why we started accepted small PRs on GitHub. My sense
is that we should move these PRs to GitLab and formally stop accepting
PRs via GitHub.

If there is no objection I will do this in three days.

Cheers,

- Ben

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: A small documentation PR on github

Alexander Kjeldaas
Wrt my change, I've made a merge request on Gitlab.  Absolutely no problems using that tool.

Alexander

On Sat, Jul 4, 2020 at 2:28 AM Moritz Angermann <[hidden email]> wrote:
The performance of GH is still better than GL. Reading the code on GH is faster and easier to navigate than GL. This might be an artifact of my location? The GL UI feels a lot more sluggish. Though GH is doing their part with service downtimes recently as well. 

Making a small change on GH to a file is almost comically trivial. Press Edit, make the change, commit and open the PR. All from within the browser in a few seconds. Wasn’t this this primary motivation for allowing documentation PRs on GH?

On Sat, 4 Jul 2020 at 2:18 AM, Ben Gamari <[hidden email]> wrote:
Alexander Kjeldaas <[hidden email]> writes:

> Hi devs!
>
> I created a small documentation PR for the GHC FFI on github and noticed
> that there's another one-liner PR from May 2019 that was not merged.
>
> https://github.com/ghc/ghc/pull/260
> https://github.com/ghc/ghc/pull/255
>
> Just checking that simple PRs are still accepted on github.
>
An excellent point. In my mind the move to GitLab has addressed the
principle reason why we started accepted small PRs on GitHub. My sense
is that we should move these PRs to GitLab and formally stop accepting
PRs via GitHub.

If there is no objection I will do this in three days.

Cheers,

- Ben

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: A small documentation PR on github

Ben Gamari-2
In reply to this post by Moritz Angermann-2
Moritz Angermann <[hidden email]> writes:

> The performance of GH is still better than GL. Reading the code on GH is
> faster and easier to navigate than GL. This might be an artifact of my
> location? The GL UI feels a lot more sluggish. Though GH is doing their
> part with service downtimes recently as well.
>
> Making a small change on GH to a file is almost comically trivial. Press
> Edit, make the change, commit and open the PR. All from within the browser
> in a few seconds. Wasn’t this this primary motivation for allowing
> documentation PRs on GH?
>
This same workflow works on GitLab. The decision to allow GitHub merge
requests was made when we were still using Phabricator, where this sort
of thing was significantly less convenient and required opening a
Phabricator account.

Cheers,

- Ben

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment