Better perf?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Better perf?

GHC - devs mailing list

I’m getting this perf improvement from T5837, which is type-function heavy.  Is anyone else seeing this

 

bytes allocated value is too low:

(If this is because you have improved GHC, please

update the test so that GHC doesn't regress again)

    Expected    T5837(normal) bytes allocated: 48507272 +/-10%

    Lower bound T5837(normal) bytes allocated: 43656544

    Upper bound T5837(normal) bytes allocated: 53358000

    Actual      T5837(normal) bytes allocated: 42384144

    Deviation   T5837(normal) bytes allocated:    -12.6 %

 

Its good, but I’d quite  like to know which patch made the difference.  Could it be

commit 03541cbae50f0d1cdf99120ab88698f29a278159

Author: Simon Peyton Jones <[hidden email]>

Date:   Fri Sep 9 17:42:42 2016 +0100

 

    Be less picky about reporing inaccessible code

 

Seems implausible, but possible I suppose.

Simon


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Better perf?

Joachim Breitner-2
Hi,

according to
https://perf.haskell.org/ghc/#graph/tests/alloc/T5837
it was 

commit a48de37dcca98e7d477040b0ed298bcd1b3ab303
Author: Sergei Trofimovich <[hidden email]>
Date:   Thu Sep 1 17:34:58 2016 +0100

    restore -fmax-worker-args handling (Trac #11565)


Greetings,
Joachim

--
Joachim “nomeata” Breitner
  [hidden email]https://www.joachim-breitner.de/
  XMPP: [hidden email] • OpenPGP-Key: 0xF0FBF51F
  Debian Developer: [hidden email]
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (817 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Better perf?

GHC - devs mailing list
Cool.

Perhaps someone can update the numbers with a comment pointing to the relevant commit?

Simon

|  -----Original Message-----
|  From: ghc-devs [mailto:[hidden email]] On Behalf Of
|  Joachim Breitner
|  Sent: 13 September 2016 17:00
|  To: [hidden email]
|  Subject: Re: Better perf?
|  
|  Hi,
|  
|  according to
|  https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fperf.
|  haskell.org%2fghc%2f%23graph%2ftests%2falloc%2fT5837&data=02%7c01%7csi
|  monpj%40microsoft.com%7ca9cef754e1f246ad325e08d3dbef0f3a%7c72f988bf86f
|  141af91ab2d7cd011db47%7c1%7c0%7c636093792210134741&sdata=fh4bxFFGsWKAA
|  8iZ0J%2faz6d3p4eLv2ZbX2K0qM%2b7GZY%3d
|  it was
|  
|  commit a48de37dcca98e7d477040b0ed298bcd1b3ab303
|  Author: Sergei Trofimovich <[hidden email]>
|  Date:   Thu Sep 1 17:34:58 2016 +0100
|  
|      restore -fmax-worker-args handling (Trac #11565)
|  
|  
|  Greetings,
|  Joachim
|  
|  --
|  Joachim “nomeata” Breitner
|    [hidden email]
|  https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fwww.j
|  oachim-
|  breitner.de%2f&data=02%7c01%7csimonpj%40microsoft.com%7ca9cef754e1f246
|  ad325e08d3dbef0f3a%7c72f988bf86f141af91ab2d7cd011db47%7c1%7c0%7c636093
|  792210144750&sdata=gv6NQVusbo5hJ0w4vvHZyyJGsXWe6iPadR6emQWaKZo%3d
|    XMPP: [hidden email] • OpenPGP-Key: 0xF0FBF51F
|    Debian Developer: [hidden email]
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs