Error submitting a code review

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Error submitting a code review

ARJANEN Loïc Jean David

Hello,

I'm currently having an issue submitting my first code review. I recently registered on Phabricator and tried to send my first code review through the web interface. However, Harbormaster is failing to build it with the following error in the lease: Couldn't find remote ref. When searching on Google for this error, I found indications that it's related to Drydock not managing to push the changes to the staging area, likely due to a bad SSH key or git URL for arcanist. Could the SSH key issue also apply when using the web interface?
Hoping to read from you soon, I wish you a very good day.

Yours sincerely,
ARJANEN Loïc


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Error submitting a code review

Matthew Pickering
Harbormaster only works if you use `arc` to submit the patch.

You can see how to use `arc` from the wiki page:
https://ghc.haskell.org/trac/ghc/wiki/Phabricator

Cheers,

Matt

On Fri, Apr 13, 2018 at 4:22 PM, ARJANEN Loïc Jean David
<[hidden email]> wrote:

> Hello,
>
> I'm currently having an issue submitting my first code review. I recently
> registered on Phabricator and tried to send my first code review through the
> web interface. However, Harbormaster is failing to build it with the
> following error in the lease: Couldn't find remote ref. When searching on
> Google for this error, I found indications that it's related to Drydock not
> managing to push the changes to the staging area, likely due to a bad SSH
> key or git URL for arcanist. Could the SSH key issue also apply when using
> the web interface?
> Hoping to read from you soon, I wish you a very good day.
>
> Yours sincerely,
> ARJANEN Loïc
>
>
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Error submitting a code review

ARJANEN Loïc Jean David
Thanks for the answer. Is there any way to remove an existing draft code
review? I'm not seeing any in the web interface.

Yours sincerely,
ARJANEN Loïc

Le vendredi 13 avril 2018, 22:49:08 +07 Matthew Pickering a écrit :

> Harbormaster only works if you use `arc` to submit the patch.
>
> You can see how to use `arc` from the wiki page:
> https://ghc.haskell.org/trac/ghc/wiki/Phabricator
>
> Cheers,
>
> Matt
>
> On Fri, Apr 13, 2018 at 4:22 PM, ARJANEN Loïc Jean David
>
> <[hidden email]> wrote:
> > Hello,
> >
> > I'm currently having an issue submitting my first code review. I recently
> > registered on Phabricator and tried to send my first code review through
> > the web interface. However, Harbormaster is failing to build it with the
> > following error in the lease: Couldn't find remote ref. When searching on
> > Google for this error, I found indications that it's related to Drydock
> > not managing to push the changes to the staging area, likely due to a bad
> > SSH key or git URL for arcanist. Could the SSH key issue also apply when
> > using the web interface?
> > Hoping to read from you soon, I wish you a very good day.
> >
> > Yours sincerely,
> > ARJANEN Loïc
> >
> >
> > _______________________________________________
> > ghc-devs mailing list
> > [hidden email]
> > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Error submitting a code review

Moritz Angermann
Choose “Abandon Revision” in the comment field at the end of the review.

Sent from my iPhone

> On 13 Apr 2018, at 6:14 PM, ARJANEN Loïc Jean David <[hidden email]> wrote:
>
> Thanks for the answer. Is there any way to remove an existing draft code
> review? I'm not seeing any in the web interface.
>
> Yours sincerely,
> ARJANEN Loïc
>
> Le vendredi 13 avril 2018, 22:49:08 +07 Matthew Pickering a écrit :
>> Harbormaster only works if you use `arc` to submit the patch.
>>
>> You can see how to use `arc` from the wiki page:
>> https://ghc.haskell.org/trac/ghc/wiki/Phabricator
>>
>> Cheers,
>>
>> Matt
>>
>> On Fri, Apr 13, 2018 at 4:22 PM, ARJANEN Loïc Jean David
>>
>> <[hidden email]> wrote:
>>> Hello,
>>>
>>> I'm currently having an issue submitting my first code review. I recently
>>> registered on Phabricator and tried to send my first code review through
>>> the web interface. However, Harbormaster is failing to build it with the
>>> following error in the lease: Couldn't find remote ref. When searching on
>>> Google for this error, I found indications that it's related to Drydock
>>> not managing to push the changes to the staging area, likely due to a bad
>>> SSH key or git URL for arcanist. Could the SSH key issue also apply when
>>> using the web interface?
>>> Hoping to read from you soon, I wish you a very good day.
>>>
>>> Yours sincerely,
>>> ARJANEN Loïc
>>>
>>>
>>> _______________________________________________
>>> ghc-devs mailing list
>>> [hidden email]
>>> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
>
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Error submitting a code review

Matthew Pickering
In reply to this post by ARJANEN Loïc Jean David
Or you can use `arc diff --update D1234` to update the existing differential.

On Fri, Apr 13, 2018 at 5:14 PM, ARJANEN Loïc Jean David
<[hidden email]> wrote:

> Thanks for the answer. Is there any way to remove an existing draft code
> review? I'm not seeing any in the web interface.
>
> Yours sincerely,
> ARJANEN Loïc
>
> Le vendredi 13 avril 2018, 22:49:08 +07 Matthew Pickering a écrit :
>> Harbormaster only works if you use `arc` to submit the patch.
>>
>> You can see how to use `arc` from the wiki page:
>> https://ghc.haskell.org/trac/ghc/wiki/Phabricator
>>
>> Cheers,
>>
>> Matt
>>
>> On Fri, Apr 13, 2018 at 4:22 PM, ARJANEN Loïc Jean David
>>
>> <[hidden email]> wrote:
>> > Hello,
>> >
>> > I'm currently having an issue submitting my first code review. I recently
>> > registered on Phabricator and tried to send my first code review through
>> > the web interface. However, Harbormaster is failing to build it with the
>> > following error in the lease: Couldn't find remote ref. When searching on
>> > Google for this error, I found indications that it's related to Drydock
>> > not managing to push the changes to the staging area, likely due to a bad
>> > SSH key or git URL for arcanist. Could the SSH key issue also apply when
>> > using the web interface?
>> > Hoping to read from you soon, I wish you a very good day.
>> >
>> > Yours sincerely,
>> > ARJANEN Loïc
>> >
>> >
>> > _______________________________________________
>> > ghc-devs mailing list
>> > [hidden email]
>> > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
>
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs