FW: [GHC] #8186: Parallel comprehensions not allowed in Template Haskell quotes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

FW: [GHC] #8186: Parallel comprehensions not allowed in Template Haskell quotes

Simon Peyton Jones
With Gitolite, the Trac tickets now get messages like this:

Comment (by Richard Eisenberg <eir@?>):

 In [changeset:382f601406b11b7d4fdc72d773c6060372f1fbb3/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="382f601406b11b7d4fdc72d773c6060372f1fbb3"
 Fix Trac #8186.

 Parallel list comprehensions are now handled in DsMeta.
 }}}


But they used to get messages like this (like git log --stat)

commit ef017944600cf4e153aad686a6a78bfb48dea67a
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Tue Aug 27 15:48:02 2013 +0100

    Comments only, relating to #8166 fix

 compiler/codeGen/StgCmm.hs      |    7 ++-----
 compiler/codeGen/StgCmmExpr.hs  |    7 ++++---
 compiler/codeGen/StgCmmMonad.hs |   10 +++++++++-
 3 files changed, 15 insertions(+), 9 deletions(-)


I liked the old version:
    the author is more explicit
    the modified files are listed
    if the patch is small you see it all

Might it be possible to revert?

Simon

Reply | Threaded
Open this post in threaded view
|

FW: [GHC] #8186: Parallel comprehensions not allowed in Template Haskell quotes

Herbert Valerio Riedel
Hello Simon,

On 2013-08-28 at 10:14:36 +0200, Simon Peyton-Jones wrote:
> With Gitolite, the Trac tickets now get messages like this:

[...]

> I liked the old version:
>     the author is more explicit
>     the modified files are listed
>     if the patch is small you see it all
>
> Might it be possible to revert?

Well, the problem with the old implementation of the ticket updater is
that it's an external Python script calling into the Trac python API and
messing around with Trac's sqlite database via SQL commands
directly. This was the common ad-hoc way to do this kind of things up to
Trac 0.11, but starting with Trac 0.12 a proper facility was provided[1]
which is better integrated with Trac and what most people (who didn't
give up on Trac) use nowadays.

So going back to the old script is not recommended. Otoh, it's possible
to extend by sub-classing the standard CommitTicketUpdater[1] component,
and trying to re-create the information provided by the previous
hook-script in a more "modern" way. However, if it's not high-priority
I'd like to postpone tackling this until after GHC 7.8 is released.

Cheers,
  hvr

 [1]: http://trac.edgewall.org/wiki/CommitTicketUpdater



Reply | Threaded
Open this post in threaded view
|

FW: [GHC] #8186: Parallel comprehensions not allowed in Template Haskell quotes

Simon Peyton Jones
OK thanks. If it's hard, fair enough, leave it for now.

Simon

| -----Original Message-----
| From: Herbert Valerio Riedel [mailto:hvr at gnu.org]
| Sent: 28 August 2013 16:19
| To: Simon Peyton-Jones
| Cc: ghc-devs at haskell.org
| Subject: Re: FW: [GHC] #8186: Parallel comprehensions not allowed in
| Template Haskell quotes
|
| Hello Simon,
|
| On 2013-08-28 at 10:14:36 +0200, Simon Peyton-Jones wrote:
| > With Gitolite, the Trac tickets now get messages like this:
|
| [...]
|
| > I liked the old version:
| >     the author is more explicit
| >     the modified files are listed
| >     if the patch is small you see it all
| >
| > Might it be possible to revert?
|
| Well, the problem with the old implementation of the ticket updater is
| that it's an external Python script calling into the Trac python API and
| messing around with Trac's sqlite database via SQL commands
| directly. This was the common ad-hoc way to do this kind of things up to
| Trac 0.11, but starting with Trac 0.12 a proper facility was provided[1]
| which is better integrated with Trac and what most people (who didn't
| give up on Trac) use nowadays.
|
| So going back to the old script is not recommended. Otoh, it's possible
| to extend by sub-classing the standard CommitTicketUpdater[1] component,
| and trying to re-create the information provided by the previous
| hook-script in a more "modern" way. However, if it's not high-priority
| I'd like to postpone tackling this until after GHC 7.8 is released.
|
| Cheers,
|   hvr
|
|  [1]: http://trac.edgewall.org/wiki/CommitTicketUpdater