[GHC] #10816: Fixity declaration for associated type rejected

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #10816: Fixity declaration for associated type rejected

GHC - devs mailing list
#10816: Fixity declaration for associated type rejected
-------------------------------------+-------------------------------------
              Reporter:  goldfire    |             Owner:
                  Type:  bug         |            Status:  new
              Priority:  normal      |         Milestone:
             Component:  Compiler    |           Version:  7.10.2
              Keywords:              |  Operating System:  Unknown/Multiple
          Architecture:              |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
             Test Case:              |        Blocked By:
              Blocking:              |   Related Tickets:
Differential Revisions:              |
-------------------------------------+-------------------------------------
 When I say

 {{{
 {-# LANGUAGE TypeOperators, TypeFamilies #-}

 module Bug where

 class C a where
   type a # b
   infix 4 #
 }}}

 I get

 {{{
 Bug.hs:7:11: ‘#’ is not a (visible) method of class ‘C’
 }}}

 But it really should just assign a fixity to the type `#`. It works if the
 fixity declaration is outside of the class.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10816>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #10816: Fixity declaration for associated type rejected

GHC - devs mailing list
#10816: Fixity declaration for associated type rejected
-------------------------------------+-------------------------------------
        Reporter:  goldfire          |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:
       Component:  Compiler          |              Version:  7.10.2
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4077
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by RyanGlScott):

 * status:  new => patch
 * differential:   => Phab:D4077


Comment:

 I ended up stumbling upon this while looking at implementing
 [https://github.com/ghc-proposals/ghc-proposals/pull/65 this proposal], as
 the symptom of this ticket (having too many code paths for renaming fixity
 declarations) also made it annoying to implement the proposal. While
 Phab:D4077 doesn't implement the proposal in full, it will make it easier
 to do so later.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10816#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #10816: Fixity declaration for associated type rejected

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#10816: Fixity declaration for associated type rejected
-------------------------------------+-------------------------------------
        Reporter:  goldfire          |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:
       Component:  Compiler          |              Version:  7.10.2
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4077
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ryan Scott <ryan.gl.scott@…>):

 In [changeset:"9c3f73168a6f7f6632b6a3ffd2cfcd774976a7f1/ghc" 9c3f731/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="9c3f73168a6f7f6632b6a3ffd2cfcd774976a7f1"
 Fix #10816 by renaming FixitySigs more consistently

 Summary:
 #10816 surfaced because we were renaming top-level fixity
 declarations with a different code path (`rnSrcFixityDecl`) than
 the code path for fixity declarations inside of type classes, which
 is not privy to names that exist in the type namespace. Luckily, the
 fix is simple: use `rnSrcFixityDecl` in both places.

 Test Plan: make test TEST=T10816

 Reviewers: austin, bgamari, simonpj

 Reviewed By: simonpj

 Subscribers: simonpj, rwbarton, thomie

 GHC Trac Issues: #10816

 Differential Revision: https://phabricator.haskell.org/D4077
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10816#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #10816: Fixity declaration for associated type rejected

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#10816: Fixity declaration for associated type rejected
-------------------------------------+-------------------------------------
        Reporter:  goldfire          |                Owner:  (none)
            Type:  bug               |               Status:  closed
        Priority:  normal            |            Milestone:  8.4.1
       Component:  Compiler          |              Version:  7.10.2
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
                                     |  testsuite/rename/should_compile/T10816
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4077
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by RyanGlScott):

 * testcase:   => testsuite/rename/should_compile/T10816
 * status:  patch => closed
 * resolution:   => fixed
 * milestone:   => 8.4.1


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10816#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets