[GHC] #14392: `make binary-dist` is broken

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #14392: `make binary-dist` is broken

GHC - devs mailing list
#14392: `make binary-dist` is broken
-------------------------------------+-------------------------------------
           Reporter:  Fuuzetsu       |             Owner:  (none)
               Type:  bug            |            Status:  new
           Priority:  normal         |         Milestone:
          Component:  Build System   |           Version:  8.3
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 If we run

 {{{#!bash
 ./boot
 ./configure
 make
 make binary-dist
 }}}

 We are soon greeted with the following error

 {{{
 cd bindistprep && "/bin/tar" hcf - -T ../bindist-list.uniq | /usr/bin/xz
 -c > ../bindistprep/ghc-8.3.20171025-x86_64-unknown-linux.tar.xz
 /bin/tar: ghc-8.3.20171025/testsuite/utils/check-api-annotations/dist-
 install/build/.depend.c_asm: Cannot stat: No such file or directory
 /bin/tar: ghc-8.3.20171025/testsuite/utils/check-api-annotations/dist-
 install/build/.depend.haskell: Cannot stat: No such file or directory
 /bin/tar: ghc-8.3.20171025/testsuite/utils/check-api-annotations/dist-
 install/package-data.mk: Cannot stat: No such file or directory
 /bin/tar: ghc-8.3.20171025/testsuite/utils/check-api-annotations/ghc.mk:
 Cannot stat: No such file or directory
 /bin/tar: ghc-8.3.20171025/testsuite/utils/check-ppr/dist-
 install/build/.depend.c_asm: Cannot stat: No such file or directory
 /bin/tar: ghc-8.3.20171025/testsuite/utils/check-ppr/dist-
 install/build/.depend.haskell: Cannot stat: No such file or directory
 /bin/tar: ghc-8.3.20171025/testsuite/utils/check-ppr/dist-install/package-
 data.mk: Cannot stat: No such file or directory
 /bin/tar: ghc-8.3.20171025/testsuite/utils/check-ppr/ghc.mk: Cannot stat:
 No such file or directory
 /bin/tar: Exiting with failure status due to previous errors
 mv bindistprep/*.tar.xz "."
 }}}

 I suspect
 https://github.com/ghc/ghc/commit/1e9f90af7311c33de0f7f5b7dba594725596d675
 is to blame: bindist was not updated.

 A temporary work around I'm using is

 {{{
 +    $(filter-out testsuite/utils/check-ppr/% testsuite/utils/check-api-
 annotations/% %/project.mk mk/config.mk %/mk/install.mk,$(MAKEFILE_LIST))
 \
 }}}

 in top level {{{ghc.mk}}} in {{{bindist-list}}} {{{eval}}} section.

 I have reported this in #ghc to Ben but I am creating this ticket such
 that we can track the progress.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14392>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #14392: `make binary-dist` is broken

GHC - devs mailing list
#14392: `make binary-dist` is broken
-------------------------------------+-------------------------------------
        Reporter:  Fuuzetsu          |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:
       Component:  Build System      |              Version:  8.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ninjatrappeur):

 Just ran the same command on a610c215580c56116b0882d3dce4a3a45993df19 and
 ended up with a different error:


 {{{
 cd bindistprep && "/bin/tar" hcf - -T ../bindist-list.uniq | /bin/xz -c >
 ../bindistprep/ghc-8.5.20180612-x86_64-unknown-linux.tar.xz
 /bin/tar: ghc-8.5.20180612/libraries/libiserv/LICENSE : stat impossible:
 No such file or directory
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14392#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #14392: `make binary-dist` is broken

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#14392: `make binary-dist` is broken
-------------------------------------+-------------------------------------
        Reporter:  Fuuzetsu          |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:
       Component:  Build System      |              Version:  8.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4844
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by bgamari):

 * status:  new => patch
 * differential:   => Phab:D4844


Comment:

 The patch originally introducing this issue,
 1e9f90af7311c33de0f7f5b7dba594725596d675, was reverted in
 d9b6015d1942aa176e85bb71f34200bab54e1c9c. This ticket should have been
 closed at this point.

 Unfortunately it does look like there is now another related issue due to
 the recent `libiserv` renaming, which inexplicably dropped the license
 file, which is expected by the bindist script. This should be fixed by
 Phab:D4844.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14392#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #14392: `make binary-dist` is broken

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#14392: `make binary-dist` is broken
-------------------------------------+-------------------------------------
        Reporter:  Fuuzetsu          |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:
       Component:  Build System      |              Version:  8.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4844
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"908edbfbc65049d102c2a861cc5954fa50c772ae/ghc" 908edbf/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="908edbfbc65049d102c2a861cc5954fa50c772ae"
 libiserv: Add license file

 Test Plan: Run `make bindist` on built tree.

 Subscribers: rwbarton, thomie, carter, angerman

 GHC Trac Issues: #14392

 Differential Revision: https://phabricator.haskell.org/D4844
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14392#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #14392: `make binary-dist` is broken

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#14392: `make binary-dist` is broken
-------------------------------------+-------------------------------------
        Reporter:  Fuuzetsu          |                Owner:  (none)
            Type:  bug               |               Status:  closed
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Build System      |              Version:  8.3
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4844
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by bgamari):

 * status:  patch => closed
 * resolution:   => fixed
 * milestone:   => 8.6.1


Comment:

 This should now be fixed.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14392#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets