[GHC] #14601: Remove uses of unsafeGlobalDynFlags for -fopt-coercions

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #14601: Remove uses of unsafeGlobalDynFlags for -fopt-coercions

GHC - devs mailing list
#14601: Remove uses of unsafeGlobalDynFlags for -fopt-coercions
-------------------------------------+-------------------------------------
           Reporter:  bgamari        |             Owner:  (none)
               Type:  task           |            Status:  new
           Priority:  normal         |         Milestone:
          Component:  Compiler       |           Version:  8.2.1
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 Currently the `-fopt-coercions` flag finds its way to
 `OptCoercion.optCoercion` by way of the terrible `unsafeGlobalDynFlags`.
 In general it's nice to minimize the uses of `unsafeGlobalDynFlags`.
 However, it's not entirely clear that passing a `DynFlags` to
 `optCoercion` is worthwhile in this case as `-fopt-coercion` is
 essentially a debug flag. Leaving this here for later consideration.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14601>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #14601: Remove uses of unsafeGlobalDynFlags for -fopt-coercions

GHC - devs mailing list
#14601: Remove uses of unsafeGlobalDynFlags for -fopt-coercions
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  task              |               Status:  closed
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.2.1
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4774
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by bgamari):

 * status:  new => closed
 * differential:   => Phab:D4774
 * resolution:   => fixed
 * milestone:   => 8.6.1


Comment:

 This was fixed with 64c71ce956af3af593a46ef0d615c7f6fe6ecece.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14601#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets