[GHC] #14640: Div and Mod type families don't have the same fixities as their term-level counterparts

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #14640: Div and Mod type families don't have the same fixities as their term-level counterparts

GHC - devs mailing list
#14640: Div and Mod type families don't have the same fixities as their term-level
counterparts
-------------------------------------+-------------------------------------
           Reporter:  RyanGlScott    |             Owner:  (none)
               Type:  bug            |            Status:  new
           Priority:  normal         |         Milestone:  8.4.1
          Component:                 |           Version:  8.4.1-alpha1
  libraries/base                     |
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 Commit fa8035e3ee83aff5a20fc5e7e2697bac1686d6a6 added `Div` and `Mod` type
 families to `GHC.TypeNats`. However, they did not add the corresponding
 fixities! Currently, we have that both `div` and `mod` (at the value
 level) are `infixl 7`, so we should adopt the same fixities for the type-
 level `Div` and `Mod` as well.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14640>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #14640: Div and Mod type families don't have the same fixities as their term-level counterparts

GHC - devs mailing list
#14640: Div and Mod type families don't have the same fixities as their term-level
counterparts
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.4.1
       Component:  libraries/base    |              Version:  8.4.1-alpha1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4291
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by RyanGlScott):

 * status:  new => patch
 * differential:   => Phab:D4291


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14640#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #14640: Div and Mod type families don't have the same fixities as their term-level counterparts

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#14640: Div and Mod type families don't have the same fixities as their term-level
counterparts
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.4.1
       Component:  libraries/base    |              Version:  8.4.1-alpha1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4291
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"303106d55d75a9c796e58867cb541ad136bb217f/ghc" 303106d/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="303106d55d75a9c796e58867cb541ad136bb217f"
 Make the Div and Mod type families `infixl 7`

 Commit fa8035e3ee83aff5a20fc5e7e2697bac1686d6a6 added `Div`
 and `Mod` type families to `GHC.TypeNats`. However, they did not add
 the corresponding fixities! Currently, we have that both `div` and
 `mod` (at the value level) are `infixl 7`, so we should adopt the
 same fixities for the type-level `Div` and `Mod` as well.

 Test Plan: It compiles

 Reviewers: hvr, bgamari

 Reviewed By: bgamari

 Subscribers: rwbarton, thomie, carter

 GHC Trac Issues: #14640

 Differential Revision: https://phabricator.haskell.org/D4291
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14640#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #14640: Div and Mod type families don't have the same fixities as their term-level counterparts

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#14640: Div and Mod type families don't have the same fixities as their term-level
counterparts
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  merge
        Priority:  normal            |            Milestone:  8.4.1
       Component:  libraries/base    |              Version:  8.4.1-alpha1
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4291
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by RyanGlScott):

 * status:  patch => merge


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14640#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #14640: Div and Mod type families don't have the same fixities as their term-level counterparts

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#14640: Div and Mod type families don't have the same fixities as their term-level
counterparts
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  closed
        Priority:  normal            |            Milestone:  8.4.1
       Component:  libraries/base    |              Version:  8.4.1-alpha1
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4291
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by bgamari):

 * status:  merge => closed
 * resolution:   => fixed


Comment:

 Merged in fdfaa56b04b2cefb86e4dc557b1d163fd2e062dc.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14640#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets