[GHC] #15145: Emit info-level log message when package environments have been picked up

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #15145: Emit info-level log message when package environments have been picked up

GHC - devs mailing list
#15145: Emit info-level log message when package environments have been picked up
-------------------------------------+-------------------------------------
           Reporter:  hvr            |             Owner:  (none)
               Type:  feature        |            Status:  new
  request                            |
           Priority:  high           |         Milestone:  8.4.3
          Component:  Compiler       |           Version:  8.0.2
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 A common complaint with the new package environment files feature is that
 it's not obvious when package environments have be picked up. Even though
 this feature has been in GHC since GHC 8.0, now with cabal 2.2 turning on
 ghc env file generation, this getting wider exposure.

 A similiar UI issue existed with GHCi and its `.ghci` files and the
 solution there was to emit a message informing the user that an implicit
 configuration file was picked up:

 {{{
 GHCi, version 8.5.20180512: http://www.haskell.org/ghc/  :? for help
 Loaded GHCi configuration from /home/hvr/.ghci
 Prelude>
 }}}

 The same solution would greatly reduce the confusion with package
 environment files which have an even trickier lookup logic than `.ghci`
 files.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15145>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15145: Emit info-level log message when package environments have been picked up

GHC - devs mailing list
#15145: Emit info-level log message when package environments have been picked up
-------------------------------------+-------------------------------------
        Reporter:  hvr               |                Owner:  hvr
            Type:  feature request   |               Status:  new
        Priority:  high              |            Milestone:  8.4.3
       Component:  Compiler          |              Version:  8.0.2
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by hvr):

 * owner:  (none) => hvr


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15145#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15145: Emit info-level log message when package environments have been picked up

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15145: Emit info-level log message when package environments have been picked up
-------------------------------------+-------------------------------------
        Reporter:  hvr               |                Owner:  hvr
            Type:  feature request   |               Status:  patch
        Priority:  high              |            Milestone:  8.4.3
       Component:  Compiler          |              Version:  8.0.2
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4689
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by hvr):

 * status:  new => patch
 * differential:   => Phab:D4689


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15145#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15145: Emit info-level log message when package environments have been picked up

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15145: Emit info-level log message when package environments have been picked up
-------------------------------------+-------------------------------------
        Reporter:  hvr               |                Owner:  hvr
            Type:  feature request   |               Status:  patch
        Priority:  high              |            Milestone:  8.4.3
       Component:  Compiler          |              Version:  8.0.2
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4689
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Herbert Valerio Riedel <hvr@…>):

 In [changeset:"00049e2dce93b1e468c3fde3287371eb988aafdc/ghc"
 00049e2d/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="00049e2dce93b1e468c3fde3287371eb988aafdc"
 Emit info-level log message when package envs are loaded

 A common complaint with the new package environment files feature is
 that it's not obvious when package environments have been picked up.
 This patch applies the same strategy that was already used for `.ghci`
 files
 (which exhibit similar potential for confusion, c.f. #11389) to package
 environment files.

 For instance, this new notification looks like below for a GHCi invocation
 which
 loads both, a GHCi configuration as well as a package environment:

   GHCi, version 8.5.20180512: http://www.haskell.org/ghc/  :? for help
   Loaded package environment from
 /tmp/parsec-3.1.13.0/.ghc.environment.x86_64-linux-8.5.20180512
   Loaded GHCi configuration from /home/hvr/.ghci
   Prelude>

 Addresses #15145

 Reviewed By: bgamari, angerman

 GHC Trac Issues: #15145

 Differential Revision: https://phabricator.haskell.org/D4689
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15145#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15145: Emit info-level log message when package environments have been picked up

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15145: Emit info-level log message when package environments have been picked up
-------------------------------------+-------------------------------------
        Reporter:  hvr               |                Owner:  hvr
            Type:  feature request   |               Status:  merge
        Priority:  high              |            Milestone:  8.4.3
       Component:  Compiler          |              Version:  8.0.2
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4689
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by hvr):

 * status:  patch => merge


Comment:

 I'll mark this tentatively as merge to GHC 8.4.x as I have the impression
 this is highly demanded feature; the decision ultimately rests with Ben as
 the release manager

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15145#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15145: Emit info-level log message when package environments have been picked up

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15145: Emit info-level log message when package environments have been picked up
-------------------------------------+-------------------------------------
        Reporter:  hvr               |                Owner:  hvr
            Type:  feature request   |               Status:  merge
        Priority:  high              |            Milestone:  8.4.3
       Component:  Compiler          |              Version:  8.0.2
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4689
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by bgamari):

 This sounds reasonable enough to me in light of the recent discussion.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15145#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15145: Emit info-level log message when package environments have been picked up

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15145: Emit info-level log message when package environments have been picked up
-------------------------------------+-------------------------------------
        Reporter:  hvr               |                Owner:  hvr
            Type:  feature request   |               Status:  closed
        Priority:  high              |            Milestone:  8.4.3
       Component:  Compiler          |              Version:  8.0.2
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4689
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by bgamari):

 * status:  merge => closed
 * resolution:   => fixed


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15145#comment:6>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets