[GHC] #15157: Use a better string type (ByteString?!) for HsDocString

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #15157: Use a better string type (ByteString?!) for HsDocString

GHC - devs mailing list
#15157: Use a better string type (ByteString?!) for HsDocString
-------------------------------------+-------------------------------------
           Reporter:  sjakobi        |             Owner:  (none)
               Type:  task           |            Status:  new
           Priority:  normal         |         Milestone:  8.6.1
          Component:  Compiler       |           Version:  8.2.2
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 `HsDocString` is currently defined as

 {{{
 newtype HsDocString = HsDocString FastString
 }}}

 Alex Biehl and hvr mentioned that due to `FastString`'s (interning?)
 overhead it's not a good type to store haddocks. They suggested using
 `ByteString` instead.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15157>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15157: Use a better string type (ByteString?!) for HsDocString

GHC - devs mailing list
#15157: Use a better string type (ByteString?!) for HsDocString
-------------------------------------+-------------------------------------
        Reporter:  sjakobi           |                Owner:  (none)
            Type:  task              |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.2.2
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4743
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by sjakobi):

 * status:  new => patch
 * differential:   => Phab:D4743


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15157#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15157: Use a better string type (ByteString?!) for HsDocString

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15157: Use a better string type (ByteString?!) for HsDocString
-------------------------------------+-------------------------------------
        Reporter:  sjakobi           |                Owner:  (none)
            Type:  task              |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.2.2
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4743
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"d1beebb881722109d6935941e541eb175a9d6c62/ghc" d1beebb/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="d1beebb881722109d6935941e541eb175a9d6c62"
 Make HsDocString a newtype of ByteString

 Docstrings don't profit from FastString's interning, so we switch to
 a different type that doesn't incur this overhead.

 Updates the haddock submodule.

 Reviewers: alexbiehl, bgamari

 Reviewed By: alexbiehl, bgamari

 Subscribers: rwbarton, thomie, mpickering, carter

 GHC Trac Issues: #15157

 Differential Revision: https://phabricator.haskell.org/D4743
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15157#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15157: Use a better string type (ByteString?!) for HsDocString

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15157: Use a better string type (ByteString?!) for HsDocString
-------------------------------------+-------------------------------------
        Reporter:  sjakobi           |                Owner:  (none)
            Type:  task              |               Status:  closed
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.2.2
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4743
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by sjakobi):

 * status:  patch => closed
 * resolution:   => fixed


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15157#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets