[GHC] #15237: New SRT scheme breaks -fvia-C

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #15237: New SRT scheme breaks -fvia-C

GHC - devs mailing list
#15237: New SRT scheme breaks -fvia-C
-------------------------------------+-------------------------------------
           Reporter:  bgamari        |             Owner:  (none)
               Type:  bug            |            Status:  new
           Priority:  high           |         Milestone:  8.6.1
          Component:  Compiler       |           Version:  8.4.3
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 The SRT rework implemented in 2b0918c9834be1873728176e4944bec26271234a
 introduces a sub-word-size field into `StgSRT`. Unfortunately `-fvia-C`
 doesn't support such fields. This breaks CircleCI's unregisterised target.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15237>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15237: New SRT scheme breaks -fvia-C

GHC - devs mailing list
#15237: New SRT scheme breaks -fvia-C
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  high              |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by bgamari):

 * cc: simonmar (added)


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15237#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15237: New SRT scheme breaks -fvia-C

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15237: New SRT scheme breaks -fvia-C
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  high              |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by simonmar):

 Maybe we should just disable this optimisation for !TABLES_NEXT_TO_CODE.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15237#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15237: New SRT scheme breaks -fvia-C

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15237: New SRT scheme breaks -fvia-C
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  high              |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by bgamari):

 Yes, I think that would be the easiest way forward.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15237#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15237: New SRT scheme breaks -fvia-C

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15237: New SRT scheme breaks -fvia-C
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  high              |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by slyfox):

 * cc: slyfox (added)


Comment:

 Does CircleCI still try to run unregisterised GHC? I'd like to peek at
 failures you are seeing.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15237#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15237: New SRT scheme breaks -fvia-C

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15237: New SRT scheme breaks -fvia-C
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  high              |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by bgamari):

 Indeed I should have included a link: https://circleci.com/gh/ghc/ghc/5735

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15237#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15237: New SRT scheme breaks -fvia-C

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15237: New SRT scheme breaks -fvia-C
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  high              |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4837
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by slyfox):

 * differential:   => Phab:D4837


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15237#comment:6>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15237: New SRT scheme breaks -fvia-C

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15237: New SRT scheme breaks -fvia-C
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  high              |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4837
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"0238a6c78102d43dae2f56192bd3486e4f9ecf1d/ghc" 0238a6c/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="0238a6c78102d43dae2f56192bd3486e4f9ecf1d"
 UNREG: PprC: add support for of W32 literals

 Today UNREG build fails to generate sub-word literals:
 ```
   rts_dist_HC rts/dist/build/StgStartup.o
 ghc-stage1: panic! (the 'impossible' happened)
   (GHC version 8.5.20180612 for x86_64-unknown-linux):
         pprStatics: cannot emit a non-word-sized static literal
   W32
 ```

 The change allows combining two subwords into one word.

 Signed-off-by: Sergei Trofimovich <[hidden email]>

 Reviewers: simonmar, bgamari

 Reviewed By: bgamari

 Subscribers: rwbarton, thomie, carter

 GHC Trac Issues: #15237

 Differential Revision: https://phabricator.haskell.org/D4837
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15237#comment:7>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15237: New SRT scheme breaks -fvia-C

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15237: New SRT scheme breaks -fvia-C
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  bug               |               Status:  closed
        Priority:  high              |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4837
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by bgamari):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15237#comment:8>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15237: New SRT scheme breaks -fvia-C

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15237: New SRT scheme breaks -fvia-C
-------------------------------------+-------------------------------------
        Reporter:  bgamari           |                Owner:  (none)
            Type:  bug               |               Status:  closed
        Priority:  high              |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4837
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Sergei Trofimovich <slyfox@…>):

 In [changeset:"01c9d95aca12caf5c954320a2a82335b32568554/ghc"
 01c9d95a/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="01c9d95aca12caf5c954320a2a82335b32568554"
 UNREG: PprC: add support for of W16 literals (Ticket #15237)

 Fix UNREG build failure for 32-bit targets.

 This change is an equivalent of commit
 0238a6c78102d43dae2f56192bd3486e4f9ecf1d
 ("UNREG: PprC: add support for of W32 literals")

 The change allows combining two subwords into one word
 on 32-bit targets. Tested on nios2-unknown-linux-gnu.

 GHC Trac Issues: #15237

 Signed-off-by: Sergei Trofimovich <[hidden email]>
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15237#comment:9>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets