[GHC] #15303: API Annotations lost when parsing tyapp

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #15303: API Annotations lost when parsing tyapp

GHC - devs mailing list
#15303: API Annotations lost when parsing tyapp
-------------------------------------+-------------------------------------
           Reporter:  alanz          |             Owner:  (none)
               Type:  bug            |            Status:  new
           Priority:  normal         |         Milestone:  8.6.1
          Component:  Compiler       |           Version:  8.4.3
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  Incorrect API
  Unknown/Multiple                   |  annotation
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 In `Parser.y`, the `typapp` production has

 {{{#!hs
         | SIMPLEQUOTE qconop            {% ams (sLL $1 $> $ TyElOpr (unLoc
 $2))
                                                [mj AnnSimpleQuote $1] }
         | SIMPLEQUOTE varop             {% ams (sLL $1 $> $ TyElOpr (unLoc
 $2))
                                                [mj AnnSimpleQuote $1] }
 }}}

 By using `unLoc $2` we are discarding any annotations attached to the
 `qconop` or `qvarop`.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15303>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15303: API Annotations lost when parsing tyapp

GHC - devs mailing list
#15303: API Annotations lost when parsing tyapp
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Incorrect API     |  Unknown/Multiple
  annotation                         |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by alanz):

 * owner:  (none) => alanz


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15303#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15303: API Annotations lost when parsing tyapp

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15303: API Annotations lost when parsing tyapp
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Incorrect API     |  Unknown/Multiple
  annotation                         |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Alan Zimmerman <alan.zimm@…>):

 In [changeset:"e53c113dcfeca9ee957722ede3d8b6a2c4c751a1/ghc"
 e53c113d/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="e53c113dcfeca9ee957722ede3d8b6a2c4c751a1"
 API Annotations when parsing typapp

 Make sure the original annotations are still accessible for a promoted
 type.

 Closes #15303
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15303#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15303: API Annotations lost when parsing tyapp

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15303: API Annotations lost when parsing tyapp
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  merge
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Incorrect API     |  Unknown/Multiple
  annotation                         |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by alanz):

 * status:  new => merge


Comment:

 Merge to ghc-8.6 please.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15303#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15303: API Annotations lost when parsing tyapp

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15303: API Annotations lost when parsing tyapp
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  alanz
            Type:  bug               |               Status:  closed
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Incorrect API     |  Unknown/Multiple
  annotation                         |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by bgamari):

 * status:  merge => closed
 * resolution:   => fixed


Comment:

 Merged in 4cfeca02a0a9283e8c9f9ccd9373bc1f2fd8db0a.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15303#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets