[GHC] #15315: Renamer plugins could run after each group has been renamed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #15315: Renamer plugins could run after each group has been renamed

GHC - devs mailing list
#15315: Renamer plugins could run after each group has been renamed
-------------------------------------+-------------------------------------
           Reporter:  mpickering     |             Owner:  (none)
               Type:  bug            |            Status:  new
           Priority:  normal         |         Milestone:  8.6.1
          Component:  Compiler       |           Version:  8.4.3
           Keywords:  plugins        |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 In discussion with Ben, he suggested that it might be possible for a
 renamer plugin to run after each group had been renamed. This would then
 make it possible to modify renamed bindings.

 Currently, the interface for renamer plugins is quite strange and they run
 just before typechecker plugins in the implementation.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15315>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15315: Renamer plugins could run after each group has been renamed

GHC - devs mailing list
#15315: Renamer plugins could run after each group has been renamed
-------------------------------------+-------------------------------------
        Reporter:  mpickering        |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:  plugins
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4947
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by mpickering):

 * status:  new => patch
 * differential:   => Phab:D4947


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15315#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15315: Renamer plugins could run after each group has been renamed

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15315: Renamer plugins could run after each group has been renamed
-------------------------------------+-------------------------------------
        Reporter:  mpickering        |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:  plugins
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4947
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"1a79270c72cfcd98d683cfe7b2c777d8dd353b78/ghc" 1a79270/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="1a79270c72cfcd98d683cfe7b2c777d8dd353b78"
 Run the renamed source plugin after each HsGroup

 This allows modification of each `HsGroup` after it has been renamed.

 The old behaviour of keeping the renamed source until later can be
 recovered if desired by using the `keepRenamedSource` plugin but it
 shouldn't really be necessary as it can be inspected in the `TcGblEnv`.

 Reviewers: nboldi, bgamari, alpmestan

 Reviewed By: nboldi, alpmestan

 Subscribers: alpmestan, rwbarton, thomie, carter

 GHC Trac Issues: #15315

 Differential Revision: https://phabricator.haskell.org/D4947
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15315#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15315: Renamer plugins could run after each group has been renamed

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15315: Renamer plugins could run after each group has been renamed
-------------------------------------+-------------------------------------
        Reporter:  mpickering        |                Owner:  (none)
            Type:  bug               |               Status:  merge
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:  plugins
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4947
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by mpickering):

 * status:  patch => merge


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15315#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15315: Renamer plugins could run after each group has been renamed

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15315: Renamer plugins could run after each group has been renamed
-------------------------------------+-------------------------------------
        Reporter:  mpickering        |                Owner:  (none)
            Type:  bug               |               Status:  closed
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:  fixed             |             Keywords:  plugins
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4947
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by bgamari):

 * status:  merge => closed
 * resolution:   => fixed


Comment:

 Merged with b52cfe41e8abb2f1dd1e54ed1cf6ff7fcc0de210.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15315#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets