[GHC] #15341: :info prints kinds in closed type family equations without enabling -fprint-explicit-kinds

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #15341: :info prints kinds in closed type family equations without enabling -fprint-explicit-kinds

GHC - devs mailing list
#15341: :info prints kinds in closed type family equations without enabling
-fprint-explicit-kinds
-------------------------------------+-------------------------------------
           Reporter:  RyanGlScott    |             Owner:  (none)
               Type:  bug            |            Status:  new
           Priority:  normal         |         Milestone:  8.6.1
          Component:  Compiler       |           Version:  8.4.3
           Keywords:  TypeFamilies   |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 Load this file into GHCi:

 {{{#!hs
 {-# LANGUAGE PolyKinds #-}
 {-# LANGUAGE TypeFamilies #-}
 module Bug where

 type family Foo (a :: k) :: k where
   Foo a = a
 }}}

 And run `:info` on `Foo`:

 {{{
 $ /opt/ghc/8.4.3/bin/ghci Bug.hs
 GHCi, version 8.4.3: http://www.haskell.org/ghc/  :? for help
 Loaded GHCi configuration from /home/ryanglscott/.ghci
 [1 of 1] Compiling Bug              ( Bug.hs, interpreted )
 Ok, one module loaded.
 λ> :i Foo
 type family Foo (a :: k) :: k
   where Foo k a = a
         -- Defined at Bug.hs:5:1
 }}}

 Note that when printing the equation for `Foo`, the kind `k` is treated as
 though it were the first visible argument to `Foo`, even though `-fprint-
 explicit-kinds` is not enabled. This is because `ppr_tc_args` in
 `IfaceType` does not take `-fprint-explicit-kinds` into account.

 Patch incoming (pending a `./validate`).

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15341>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15341: :info prints kinds in closed type family equations without enabling -fprint-explicit-kinds

GHC - devs mailing list
#15341: :info prints kinds in closed type family equations without enabling
-fprint-explicit-kinds
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:  TypeFamilies
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4932
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by RyanGlScott):

 * status:  new => patch
 * differential:   => Phab:D4932


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15341#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15341: :info prints kinds in closed type family equations without enabling -fprint-explicit-kinds

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15341: :info prints kinds in closed type family equations without enabling
-fprint-explicit-kinds
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:  TypeFamilies
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4932
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ryan Scott <ryan.gl.scott@…>):

 In [changeset:"dbdcacfc55f28d8a85484cc1cf13dd78c45bf7ee/ghc" dbdcacf/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="dbdcacfc55f28d8a85484cc1cf13dd78c45bf7ee"
 Make ppr_tc_args aware of -fprint-explicit-kinds

 Summary:
 `ppr_tc_args` was printing invisible kind arguments even
 when `-fprint-explicit-kinds` wasn't enabled. Easily fixed.

 Test Plan: make test TEST=T15341

 Reviewers: goldfire, bgamari, simonpj

 Reviewed By: simonpj

 Subscribers: simonpj, rwbarton, thomie, carter

 GHC Trac Issues: #15341

 Differential Revision: https://phabricator.haskell.org/D4932
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15341#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15341: :info prints kinds in closed type family equations without enabling -fprint-explicit-kinds

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15341: :info prints kinds in closed type family equations without enabling
-fprint-explicit-kinds
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  merge
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:                    |             Keywords:  TypeFamilies
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
                                     |  ghci/scripts/T15341
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4932
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by RyanGlScott):

 * status:  patch => merge
 * testcase:   => ghci/scripts/T15341


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15341#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #15341: :info prints kinds in closed type family equations without enabling -fprint-explicit-kinds

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#15341: :info prints kinds in closed type family equations without enabling
-fprint-explicit-kinds
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  closed
        Priority:  normal            |            Milestone:  8.6.1
       Component:  Compiler          |              Version:  8.4.3
      Resolution:  fixed             |             Keywords:  TypeFamilies
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
                                     |  ghci/scripts/T15341
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4932
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by bgamari):

 * status:  merge => closed
 * resolution:   => fixed


Comment:

 comment:2 merged in 7b8dcd90c5a622146dfdd3b162a1f1b1d262d5cf.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15341#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets