[GHC] #16001: hadrian doesn't support setting intree gmp configuration explicitly

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #16001: hadrian doesn't support setting intree gmp configuration explicitly

GHC - devs mailing list
#16001: hadrian doesn't support setting intree gmp configuration explicitly
-------------------------------------+-------------------------------------
           Reporter:  carter         |             Owner:  (none)
               Type:  bug            |            Status:  new
           Priority:  normal         |         Milestone:  8.8.1
          Component:  Build System   |           Version:  8.6.2
  (Hadrian)                          |
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16001>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #16001: hadrian doesn't support setting intree gmp configuration explicitly

GHC - devs mailing list
#16001: hadrian doesn't support setting intree gmp configuration explicitly
-------------------------------------+-------------------------------------
        Reporter:  carter            |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Build System      |              Version:  8.6.2
  (Hadrian)                          |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by carter):

 doesn't seem to be any way for the user to set this as a flag

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16001#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #16001: hadrian doesn't support setting intree gmp configuration explicitly

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#16001: hadrian doesn't support setting intree gmp configuration explicitly
-------------------------------------+-------------------------------------
        Reporter:  carter            |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Build System      |              Version:  8.6.2
  (Hadrian)                          |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by harpocrates):

 * cc: harpocrates, snowleopard, alpmestan (added)


Comment:

 Frustratingly enough, there isn't a direct way to do this in the Make
 system either (you're responsible for re-configuring `./libraries/integer-
 gmp/configure --with-intree-gmp`).

 I think this means that we'll need to tweak the toplevel
 `configure.ac`/`aclocal.m4` scripts to support `--with-intree-gmp` (and
 `--with-gmp-framework-preferred` while we're at it). My main question is:
 do we also need to make sure these new options do something for the old
 Make system too?

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16001#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #16001: hadrian doesn't support setting intree gmp configuration explicitly

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#16001: hadrian doesn't support setting intree gmp configuration explicitly
-------------------------------------+-------------------------------------
        Reporter:  carter            |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Build System      |              Version:  8.6.2
  (Hadrian)                          |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by adamse):

 * cc: adamse (added)


Comment:

 In the make system you can uncomment/add {{{libraries/integer-
 gmp_CONFIGURE_OPTS += --configure-option=--with-intree-gmp}}} to your
 {{{mk/build.mk}}}.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16001#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #16001: hadrian doesn't support setting intree gmp configuration explicitly

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#16001: hadrian doesn't support setting intree gmp configuration explicitly
-------------------------------------+-------------------------------------
        Reporter:  carter            |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Build System      |              Version:  8.6.2
  (Hadrian)                          |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by alpmestan):

 We could perhaps add a flag? We already have

 {{{
   --integer-simple            Build GHC with integer-simple library.
 }}}

 after all, where we're using integer-gmp (currently assuming system wide
 libgmp if I'm not mistaken?) as a default, when this flag is not given. We
 could instead perhaps have:

 {{{
   --integer-simple
   --system-gmp
   --in-tree-gmp
 }}}

 with `--system-gmp` being the default? The last two would imply the use of
 integer-gmp, of course.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16001#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #16001: hadrian doesn't support setting intree gmp configuration explicitly

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#16001: hadrian doesn't support setting intree gmp configuration explicitly
-------------------------------------+-------------------------------------
        Reporter:  carter            |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Build System      |              Version:  8.6.2
  (Hadrian)                          |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D5417
       Wiki Page:                    |
-------------------------------------+-------------------------------------
Changes (by harpocrates):

 * status:  new => patch
 * differential:   => Phab:D5417


--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16001#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #16001: hadrian doesn't support setting intree gmp configuration explicitly

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#16001: hadrian doesn't support setting intree gmp configuration explicitly
-------------------------------------+-------------------------------------
        Reporter:  carter            |                Owner:  (none)
            Type:  bug               |               Status:  closed
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Build System      |              Version:  8.6.2
  (Hadrian)                          |
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |  https://gitlab.haskell.org/ghc/ghc/merge_requests/138
-------------------------------------+-------------------------------------
Changes (by alpmestan):

 * status:  patch => closed
 * differential:  Phab:D5417 =>
     https://gitlab.haskell.org/ghc/ghc/merge_requests/138
 * resolution:   => fixed


Comment:

 The patch got merged on gitlab:
 https://gitlab.haskell.org/ghc/ghc/merge_requests/138

 Closing.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16001#comment:6>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #16001: hadrian doesn't support setting intree gmp configuration explicitly

GHC - devs mailing list
In reply to this post by GHC - devs mailing list
#16001: hadrian doesn't support setting intree gmp configuration explicitly
-------------------------------------+-------------------------------------
        Reporter:  carter            |                Owner:  (none)
            Type:  bug               |               Status:  closed
        Priority:  normal            |            Milestone:  8.8.1
       Component:  Build System      |              Version:  8.6.2
  (Hadrian)                          |
      Resolution:  fixed             |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |  https://gitlab.haskell.org/ghc/ghc/merge_requests/138
-------------------------------------+-------------------------------------

Comment (by Ben Gamari <ben@…>):

 In [changeset:"efc95841503a78504c0aa00925fb22c4ec4627af/ghc"
 efc95841/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="efc95841503a78504c0aa00925fb22c4ec4627af"
 Hadrian: support in-tree GMP

 Summary:
 This adds top-level configure flags '--with-intree-gmp' and
 '--with-framework-preferred', both of which are especially relevant
 on MacOS.

 Besides gaining two new flags, Hadrian also had to be taught what to
 do with the 'framework' in .cabal files.

 Test Plan:
 ./boot && ./configure --with-intree-gmp && ./hadrian/build.sh
 ./boot && ./configure --with-gmp-framework-preferred && ./hadrian/build.sh
 # on macos

 Reviewers: carter, snowleopard, alpmestan, hvr, goldfire, bgamari

 Subscribers: rwbarton, erikd

 GHC Trac Issues: #16001

 Differential Revision: https://phabricator.haskell.org/D5417
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16001#comment:7>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets