[GHC] #16325: Hadrian should respect the build root setting for the testsuite and its own binaries

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GHC] #16325: Hadrian should respect the build root setting for the testsuite and its own binaries

GHC - devs mailing list
#16325: Hadrian should respect the build root setting for the testsuite and its own
binaries
-------------------------------------+-------------------------------------
           Reporter:  snowleopard    |             Owner:  (none)
               Type:  bug            |            Status:  new
           Priority:  normal         |         Milestone:
          Component:  Build System   |           Version:  8.6.3
  (Hadrian)                          |
           Keywords:                 |  Operating System:  Unknown/Multiple
       Architecture:                 |   Type of failure:  None/Unknown
  Unknown/Multiple                   |
          Test Case:                 |        Blocked By:
           Blocking:                 |   Related Tickets:
Differential Rev(s):                 |         Wiki Page:
-------------------------------------+-------------------------------------
 Currently the `--build-root` setting is respected only partially:

 * The `test` rule appears to be placing all testsuite build artefacts
 right in the GHC tree `./testsuite`.

 * Hadrian puts its own binaries also in the GHC tree, into the
 `./hadrian/X` directory, where `X` depends on whether we build with Cabal
 or Stack.

 We should improve on this and provide more guarantees about where all
 build artefacts go.

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16325>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets
Reply | Threaded
Open this post in threaded view
|

Re: [GHC] #16325: Hadrian should respect the build root setting for the testsuite and its own binaries

GHC - devs mailing list
#16325: Hadrian should respect the build root setting for the testsuite and its own
binaries
-------------------------------------+-------------------------------------
        Reporter:  snowleopard       |                Owner:  (none)
            Type:  bug               |               Status:  new
        Priority:  normal            |            Milestone:
       Component:  Build System      |              Version:  8.6.3
  (Hadrian)                          |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Marge Bot <ben+marge-bot@…>):

 In [changeset:"5d7441432e4c00a463f645248b354707d7d8335e/ghc" 5d74414/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="5d7441432e4c00a463f645248b354707d7d8335e"
 Hadrian: Drop remaining symlink traversal code from build scripts

 This partly resolves #16325
 (https://ghc.haskell.org/trac/ghc/ticket/16325).

 As previously discussed in
 https://github.com/snowleopard/hadrian/issues/667,
 we do not need the symlink traversal code in build scripts. However, it
 appears we forgot to delete this code from our Stack-based build scripts,
 which led to placing all build artefacts in an unexpected location when
 using Hadrian in combination with symlink trees. This commit fixes this.
 }}}

--
Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/16325#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
ghc-tickets mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-tickets