Quantcast

[GHC] #4421: Compilation performance regression

classic Classic list List threaded Threaded
11 messages Options
GHC
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[GHC] #4421: Compilation performance regression

GHC
#4421: Compilation performance regression
---------------------------------+------------------------------------------
    Reporter:  simonmar          |        Owner:              
        Type:  bug               |       Status:  new        
    Priority:  highest           |    Milestone:  7.0.1      
   Component:  Compiler          |      Version:  6.12.3      
    Keywords:                    |     Testcase:              
   Blockedby:                    |   Difficulty:              
          Os:  Unknown/Multiple  |     Blocking:              
Architecture:  Unknown/Multiple  |      Failure:  None/Unknown
---------------------------------+------------------------------------------
 This patch

 {{{
 Tue Oct 19 08:45:52 PDT 2010  Ian Lynagh <[hidden email]>
   * seq the unfolding in setUnfoldingInfo
   Contrary to the comment, for the module in #4367 at least, it is a big
   improvement. Without it we get a huge spike of drag.
 }}}

 Had a big impact on compile times, we probably need to address the leak
 some other way.   HEAD before the patch, compiling Cabal with -O:

 {{{
   45,244,270,096 bytes allocated in the heap
    7,967,118,472 bytes copied during GC
      162,341,616 bytes maximum residency (40 sample(s))
       21,318,984 bytes maximum slop
              472 MB total memory in use (0 MB lost due to fragmentation)

   Generation 0: 85611 collections,     0 parallel, 25.94s, 25.95s elapsed
   Generation 1:    40 collections,     0 parallel, 10.13s, 10.14s elapsed

   INIT  time    0.00s  (  0.00s elapsed)
   MUT   time   42.92s  ( 45.75s elapsed)
   GC    time   36.07s  ( 36.09s elapsed)
   EXIT  time    0.00s  (  0.00s elapsed)
   Total time   78.99s  ( 81.84s elapsed)
 }}}

 and after the patch:

 {{{
   67,912,400,256 bytes allocated in the heap
   10,084,908,352 bytes copied during GC
       88,734,416 bytes maximum residency (67 sample(s))
       18,782,600 bytes maximum slop
              268 MB total memory in use (0 MB lost due to fragmentation)

   INIT  time    0.00s  (  0.00s elapsed)
   MUT   time   57.62s  ( 60.52s elapsed)
   GC    time   47.92s  ( 47.96s elapsed)
   EXIT  time    0.00s  (  0.00s elapsed)
   Total time  105.55s  (108.48s elapsed)
 }}}

 overall space usage is much better (268M vs. 472M), but allocations and
 total time are much worse.

 Results for 6.12.3:

 {{{
   26,404,281,056 bytes allocated in the heap
    6,533,229,296 bytes copied during GC
       91,037,368 bytes maximum residency (49 sample(s))
       17,657,552 bytes maximum slop
              271 MB total memory in use (4 MB lost due to fragmentation)

   INIT  time    0.00s  (  0.00s elapsed)
   MUT   time   34.32s  ( 36.88s elapsed)
   GC    time   24.46s  ( 25.25s elapsed)
   EXIT  time    0.00s  (  0.00s elapsed)
   Total time   58.78s  ( 62.13s elapsed)
 }}}

 and for STABLE (before the offending patch):

 {{{
   32,812,959,504 bytes allocated in the heap
    7,358,388,512 bytes copied during GC
      159,592,480 bytes maximum residency (39 sample(s))
       20,403,664 bytes maximum slop
              466 MB total memory in use (0 MB lost due to fragmentation)

   INIT  time    0.00s  (  0.00s elapsed)
   MUT   time   38.59s  ( 41.45s elapsed)
   GC    time   30.72s  ( 30.74s elapsed)
   EXIT  time    0.00s  (  0.00s elapsed)
   Total time   69.32s  ( 72.19s elapsed)
 }}}

 HEAD is worse than STABLE right now, probably due to the containers
 package changes.

 STABLE has still regressed relative to 6.12.3, though.

--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4421>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
_______________________________________________
Glasgow-haskell-bugs mailing list
[hidden email]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
GHC
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [GHC] #4421: Compilation performance regression

GHC
#4421: Compilation performance regression
---------------------------------+------------------------------------------
    Reporter:  simonmar          |        Owner:  igloo      
        Type:  bug               |       Status:  new        
    Priority:  highest           |    Milestone:  7.0.1      
   Component:  Compiler          |      Version:  6.12.3      
    Keywords:                    |     Testcase:              
   Blockedby:                    |   Difficulty:              
          Os:  Unknown/Multiple  |     Blocking:              
Architecture:  Unknown/Multiple  |      Failure:  None/Unknown
---------------------------------+------------------------------------------
Changes (by igloo):

  * owner:  => igloo


--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4421#comment:1>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
_______________________________________________
Glasgow-haskell-bugs mailing list
[hidden email]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
GHC
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [GHC] #4421: Compilation performance regression

GHC
In reply to this post by GHC
#4421: Compilation performance regression
---------------------------------+------------------------------------------
    Reporter:  simonmar          |        Owner:  igloo      
        Type:  bug               |       Status:  new        
    Priority:  highest           |    Milestone:  7.0.1      
   Component:  Compiler          |      Version:  6.12.3      
    Keywords:                    |     Testcase:              
   Blockedby:                    |   Difficulty:              
          Os:  Unknown/Multiple  |     Blocking:              
Architecture:  Unknown/Multiple  |      Failure:  None/Unknown
---------------------------------+------------------------------------------

Comment(by igloo):

 With the patch, I was seeing
 {{{
   70,966,109,224 bytes allocated in the heap
   10,517,401,920 bytes copied during GC
       88,885,320 bytes maximum residency (67 sample(s))
       19,679,064 bytes maximum slop
              273 MB total memory in use (0 MB lost due to fragmentation)

   INIT  time    0.00s  (  0.00s elapsed)
   MUT   time   74.56s  ( 77.79s elapsed)
   GC    time   78.38s  ( 78.31s elapsed)
   EXIT  time    0.00s  (  0.00s elapsed)
   Total time  152.95s  (156.10s elapsed)
 }}}
 but after
 {{{
 Wed Oct 20 14:15:39 BST 2010  Ian Lynagh <[hidden email]>
   * Avoid hanging on to old unfoldings; fixes #4367 (compiler space
 regression)
 Wed Oct 20 15:37:10 BST 2010  Ian Lynagh <[hidden email]>
   * Don't seq unfoldings
 }}}
 I see
 {{{
   46,804,639,544 bytes allocated in the heap
    7,954,212,312 bytes copied during GC
      123,843,728 bytes maximum residency (47 sample(s))
       20,877,992 bytes maximum slop
              377 MB total memory in use (0 MB lost due to fragmentation)

   INIT  time    0.00s  (  0.00s elapsed)
   MUT   time   54.89s  ( 58.56s elapsed)
   GC    time   55.02s  ( 55.03s elapsed)
   EXIT  time    0.00s  (  0.00s elapsed)
   Total time  109.91s  (113.59s elapsed)
 }}}
 so time and allocs look good, but total mem usage is high (but not as high
 as it used to be). Presumably we still sometimes retain old unfoldings,
 but not in cases that happen with the #4367 testcase.

--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4421#comment:2>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
_______________________________________________
Glasgow-haskell-bugs mailing list
[hidden email]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
GHC
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [GHC] #4421: Compilation performance regression

GHC
In reply to this post by GHC
#4421: Compilation performance regression
---------------------------------+------------------------------------------
    Reporter:  simonmar          |        Owner:  igloo      
        Type:  bug               |       Status:  new        
    Priority:  highest           |    Milestone:  7.0.2      
   Component:  Compiler          |      Version:  6.12.3      
    Keywords:                    |     Testcase:              
   Blockedby:                    |   Difficulty:              
          Os:  Unknown/Multiple  |     Blocking:              
Architecture:  Unknown/Multiple  |      Failure:  None/Unknown
---------------------------------+------------------------------------------
Changes (by simonpj):

  * milestone:  7.0.1 => 7.0.2


--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4421#comment:3>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler
_______________________________________________
Glasgow-haskell-bugs mailing list
[hidden email]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
GHC
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [GHC] #4421: Compilation performance regression

GHC
In reply to this post by GHC
#4421: Compilation performance regression
---------------------------------+------------------------------------------
    Reporter:  simonmar          |        Owner:  igloo      
        Type:  bug               |       Status:  new        
    Priority:  highest           |    Milestone:  7.0.3      
   Component:  Compiler          |      Version:  6.12.3      
    Keywords:                    |     Testcase:              
   Blockedby:                    |   Difficulty:              
          Os:  Unknown/Multiple  |     Blocking:              
Architecture:  Unknown/Multiple  |      Failure:  None/Unknown
---------------------------------+------------------------------------------
Changes (by igloo):

  * milestone:  7.0.2 => 7.0.3


--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4421#comment:4>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
Glasgow-haskell-bugs mailing list
[hidden email]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
GHC
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [GHC] #4421: Compilation performance regression

GHC
In reply to this post by GHC
#4421: Compilation performance regression
---------------------------------+------------------------------------------
    Reporter:  simonmar          |        Owner:  igloo                      
        Type:  bug               |       Status:  new                        
    Priority:  highest           |    Milestone:  7.2.1                      
   Component:  Compiler          |      Version:  6.12.3                      
    Keywords:                    |     Testcase:                              
   Blockedby:                    |   Difficulty:                              
          Os:  Unknown/Multiple  |     Blocking:                              
Architecture:  Unknown/Multiple  |      Failure:  Compile-time performance bug
---------------------------------+------------------------------------------
Changes (by batterseapower):

  * failure:  None/Unknown => Compile-time performance bug


--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4421#comment:5>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
Glasgow-haskell-bugs mailing list
[hidden email]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
GHC
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [GHC] #4421: Compilation performance regression

GHC
In reply to this post by GHC
#4421: Compilation performance regression
---------------------------------+------------------------------------------
    Reporter:  simonmar          |        Owner:  igloo                      
        Type:  bug               |       Status:  new                        
    Priority:  high              |    Milestone:  7.2.1                      
   Component:  Compiler          |      Version:  6.12.3                      
    Keywords:                    |     Testcase:                              
   Blockedby:                    |   Difficulty:                              
          Os:  Unknown/Multiple  |     Blocking:                              
Architecture:  Unknown/Multiple  |      Failure:  Compile-time performance bug
---------------------------------+------------------------------------------
Changes (by igloo):

  * priority:  highest => high


--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4421#comment:6>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
Glasgow-haskell-bugs mailing list
[hidden email]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
GHC
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [GHC] #4421: Compilation performance regression

GHC
In reply to this post by GHC
#4421: Compilation performance regression
---------------------------------+------------------------------------------
    Reporter:  simonmar          |        Owner:  igloo                      
        Type:  bug               |       Status:  new                        
    Priority:  high              |    Milestone:  7.4.1                      
   Component:  Compiler          |      Version:  6.12.3                      
    Keywords:                    |     Testcase:                              
   Blockedby:                    |   Difficulty:                              
          Os:  Unknown/Multiple  |     Blocking:                              
Architecture:  Unknown/Multiple  |      Failure:  Compile-time performance bug
---------------------------------+------------------------------------------
Changes (by igloo):

  * milestone:  7.2.1 => 7.4.1


--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4421#comment:7>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
Glasgow-haskell-bugs mailing list
[hidden email]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
GHC
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [GHC] #4421: Compilation performance regression

GHC
In reply to this post by GHC
#4421: Compilation performance regression
---------------------------------+------------------------------------------
    Reporter:  simonmar          |       Owner:  igloo                      
        Type:  bug               |      Status:  new                        
    Priority:  high              |   Milestone:  7.4.2                      
   Component:  Compiler          |     Version:  6.12.3                      
    Keywords:                    |          Os:  Unknown/Multiple            
Architecture:  Unknown/Multiple  |     Failure:  Compile-time performance bug
  Difficulty:  Unknown           |    Testcase:                              
   Blockedby:                    |    Blocking:                              
     Related:                    |  
---------------------------------+------------------------------------------
Changes (by igloo):

  * difficulty:  => Unknown
  * milestone:  7.4.1 => 7.4.2


--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4421#comment:8>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
Glasgow-haskell-bugs mailing list
[hidden email]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
GHC
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [GHC] #4421: Compilation performance regression

GHC
In reply to this post by GHC
#4421: Compilation performance regression
---------------------------------+------------------------------------------
    Reporter:  simonmar          |       Owner:  igloo                      
        Type:  bug               |      Status:  new                        
    Priority:  high              |   Milestone:  7.6.1                      
   Component:  Compiler          |     Version:  6.12.3                      
    Keywords:                    |          Os:  Unknown/Multiple            
Architecture:  Unknown/Multiple  |     Failure:  Compile-time performance bug
  Difficulty:  Unknown           |    Testcase:                              
   Blockedby:                    |    Blocking:                              
     Related:                    |  
---------------------------------+------------------------------------------
Changes (by igloo):

  * milestone:  7.4.2 => 7.6.1


--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4421#comment:9>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
Glasgow-haskell-bugs mailing list
[hidden email]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
GHC
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [GHC] #4421: Compilation performance regression

GHC
In reply to this post by GHC
#4421: Compilation performance regression
-------------------------------------------+--------------------------------
  Reporter:  simonmar                      |          Owner:  igloo          
      Type:  bug                           |         Status:  closed          
  Priority:  high                          |      Milestone:  7.6.1          
 Component:  Compiler                      |        Version:  6.12.3          
Resolution:  fixed                         |       Keywords:                  
        Os:  Unknown/Multiple              |   Architecture:  Unknown/Multiple
   Failure:  Compile-time performance bug  |     Difficulty:  Unknown        
  Testcase:                                |      Blockedby:                  
  Blocking:                                |        Related:                  
-------------------------------------------+--------------------------------
Changes (by igloo):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 The regression is mostly fixed, and compiler performance is just something
 we need to keep a general eye on. I've done some profiling and things
 generally look OK, so I think I'll just close this ticket now.

--
Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/4421#comment:10>
GHC <http://www.haskell.org/ghc/>
The Glasgow Haskell Compiler

_______________________________________________
Glasgow-haskell-bugs mailing list
[hidden email]
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Loading...