GitLab CI for patches across submodules

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

GitLab CI for patches across submodules

GHC - devs mailing list
Hi,

I just tried to use GitLab CI to validate a GHC patch including changes to Haddock: https://gitlab.haskell.org/sjakobi/ghc/pipelines/842

The problem is that the CI script tries to find my Haddock commit at https://gitlab.haskell.org/ghc/haddock. But that repo doesn't even allow merge request.

Should the submodule origin for util/haddock maybe point at https://github.com/haskell/haddock instead?

Cheers,
Simon

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: GitLab CI for patches across submodules

Ben Gamari-2
Simon Jakobi via ghc-devs <[hidden email]> writes:

> Hi,
>
> I just tried to use GitLab CI to validate a GHC patch including changes to
> Haddock: https://gitlab.haskell.org/sjakobi/ghc/pipelines/842
>
> The problem is that the CI script tries to find my Haddock commit at
> https://gitlab.haskell.org/ghc/haddock. But that repo doesn't even allow
> merge request.
>
> Should the submodule origin for util/haddock maybe point at
> https://github.com/haskell/haddock instead?
>
In general we want to ensure that only *.haskell.org hosts are relied on
during normal builds (since some users build artifacts under very
restrictive sandbox conditions). However, we can certainly use the
upstream repo during CI builds.

I have opened !78 which should hopefully fix this. Perhaps you could
rebase on topp of this and check?

Cheers,

- Ben

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: GitLab CI for patches across submodules

GHC - devs mailing list
Am Sa., 5. Jan. 2019 um 22:18 Uhr schrieb Ben Gamari <[hidden email]>:

However, we can certainly use the upstream repo during CI builds. 
 
I have opened !78 which should hopefully fix this. Perhaps you could
rebase on topp of this and check?

Thanks, Ben, that works for me.

What I hadn't realized before, is that having my haddock commit in my Gitlab fork (sjakobi/haddock) apparently also makes it accessible through ghc/haddock.
What is my-branch in sjakobi/haddock is sjakobi/my-branch in ghc/haddock.

Cheers,
Simon

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs