GitLab: Cmd+Enter considered harmful on reviews

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

GitLab: Cmd+Enter considered harmful on reviews

Richard Eisenberg-4
PSA: When reviewing an MR on GitLab, every comment has two buttons: (1) add to review, and (2) add comment now. Cmd+Enter (on my machine at least), does option (2), even though option (1) is bold and green. This is not what I wanted. (By the way, "comments" actually open these things called "discussions", which can be resolved. But that's another matter.)

I've now removed all my comments and added them to my review. But I wanted you all to know about this in case you stumble across the same problem.

Richard
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: GitLab: Cmd+Enter considered harmful on reviews

Ben Gamari-2
Richard Eisenberg <[hidden email]> writes:

> PSA: When reviewing an MR on GitLab, every comment has two buttons:
> (1) add to review, and (2) add comment now. Cmd+Enter (on my machine
> at least), does option (2), even though option (1) is bold and green.
> This is not what I wanted. (By the way, "comments" actually open these
> things called "discussions", which can be resolved. But that's another
> matter.)
>
Hmm, strange. I can't seem to reproduce this. Which browser are you
using?

Cheers,

- Ben


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: GitLab: Cmd+Enter considered harmful on reviews

Richard Eisenberg-4
I'm on Firefox.

It doesn't matter all that much, really. I was hoping that a review was its own thing. But GitLab doesn't do that: a review is just a set of comments all delivered at the same time. Now that I've posted my review, my comments have become 49 separate "discussions". Oof.

Richard

> On Jan 4, 2019, at 1:09 PM, Ben Gamari <[hidden email]> wrote:
>
> Richard Eisenberg <[hidden email]> writes:
>
>> PSA: When reviewing an MR on GitLab, every comment has two buttons:
>> (1) add to review, and (2) add comment now. Cmd+Enter (on my machine
>> at least), does option (2), even though option (1) is bold and green.
>> This is not what I wanted. (By the way, "comments" actually open these
>> things called "discussions", which can be resolved. But that's another
>> matter.)
>>
> Hmm, strange. I can't seem to reproduce this. Which browser are you
> using?
>
> Cheers,
>
> - Ben
>

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs