Gitlab bug?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Gitlab bug?

GHC - devs mailing list

Look here:

https://gitlab.haskell.org/ghc/ghc/merge_requests/444/diffs#350c4076427c611b8f14e875a4ca553041c2b847_1930_1925

Look at the comment “Is this zipping necessary? We haven't zonked the scoped_kvs or the tc_tvs, I think” from Richard Eisenberg, just below line 1925 in TcHsType.

 

Now click on the grey “…” above his comment, to expand more code lines above.

 

Uh oh! 

  • The same comment now occurs twice, just below line 1904, and again just below 1925.
  • The first time it’s on the wrong line of code
  • But in the second position (the correct one) the “Reply” box is inactive.  I can’t type into it.

 

Is this is a bug? How to report it?

 

Simon


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Gitlab bug?

Tobias Dammers
It seems to behave just fine on my computer.

Maybe some sort of cache-related race condition is going on in the
client-side JavaScript here? A hard page reload might "fix" that.

On Tue, Feb 26, 2019 at 10:18:02AM +0000, Simon Peyton Jones via ghc-devs wrote:

> Look here:
> https://gitlab.haskell.org/ghc/ghc/merge_requests/444/diffs#350c4076427c611b8f14e875a4ca553041c2b847_1930_1925
> Look at the comment "Is this zipping necessary? We haven't zonked the scoped_kvs or the tc_tvs, I think" from Richard Eisenberg, just below line 1925 in TcHsType.
>
> Now click on the grey "..." above his comment, to expand more code lines above.
>
> Uh oh!
>
>   *   The same comment now occurs twice, just below line 1904, and again just below 1925.
>   *   The first time it's on the wrong line of code
>   *   But in the second position (the correct one) the "Reply" box is inactive.  I can't type into it.
>
> Is this is a bug? How to report it?
>
> Simon

> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


--
Tobias Dammers - [hidden email]
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: Gitlab bug?

GHC - devs mailing list
oddly reloading made no difference.   Curious

|  -----Original Message-----
|  From: ghc-devs <[hidden email]> On Behalf Of Tobias Dammers
|  Sent: 26 February 2019 10:58
|  To: [hidden email]
|  Subject: Re: Gitlab bug?
|  
|  It seems to behave just fine on my computer.
|  
|  Maybe some sort of cache-related race condition is going on in the
|  client-side JavaScript here? A hard page reload might "fix" that.
|  
|  On Tue, Feb 26, 2019 at 10:18:02AM +0000, Simon Peyton Jones via ghc-devs
|  wrote:
|  > Look here:
|  > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl
|  > ab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F444%2Fdiffs%23350c407642
|  > 7c611b8f14e875a4ca553041c2b847_1930_1925&amp;data=02%7C01%7Csimonpj%40
|  > microsoft.com%7C73ba769b877042937f8408d69bd95350%7C72f988bf86f141af91a
|  > b2d7cd011db47%7C1%7C0%7C636867755046893023&amp;sdata=%2BMP4GdPPkz3XD%2
|  > Fsk4VGSMTI27QXKMg45rHo5KLbWmaQ%3D&amp;reserved=0
|  > Look at the comment "Is this zipping necessary? We haven't zonked the
|  scoped_kvs or the tc_tvs, I think" from Richard Eisenberg, just below
|  line 1925 in TcHsType.
|  >
|  > Now click on the grey "..." above his comment, to expand more code
|  lines above.
|  >
|  > Uh oh!
|  >
|  >   *   The same comment now occurs twice, just below line 1904, and
|  again just below 1925.
|  >   *   The first time it's on the wrong line of code
|  >   *   But in the second position (the correct one) the "Reply" box is
|  inactive.  I can't type into it.
|  >
|  > Is this is a bug? How to report it?
|  >
|  > Simon
|  
|  > _______________________________________________
|  > ghc-devs mailing list
|  > [hidden email]
|  > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.
|  > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&amp;data=02%7C01
|  > %7Csimonpj%40microsoft.com%7C73ba769b877042937f8408d69bd95350%7C72f988
|  > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636867755046898017&amp;sdata=dyXl
|  > kGvSzPUHdcdib6La7MqYhcNqeI%2Falmet4zXC6LU%3D&amp;reserved=0
|  
|  
|  --
|  Tobias Dammers - [hidden email]
|  _______________________________________________
|  ghc-devs mailing list
|  [hidden email]
|  https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.has
|  kell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-
|  devs&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C73ba769b877042937f8408d
|  69bd95350%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636867755046898017
|  &amp;sdata=dyXlkGvSzPUHdcdib6La7MqYhcNqeI%2Falmet4zXC6LU%3D&amp;reserved=
|  0
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Gitlab bug?

Richard Eisenberg-4
In reply to this post by GHC - devs mailing list
I can reproduce:



Is there a good place to report this?

Richard

On Feb 26, 2019, at 5:18 AM, Simon Peyton Jones via ghc-devs <[hidden email]> wrote:

Look here:

https://gitlab.haskell.org/ghc/ghc/merge_requests/444/diffs#350c4076427c611b8f14e875a4ca553041c2b847_1930_1925

Look at the comment “Is this zipping necessary? We haven't zonked the scoped_kvs or the tc_tvs, I think” from Richard Eisenberg, just below line 1925 in TcHsType.

 

Now click on the grey “…” above his comment, to expand more code lines above.

 

Uh oh!  

  • The same comment now occurs twice, just below line 1904, and again just below 1925.
  • The first time it’s on the wrong line of code
  • But in the second position (the correct one) the “Reply” box is inactive.  I can’t type into it.

 

Is this is a bug? How to report it?

 

Simon

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Gitlab bug?

Richard Eisenberg-4
And a new bug: When I visit https://gitlab.haskell.org/ghc/ghc/merge_requests/444/diffs#note_8328, I see 6/13 discussions resolved, but the button to go to first unresolved discussion goes nowhere. And when I scroll through the page, expanding every file I see, I still can't find these unresolved discussions. :(

Richard

On Feb 26, 2019, at 7:59 AM, Richard Eisenberg <[hidden email]> wrote:

I can reproduce:

<Screen Shot 2019-02-26 at 7.58.52 AM.png>

Is there a good place to report this?

Richard

On Feb 26, 2019, at 5:18 AM, Simon Peyton Jones via ghc-devs <[hidden email]> wrote:

Look here:

https://gitlab.haskell.org/ghc/ghc/merge_requests/444/diffs#350c4076427c611b8f14e875a4ca553041c2b847_1930_1925

Look at the comment “Is this zipping necessary? We haven't zonked the scoped_kvs or the tc_tvs, I think” from Richard Eisenberg, just below line 1925 in TcHsType.

 

Now click on the grey “…” above his comment, to expand more code lines above.

 

Uh oh!  

  • The same comment now occurs twice, just below line 1904, and again just below 1925.
  • The first time it’s on the wrong line of code
  • But in the second position (the correct one) the “Reply” box is inactive.  I can’t type into it.

 

Is this is a bug? How to report it?

 

Simon

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs



_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Gitlab bug?

Tobias Dammers
In reply to this post by Richard Eisenberg-4
I'd guesstimate that gitlab's issue tracker would be a good place:

https://gitlab.com/gitlab-org/gitlab-ce/issues/

Though it's probably going to be helpful for Ben to somehow get
involved, seeing how he's been working with the Gitlab team on other
issues already.

On Tue, Feb 26, 2019 at 07:59:48AM -0500, Richard Eisenberg wrote:

> I can reproduce:
>
>
>
> Is there a good place to report this?
>
> Richard
>
> > On Feb 26, 2019, at 5:18 AM, Simon Peyton Jones via ghc-devs <[hidden email]> wrote:
> >
> > Look here:
> >
> > https://gitlab.haskell.org/ghc/ghc/merge_requests/444/diffs#350c4076427c611b8f14e875a4ca553041c2b847_1930_1925 <https://gitlab.haskell.org/ghc/ghc/merge_requests/444/diffs#350c4076427c611b8f14e875a4ca553041c2b847_1930_1925>
> > Look at the comment “Is this zipping necessary? We haven't zonked the scoped_kvs or the tc_tvs, I think” from Richard Eisenberg, just below line 1925 in TcHsType.
> >
> >  
> >
> > Now click on the grey “…” above his comment, to expand more code lines above.
> >
> >  
> >
> > Uh oh!  
> >
> > The same comment now occurs twice, just below line 1904, and again just below 1925.
> > The first time it’s on the wrong line of code
> > But in the second position (the correct one) the “Reply” box is inactive.  I can’t type into it.
> >  
> >
> > Is this is a bug? How to report it?
> >
> >  
> >
> > Simon
> >
> > _______________________________________________
> > ghc-devs mailing list
> > [hidden email] <mailto:[hidden email]>
> > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs <http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs>

> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


--
Tobias Dammers - [hidden email]
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs