HEADS UP: New primops in HEAD

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

HEADS UP: New primops in HEAD

Jan Stolarek
New comparison primops are now in HEAD. This change breaks backwards compatibility for comparison primops. What you need to do after pulling the latest HEAD is:

1) Upgrade to latest versions of Alex and Happy (cabal update && cabal install alex happy).

2) Rebase your branches on top of HEAD, if these branches were in a repository affected by primop change. Repositories that will were affected: GHC, testsuite, array, base, dph, ghc-prim, integer-gmp, integer-simple, primitive, template-haskell.

3) Blow away your build. Be sure to run ./configure to pick up new versions of Alex and Happy

Janek


Reply | Threaded
Open this post in threaded view
|

HEADS UP: New primops in HEAD

Gabor Greif-2
On 9/18/13, Jan Stolarek <jan.stolarek at p.lodz.pl> wrote:
> New comparison primops are now in HEAD. This change breaks backwards
> compatibility for comparison primops. What you need to do after pulling the
> latest HEAD is:
>
> 1) Upgrade to latest versions of Alex and Happy (cabal update && cabal
> install alex happy).

With your recipe I was able to build GHC. But I got this:

make -r --no-print-directory -f ghc.mk phase=final all
"/Users/ggreif/ghc-head/inplace/bin/haddock"
--odir="libraries/ghc-prim/dist-install/doc/html/ghc-prim"
--no-tmp-comp-dir
--dump-interface=libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock
--html --hoogle --title="ghc-prim-0.3.1.0: GHC primitives"
--prologue="libraries/ghc-prim/dist-install/haddock-prologue.txt"
--optghc=-hisuf --optghc=dyn_hi --optghc=-osuf --optghc=dyn_o
--optghc=-hcsuf --optghc=dyn_hc --optghc=-fPIC --optghc=-dynamic
--optghc=-H32m --optghc=-O --optghc=-package-name
--optghc=ghc-prim-0.3.1.0 --optghc=-hide-all-packages --optghc=-i
--optghc=-ilibraries/ghc-prim/.
--optghc=-ilibraries/ghc-prim/dist-install/build
--optghc=-ilibraries/ghc-prim/dist-install/build/autogen
--optghc=-Ilibraries/ghc-prim/dist-install/build
--optghc=-Ilibraries/ghc-prim/dist-install/build/autogen
--optghc=-Ilibraries/ghc-prim/. --optghc=-optP-include
--optghc=-optPlibraries/ghc-prim/dist-install/build/autogen/cabal_macros.h
--optghc=-package --optghc=rts-1.0 --optghc=-package-name
--optghc=ghc-prim --optghc=-XHaskell98 --optghc=-XCPP
--optghc=-XMagicHash --optghc=-XForeignFunctionInterface
--optghc=-XUnliftedFFITypes --optghc=-XUnboxedTuples
--optghc=-XEmptyDataDecls --optghc=-XNoImplicitPrelude --optghc=-O2
--optghc=-no-user-package-db --optghc=-rtsopts --optghc=-odir
--optghc=libraries/ghc-prim/dist-install/build --optghc=-hidir
--optghc=libraries/ghc-prim/dist-install/build --optghc=-stubdir
--optghc=libraries/ghc-prim/dist-install/build
libraries/ghc-prim/./GHC/Classes.hs
libraries/ghc-prim/./GHC/CString.hs  libraries/ghc-prim/./GHC/Debug.hs
 libraries/ghc-prim/./GHC/Magic.hs
libraries/ghc-prim/dist-install/build/GHC/PrimopWrappers.hs
libraries/ghc-prim/./GHC/IntWord64.hs
libraries/ghc-prim/./GHC/Tuple.hs  libraries/ghc-prim/./GHC/Types.hs
libraries/ghc-prim/dist-install/build/autogen/GHC/Prim.hs +RTS
-tlibraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock.t
--machine-readable
Haddock coverage:
Warning: Couldn't find .haddock for export GHC.Prim.Int64#
Warning: Couldn't find .haddock for export GHC.Prim.Word64#
   3% (  1 / 38) in 'GHC.IntWord64'
  80% (  8 / 10) in 'GHC.Types'
  17% (  1 /  6) in 'GHC.CString'
   3% (  2 / 63) in 'GHC.Tuple'
   0% (  0 /  3) in 'GHC.Debug'
   0% (  0 /354) in 'GHC.PrimopWrappers'
  33% (181 /553) in 'GHC.Prim'
 100% (  3 /  3) in 'GHC.Magic'
  38% (  6 / 16) in 'GHC.Classes'
attempting to use module 'ghc-prim:GHC.Types'
(libraries/ghc-prim/./GHC/Types.hs) which is not loaded
make[1]: *** [libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock]
Error 1
make[1]: Target `all' not remade because of errors.
make: *** [all] Error 2
make: Target `default' not remade because of errors.

Any idea what this could be?

Anyway, using `make --keep-going` I was able to install (almost)
everything, and it looks good.

Cheers,

    Gabor

>
> 2) Rebase your branches on top of HEAD, if these branches were in a
> repository affected by primop change. Repositories that will were affected:
> GHC, testsuite, array, base, dph, ghc-prim, integer-gmp, integer-simple,
> primitive, template-haskell.
>
> 3) Blow away your build. Be sure to run ./configure to pick up new versions
> of Alex and Happy
>
> Janek
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-devs
>


Reply | Threaded
Open this post in threaded view
|

HEADS UP: New primops in HEAD

Jan Stolarek
> Any idea what this could be?

Yes, it looks like http://ghc.haskell.org/trac/ghc/ticket/8320
This ticket was reported about 20 hours *before* I pushed my patches. I also think that I've seen someone reporting this problem earlier, but I can't find anything on the list or lpaste, so perhaps I'm wrong here (or maybe I've seen it myself?). Anyway, were my patches the only ones that you pulled? Or did you pull some others as well? I've seen that there were some commits pushed to haddock repo just before you sent your mail - have you done your build with or without them?

Janek

----- Oryginalna wiadomo?? -----
Od: "Gabor Greif" <ggreif at gmail.com>
Do: "Jan Stolarek" <jan.stolarek at p.lodz.pl>
DW: "ghc-devs" <ghc-devs at haskell.org>
Wys?ane: ?roda, 18 wrzesie? 2013 22:39:43
Temat: Re: HEADS UP: New primops in HEAD

On 9/18/13, Jan Stolarek <jan.stolarek at p.lodz.pl> wrote:
> New comparison primops are now in HEAD. This change breaks backwards
> compatibility for comparison primops. What you need to do after pulling the
> latest HEAD is:
>
> 1) Upgrade to latest versions of Alex and Happy (cabal update && cabal
> install alex happy).

With your recipe I was able to build GHC. But I got this:

make -r --no-print-directory -f ghc.mk phase=final all
"/Users/ggreif/ghc-head/inplace/bin/haddock"
--odir="libraries/ghc-prim/dist-install/doc/html/ghc-prim"
--no-tmp-comp-dir
--dump-interface=libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock
--html --hoogle --title="ghc-prim-0.3.1.0: GHC primitives"
--prologue="libraries/ghc-prim/dist-install/haddock-prologue.txt"
--optghc=-hisuf --optghc=dyn_hi --optghc=-osuf --optghc=dyn_o
--optghc=-hcsuf --optghc=dyn_hc --optghc=-fPIC --optghc=-dynamic
--optghc=-H32m --optghc=-O --optghc=-package-name
--optghc=ghc-prim-0.3.1.0 --optghc=-hide-all-packages --optghc=-i
--optghc=-ilibraries/ghc-prim/.
--optghc=-ilibraries/ghc-prim/dist-install/build
--optghc=-ilibraries/ghc-prim/dist-install/build/autogen
--optghc=-Ilibraries/ghc-prim/dist-install/build
--optghc=-Ilibraries/ghc-prim/dist-install/build/autogen
--optghc=-Ilibraries/ghc-prim/. --optghc=-optP-include
--optghc=-optPlibraries/ghc-prim/dist-install/build/autogen/cabal_macros.h
--optghc=-package --optghc=rts-1.0 --optghc=-package-name
--optghc=ghc-prim --optghc=-XHaskell98 --optghc=-XCPP
--optghc=-XMagicHash --optghc=-XForeignFunctionInterface
--optghc=-XUnliftedFFITypes --optghc=-XUnboxedTuples
--optghc=-XEmptyDataDecls --optghc=-XNoImplicitPrelude --optghc=-O2
--optghc=-no-user-package-db --optghc=-rtsopts --optghc=-odir
--optghc=libraries/ghc-prim/dist-install/build --optghc=-hidir
--optghc=libraries/ghc-prim/dist-install/build --optghc=-stubdir
--optghc=libraries/ghc-prim/dist-install/build
libraries/ghc-prim/./GHC/Classes.hs
libraries/ghc-prim/./GHC/CString.hs  libraries/ghc-prim/./GHC/Debug.hs
 libraries/ghc-prim/./GHC/Magic.hs
libraries/ghc-prim/dist-install/build/GHC/PrimopWrappers.hs
libraries/ghc-prim/./GHC/IntWord64.hs
libraries/ghc-prim/./GHC/Tuple.hs  libraries/ghc-prim/./GHC/Types.hs
libraries/ghc-prim/dist-install/build/autogen/GHC/Prim.hs +RTS
-tlibraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock.t
--machine-readable
Haddock coverage:
Warning: Couldn't find .haddock for export GHC.Prim.Int64#
Warning: Couldn't find .haddock for export GHC.Prim.Word64#
   3% (  1 / 38) in 'GHC.IntWord64'
  80% (  8 / 10) in 'GHC.Types'
  17% (  1 /  6) in 'GHC.CString'
   3% (  2 / 63) in 'GHC.Tuple'
   0% (  0 /  3) in 'GHC.Debug'
   0% (  0 /354) in 'GHC.PrimopWrappers'
  33% (181 /553) in 'GHC.Prim'
 100% (  3 /  3) in 'GHC.Magic'
  38% (  6 / 16) in 'GHC.Classes'
attempting to use module 'ghc-prim:GHC.Types'
(libraries/ghc-prim/./GHC/Types.hs) which is not loaded
make[1]: *** [libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock]
Error 1
make[1]: Target `all' not remade because of errors.
make: *** [all] Error 2
make: Target `default' not remade because of errors.

Any idea what this could be?

Anyway, using `make --keep-going` I was able to install (almost)
everything, and it looks good.

Cheers,

    Gabor

>
> 2) Rebase your branches on top of HEAD, if these branches were in a
> repository affected by primop change. Repositories that will were affected:
> GHC, testsuite, array, base, dph, ghc-prim, integer-gmp, integer-simple,
> primitive, template-haskell.
>
> 3) Blow away your build. Be sure to run ./configure to pick up new versions
> of Alex and Happy
>
> Janek
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-devs
>



Reply | Threaded
Open this post in threaded view
|

HEADS UP: New primops in HEAD

Gabor Greif-2
On 9/19/13, Jan Stolarek <jan.stolarek at p.lodz.pl> wrote:
>> Any idea what this could be?
>
> Yes, it looks like http://ghc.haskell.org/trac/ghc/ticket/8320

Yeah, this seems to be it.

> This ticket was reported about 20 hours *before* I pushed my patches. I also

Then it must be an unrelated problem, good :-)

> think that I've seen someone reporting this problem earlier, but I can't
> find anything on the list or lpaste, so perhaps I'm wrong here (or maybe
> I've seen it myself?). Anyway, were my patches the only ones that you
> pulled? Or did you pull some others as well? I've seen that there were some

I pulled everything *up to* your patches. I had an (essentially) clean
workspace.

> commits pushed to haddock repo just before you sent your mail - have you
> done your build with or without them?

Originally I did not have those, later pulled them too, but it did not
change the situation.

I'll watch the PR you have given.

Cheers,

    Gabor

>
> Janek
>
> ----- Oryginalna wiadomo?? -----
> Od: "Gabor Greif" <ggreif at gmail.com>
> Do: "Jan Stolarek" <jan.stolarek at p.lodz.pl>
> DW: "ghc-devs" <ghc-devs at haskell.org>
> Wys?ane: ?roda, 18 wrzesie? 2013 22:39:43
> Temat: Re: HEADS UP: New primops in HEAD
>
> On 9/18/13, Jan Stolarek <jan.stolarek at p.lodz.pl> wrote:
>> New comparison primops are now in HEAD. This change breaks backwards
>> compatibility for comparison primops. What you need to do after pulling
>> the
>> latest HEAD is:
>>
>> 1) Upgrade to latest versions of Alex and Happy (cabal update && cabal
>> install alex happy).
>
> With your recipe I was able to build GHC. But I got this:
>
> make -r --no-print-directory -f ghc.mk phase=final all
> "/Users/ggreif/ghc-head/inplace/bin/haddock"
> --odir="libraries/ghc-prim/dist-install/doc/html/ghc-prim"
> --no-tmp-comp-dir
> --dump-interface=libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock
> --html --hoogle --title="ghc-prim-0.3.1.0: GHC primitives"
> --prologue="libraries/ghc-prim/dist-install/haddock-prologue.txt"
> --optghc=-hisuf --optghc=dyn_hi --optghc=-osuf --optghc=dyn_o
> --optghc=-hcsuf --optghc=dyn_hc --optghc=-fPIC --optghc=-dynamic
> --optghc=-H32m --optghc=-O --optghc=-package-name
> --optghc=ghc-prim-0.3.1.0 --optghc=-hide-all-packages --optghc=-i
> --optghc=-ilibraries/ghc-prim/.
> --optghc=-ilibraries/ghc-prim/dist-install/build
> --optghc=-ilibraries/ghc-prim/dist-install/build/autogen
> --optghc=-Ilibraries/ghc-prim/dist-install/build
> --optghc=-Ilibraries/ghc-prim/dist-install/build/autogen
> --optghc=-Ilibraries/ghc-prim/. --optghc=-optP-include
> --optghc=-optPlibraries/ghc-prim/dist-install/build/autogen/cabal_macros.h
> --optghc=-package --optghc=rts-1.0 --optghc=-package-name
> --optghc=ghc-prim --optghc=-XHaskell98 --optghc=-XCPP
> --optghc=-XMagicHash --optghc=-XForeignFunctionInterface
> --optghc=-XUnliftedFFITypes --optghc=-XUnboxedTuples
> --optghc=-XEmptyDataDecls --optghc=-XNoImplicitPrelude --optghc=-O2
> --optghc=-no-user-package-db --optghc=-rtsopts --optghc=-odir
> --optghc=libraries/ghc-prim/dist-install/build --optghc=-hidir
> --optghc=libraries/ghc-prim/dist-install/build --optghc=-stubdir
> --optghc=libraries/ghc-prim/dist-install/build
> libraries/ghc-prim/./GHC/Classes.hs
> libraries/ghc-prim/./GHC/CString.hs  libraries/ghc-prim/./GHC/Debug.hs
>  libraries/ghc-prim/./GHC/Magic.hs
> libraries/ghc-prim/dist-install/build/GHC/PrimopWrappers.hs
> libraries/ghc-prim/./GHC/IntWord64.hs
> libraries/ghc-prim/./GHC/Tuple.hs  libraries/ghc-prim/./GHC/Types.hs
> libraries/ghc-prim/dist-install/build/autogen/GHC/Prim.hs +RTS
> -tlibraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock.t
> --machine-readable
> Haddock coverage:
> Warning: Couldn't find .haddock for export GHC.Prim.Int64#
> Warning: Couldn't find .haddock for export GHC.Prim.Word64#
>    3% (  1 / 38) in 'GHC.IntWord64'
>   80% (  8 / 10) in 'GHC.Types'
>   17% (  1 /  6) in 'GHC.CString'
>    3% (  2 / 63) in 'GHC.Tuple'
>    0% (  0 /  3) in 'GHC.Debug'
>    0% (  0 /354) in 'GHC.PrimopWrappers'
>   33% (181 /553) in 'GHC.Prim'
>  100% (  3 /  3) in 'GHC.Magic'
>   38% (  6 / 16) in 'GHC.Classes'
> attempting to use module 'ghc-prim:GHC.Types'
> (libraries/ghc-prim/./GHC/Types.hs) which is not loaded
> make[1]: ***
> [libraries/ghc-prim/dist-install/doc/html/ghc-prim/ghc-prim.haddock]
> Error 1
> make[1]: Target `all' not remade because of errors.
> make: *** [all] Error 2
> make: Target `default' not remade because of errors.
>
> Any idea what this could be?
>
> Anyway, using `make --keep-going` I was able to install (almost)
> everything, and it looks good.
>
> Cheers,
>
>     Gabor
>
>>
>> 2) Rebase your branches on top of HEAD, if these branches were in a
>> repository affected by primop change. Repositories that will were
>> affected:
>> GHC, testsuite, array, base, dph, ghc-prim, integer-gmp, integer-simple,
>> primitive, template-haskell.
>>
>> 3) Blow away your build. Be sure to run ./configure to pick up new
>> versions
>> of Alex and Happy
>>
>> Janek
>> _______________________________________________
>> ghc-devs mailing list
>> ghc-devs at haskell.org
>> http://www.haskell.org/mailman/listinfo/ghc-devs
>>
>
>