I've moved the primitive package to github

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Bryan O'Sullivan
Roman seems to have gone silent, and primitive being broken with GHC HEAD
means that there's a ton of packages we can't build right now.

Accordingly, I've imported the old darcs repo into git and published it on
github.

https://github.com/haskell/primitive

Austin, please plan to fix the GHC build to get its copy of primitive from
here, once we have it working with HEAD.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20130924/6e1e4832/attachment.htm>

Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Jan Stolarek
Hi all,

My patches for primitive are here:

https://github.com/jstolarek/primitive/commit/efdf302bf7c2e60996f75f181dd6dafeb1d6adb8

but this is my own mirror of primitive, not a fork of repo Bryan just created. Austin, will you be
able to apply changes from my branch to upstream primitive?

Janek

Dnia wtorek, 24 wrze?nia 2013, Bryan O'Sullivan napisa?:

> Roman seems to have gone silent, and primitive being broken with GHC HEAD
> means that there's a ton of packages we can't build right now.
>
> Accordingly, I've imported the old darcs repo into git and published it on
> github.
>
> https://github.com/haskell/primitive
>
> Austin, please plan to fix the GHC build to get its copy of primitive from
> here, once we have it working with HEAD.




Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

shelarcy
In reply to this post by Bryan O'Sullivan
Hi,

vector is also broken with HEAD.


$ cabal install --with-ghc=C:\ghc\ghc-7.7.20130806\bin\ghc.exe vector
Resolving dependencies...
[10 of 19] Compiling Data.Vector.Generic ( Data\Vector\Generic.hs, dist\build\Da
ta\Vector\Generic.o )

Data\Vector\Generic.hs:197:24:
     Module `Data.Typeable' does not export `Typeable1'
Failed to install vector-0.10.0.1
cabal: Error: some packages failed to install:
vector-0.10.0.1 failed during the building phase. The exception was:
ExitFailure 1


Pedro already sent patch to fix this problem, and I filed this to vector's trac.

   http://www.haskell.org/pipermail/ghc-devs/2013-February/000420.html

But ... this patch doesn't accept yet, and trac is down now.


How about move vector's repository the same as primitive one?


Best Regards,


On Tue, 24 Sep 2013 22:30:03 +0900, Bryan O'Sullivan <bos at serpentine.com> wrote:

> Roman seems to have gone silent, and primitive being broken with GHC HEAD
> means that there's a ton of packages we can't build right now.
>
> Accordingly, I've imported the old darcs repo into git and published it on
> github.
>
> https://github.com/haskell/primitive
>
> Austin, please plan to fix the GHC build to get its copy of primitive from
> here, once we have it working with HEAD.


--
shelarcy <shelarcy    hotmail.co.jp>
http://page.freett.com/shelarcy/


Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Bryan O'Sullivan
In reply to this post by Jan Stolarek
On Tue, Sep 24, 2013 at 6:53 AM, Jan Stolarek <jan.stolarek at p.lodz.pl>wrote:

> Austin, will you be
> able to apply changes from my branch to upstream primitive?
>

Your patches are based on an outdated version of the library. I just wrote
a new patch and applied it. It builds fine on several versions of GHC, so I
tagged primitive 0.5.1.0 and released it to Hackage just now.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20130924/01ca8e41/attachment.htm>

Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Jan Stolarek
> Your patches are based on an outdated version of the library.
That's really surprising - I based them on code available at http://code.haskell.org/primitive,
which I believe was version 0.5.0.1. Was there anything newer?

Janek


Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Bryan O'Sullivan
On Tue, Sep 24, 2013 at 11:47 AM, Jan Stolarek <jan.stolarek at p.lodz.pl>wrote:

> That's really surprising - I based them on code available at
> http://code.haskell.org/primitive,
> which I believe was version 0.5.0.1. Was there anything newer?
>

Oh, I was going on the versions that are in a repo on git.haskell.org.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20130924/beba20d7/attachment.htm>

Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Herbert Valerio Riedel
In reply to this post by Jan Stolarek
Hello Jan,

On 2013-09-24 at 20:47:31 +0200, Jan Stolarek wrote:
>> Your patches are based on an outdated version of the library.

> That's really surprising - I based them on code available at http://code.haskell.org/primitive,
> which I believe was version 0.5.0.1. Was there anything newer?

0.5.0.1 also matches exactly what our darcs2git mirror repo at

  http://git.haskell.org/darcs-mirrors/primitive.git

currently holds; and the GitHub repo has all commits from there (albeit
with slightly diverged commit-ids after 0.4.0.1, but that's harmless)


However, I've tried integrating the new vector/primitive versions
released into the GHC build (after patching up the DPH libs), but I get
Core lint errors:

  http://lpaste.net/93354

any idea what's going on here?

Cheers,
  hvr


Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Geoffrey Mainland
On 9/24/13 6:17 PM, Herbert Valerio Riedel wrote:

> Hello Jan,
>
> On 2013-09-24 at 20:47:31 +0200, Jan Stolarek wrote:
>>> Your patches are based on an outdated version of the library.
>> That's really surprising - I based them on code available at http://code.haskell.org/primitive,
>> which I believe was version 0.5.0.1. Was there anything newer?
> 0.5.0.1 also matches exactly what our darcs2git mirror repo at
>
>   http://git.haskell.org/darcs-mirrors/primitive.git
>
> currently holds; and the GitHub repo has all commits from there (albeit
> with slightly diverged commit-ids after 0.4.0.1, but that's harmless)
>
>
> However, I've tried integrating the new vector/primitive versions
> released into the GHC build (after patching up the DPH libs), but I get
> Core lint errors:
>
>   http://lpaste.net/93354
>
> any idea what's going on here?
>
> Cheers,
>   hvr
Hm, #8138? Richard marked that as closed, though.

You didn't try to update the version of vector in the GHC build, did you?

Geoff



Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Bryan O'Sullivan
In reply to this post by Herbert Valerio Riedel
On Tue, Sep 24, 2013 at 6:17 PM, Herbert Valerio Riedel <hvr at gnu.org> wrote:

> However, I've tried integrating the new vector/primitive versions
> released into the GHC build (after patching up the DPH libs), but I get
> Core lint errors:
>

No clue. For me, the new releases of primitive and vector build happily
with a version of HEAD that's a day old.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20130924/2b8f5e65/attachment.htm>

Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Jan Stolarek
In reply to this post by Herbert Valerio Riedel
> However, I've tried integrating the new vector/primitive versions
> released into the GHC build (after patching up the DPH libs), but I get
> Core lint errors:
>
>   http://lpaste.net/93354
>
> any idea what's going on here?
I have no idea what might be the cause. During my work on new primops I haven't seen anything like
this.

Janek


Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Herbert Valerio Riedel
In reply to this post by Bryan O'Sullivan
On 2013-09-25 at 05:50:23 +0200, Bryan O'Sullivan wrote:
> On Tue, Sep 24, 2013 at 6:17 PM, Herbert Valerio Riedel <hvr at gnu.org> wrote:
>
>> However, I've tried integrating the new vector/primitive versions
>> released into the GHC build (after patching up the DPH libs), but I get
>> Core lint errors:
>>
>
> No clue. For me, the new releases of primitive and vector build happily
> with a version of HEAD that's a day old.

I assume you built primitive/vector normally w/o -dcore-lint, in which
case those errors would not be checked for


Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Herbert Valerio Riedel
In reply to this post by Geoffrey Mainland
On 2013-09-25 at 02:40:51 +0200, Geoffrey Mainland wrote:

[...]

>> However, I've tried integrating the new vector/primitive versions
>> released into the GHC build (after patching up the DPH libs), but I get
>> Core lint errors:
>>
>>   http://lpaste.net/93354
>>
>> any idea what's going on here?

> Hm, #8138? Richard marked that as closed, though.
>
> You didn't try to update the version of vector in the GHC build, did you?

Well, of course I did :-)

but afaics the error occurs already when trying to compile the new
'primitive' by itself...

But you can easily reproduce w/o replacing the 'primitive' used for
building GHC HEAD, but simply by trying to build the relased
primitive-0.5.1.0 package with GHC HEAD via cabal:

  cabal update
  cabal install --ghc-option=-dcore-lint primitive-0.5.1.0


Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Herbert Valerio Riedel
In reply to this post by Jan Stolarek
Hello Jan,

On 2013-09-25 at 08:26:15 +0200, Jan Stolarek wrote:
>> However, I've tried integrating the new vector/primitive versions
>> released into the GHC build (after patching up the DPH libs), but I get
>> Core lint errors:
>>
>>   http://lpaste.net/93354
>>
>> any idea what's going on here?

> I have no idea what might be the cause. During my work on new primops
> I haven't seen anything like this.

Fyi, I tried your primitive-0.5.0.2 version[1] as well, and build that
package with

  cabal configure --ghc-option=-dcore-lint && cabal build

which gave me a core-lint error as well; if you have the time, could you
please try to reproduce this on your setup?

Cheers,
  hvr

 [1]: https://github.com/jstolarek/primitive/tree/ghc-78-compatibility


Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Herbert Valerio Riedel

Fyi, I've been able to reproduce this failure on GHC 7.6.3 as well, and
filed a ticket at

  http://ghc.haskell.org/trac/ghc/ticket/8355

On 2013-09-25 at 09:24:22 +0200, Herbert Valerio Riedel wrote:

> Hello Jan,
>
> On 2013-09-25 at 08:26:15 +0200, Jan Stolarek wrote:
>>> However, I've tried integrating the new vector/primitive versions
>>> released into the GHC build (after patching up the DPH libs), but I get
>>> Core lint errors:
>>>
>>>   http://lpaste.net/93354
>>>
>>> any idea what's going on here?
>
>> I have no idea what might be the cause. During my work on new primops
>> I haven't seen anything like this.
>
> Fyi, I tried your primitive-0.5.0.2 version[1] as well, and build that
> package with
>
>   cabal configure --ghc-option=-dcore-lint && cabal build
>
> which gave me a core-lint error as well; if you have the time, could you
> please try to reproduce this on your setup?
>
> Cheers,
>   hvr
>
>  [1]: https://github.com/jstolarek/primitive/tree/ghc-78-compatibility

--
"Elegance is not optional" -- Richard O'Keefe


Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Roman Leshchinskiy
In reply to this post by Bryan O'Sullivan
Can't post to ghc-devs from the other address so here it is again...

I'm awfully sorry to have gone silent but I just can't find the time for
hacking any longer. If someone wants to take over primitive and vector
please feel free to do so, I'd be very grateful.

Roman

On 24/09/13 14:30, Bryan O'Sullivan wrote:

> Roman seems to have gone silent, and primitive being broken with GHC
> HEAD means that there's a ton of packages we can't build right now.
>
> Accordingly, I've imported the old darcs repo into git and published it
> on github.
>
> https://github.com/haskell/primitive
>
> Austin, please plan to fix the GHC build to get its copy of primitive
> from here, once we have it working with HEAD.




Reply | Threaded
Open this post in threaded view
|

I've moved the primitive package to github

Geoffrey Mainland
In reply to this post by Herbert Valerio Riedel
On 09/25/2013 02:51 AM, Herbert Valerio Riedel wrote:

> On 2013-09-25 at 02:40:51 +0200, Geoffrey Mainland wrote:
>
> [...]
>
>>> However, I've tried integrating the new vector/primitive versions
>>> released into the GHC build (after patching up the DPH libs), but I get
>>> Core lint errors:
>>>
>>>   http://lpaste.net/93354
>>>
>>> any idea what's going on here?
>
>> Hm, #8138? Richard marked that as closed, though.
>>
>> You didn't try to update the version of vector in the GHC build, did you?
>
> Well, of course I did :-)
>
> but afaics the error occurs already when trying to compile the new
> 'primitive' by itself...
>
> But you can easily reproduce w/o replacing the 'primitive' used for
> building GHC HEAD, but simply by trying to build the relased
> primitive-0.5.1.0 package with GHC HEAD via cabal:
>
>   cabal update
>   cabal install --ghc-option=-dcore-lint primitive-0.5.1.0

Looks like #7643. Here's my work-around:

https://github.com/mainland/primitive/commit/21fd4d055a26552919d06fbf7433f72289969043

Note that DPH is tied to the old version of vector, so updating vector
will not work. I have patches to DPH to get it to compile with the new
version of vector, but the DPH folks have plans to re-do the way
vectorization is done, so it's probably not worth trying to get my
patches included.

Geoff