Marge bot review link

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Marge bot review link

lonetiger

Hi Ben,

 

I’m wondering if it’s possible to get marge to amend the commit message before it merges it to include links to the review requests.

 

I really miss that phab feature..

 

Thanks,

Tamar


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Marge bot review link

Ben Gamari-3
It likely is possible. However, I have been a bit reluctant to touch Marge since it is supposed to be a temporary measure and changes have historically resulted in regressions. I do hope that merge train support will finally be usable in the next release of GitLab.

Cheers,

- Ben

On January 11, 2020 9:07:40 AM EST, [hidden email] wrote:

Hi Ben,

 

I’m wondering if it’s possible to get marge to amend the commit message before it merges it to include links to the review requests.

 

I really miss that phab feature..

 

Thanks,

Tamar


--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Marge bot review link

Sylvain Henry-2

It seems that we just have to add `add-part-of: true` in marge bot config file according to https://github.com/smarkets/marge-bot

Cheers
Sylvain


On 12/01/2020 10:10, Ben Gamari wrote:
It likely is possible. However, I have been a bit reluctant to touch Marge since it is supposed to be a temporary measure and changes have historically resulted in regressions. I do hope that merge train support will finally be usable in the next release of GitLab.

Cheers,

- Ben

On January 11, 2020 9:07:40 AM EST, [hidden email] wrote:

Hi Ben,

 

I’m wondering if it’s possible to get marge to amend the commit message before it merges it to include links to the review requests.

 

I really miss that phab feature..

 

Thanks,

Tamar


--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Marge bot review link

Matthew Pickering
I would't assume that will work without reading the source code for two reasons.

1. The batch mode does not implement all the flags of the single shot mode.
2. I modified the code quite a bit for our instance to get it to work reliably.

Matt

On Wed, Jan 22, 2020 at 9:00 AM Sylvain Henry <[hidden email]> wrote:

>
> It seems that we just have to add `add-part-of: true` in marge bot config file according to https://github.com/smarkets/marge-bot
>
> Cheers
> Sylvain
>
>
> On 12/01/2020 10:10, Ben Gamari wrote:
>
> It likely is possible. However, I have been a bit reluctant to touch Marge since it is supposed to be a temporary measure and changes have historically resulted in regressions. I do hope that merge train support will finally be usable in the next release of GitLab.
>
> Cheers,
>
> - Ben
>
> On January 11, 2020 9:07:40 AM EST, [hidden email] wrote:
>>
>> Hi Ben,
>>
>>
>>
>> I’m wondering if it’s possible to get marge to amend the commit message before it merges it to include links to the review requests.
>>
>>
>>
>> I really miss that phab feature..
>>
>>
>>
>> Thanks,
>>
>> Tamar
>
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs