More GitLab questions

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

More GitLab questions

GHC - devs mailing list
  • When looking at a comment on a MR, I see some snippet of code.  How can I see what module that snippet is in?  Apart from scrolling up to find the file header – being careful not to miss it and scroll into the previous file.
  • When looking a comment, there’s a little button to skip to the next unresolved comment.  Good.  But if I respond to the comment (without resolving it), that little button disappears. How can I find the next unresolved comment?

Simon


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: More GitLab questions

GHC - devs mailing list
  • If I respond to a comment (in review mode) but forget to check “resolved”, it says “Discussion stays unresolved” correctly. But how do I now change it to “resolved”??

 

From: ghc-devs <[hidden email]> On Behalf Of Simon Peyton Jones via ghc-devs
Sent: 10 January 2019 17:16
To: ghc-devs <[hidden email]>
Subject: More GitLab questions

 

  • When looking at a comment on a MR, I see some snippet of code.  How can I see what module that snippet is in?  Apart from scrolling up to find the file header – being careful not to miss it and scroll into the previous file.
  • When looking a comment, there’s a little button to skip to the next unresolved comment.  Good.  But if I respond to the comment (without resolving it), that little button disappears. How can I find the next unresolved comment?

Simon


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: More GitLab questions

Ben Gamari-2
In reply to this post by GHC - devs mailing list
Simon Peyton Jones via ghc-devs <[hidden email]> writes:

>   * When looking at a comment on a MR, I see some snippet of code. How
>     can I see what module that snippet is in? Apart from scrolling up to
>     find the file header - being careful not to miss it and scroll into
>     the previous file.
>
Sigh, yes. This is an unfortunate lack in the UI that I have noticed as
well. I drew upstream's attention to it a while back and they indicated [1]
that they will be fixing this in the next 3-4 releases. I have raised a
signal with upstream indicating that this is causing us considerable
pain in hopes that they prioritize it [2].

[1] https://gitlab.com/gitlab-org/gitlab-ce/issues/53356
[2] https://gitlab.com/gitlab-org/gitlab-ce/issues/55039#note_130613037

>   * When looking a comment, there's a little button to skip to the
>     next unresolved comment. Good. But if I respond to the comment
>     (without resolving it), that little button disappears. How can I
>     find the next unresolved comment?

Hmm, that is strange. I can't reproduce this. I see the button remain at
the end of the discussion, even after I leave a comment [1]. Perhaps
this [2] is the issue you are seeing?

[1] https://gitlab.haskell.org/ghc/ghc/merge_requests/97/diffs#note_2368
[2] https://gitlab.com/gitlab-org/gitlab-ce/issues/21689

Cheers,

- Ben


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: More GitLab questions

GHC - devs mailing list
|  >   * When looking a comment, there's a little button to skip to the
|  >     next unresolved comment. Good. But if I respond to the comment
|  >     (without resolving it), that little button disappears. How can I
|  >     find the next unresolved comment?
|  
|  Hmm, that is strange. I can't reproduce this.

Aha!  The bad behaviour only happens when you are in "review mode".

If you add a comment with "Add comment now", then you are given buttons to
* Resolve or un-resolve the discussion
* Move to the next unresolved point

But if you add a comment with "Start a review" (or "add to review"), then those affordances disappear entirely.

That's my problem.

Simon

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs