My first patch

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

My first patch

Krzysztof Langner
Hello,

Since I'm new here I will first introduce myself.
My name is Krzysztof and I have more then 20 years experience with object
oriented languages. Recently I learned about functional programming. And I
really like it.
Because my current project uses OO languages (no FP) I decided to try to
engage with GHC development to learn Haskell.

So here is my first patch. It is related to the ticket:
https://ghc.haskell.org/trac/ghc/ticket/5412

I just changed error message so it should be easier (I hope) to understand
what has happened. No functionality was changed. The patch is attached to
the ticket.

Should I submit it to someone to review?

--
Thanks
Krzysztof Langner
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20131225/6866ab36/attachment.html>

Reply | Threaded
Open this post in threaded view
|

My first patch

Joachim Breitner-2
Hi,

Am Mittwoch, den 25.12.2013, 11:43 +0100 schrieb Krzysztof Langner:

> So here is my first patch. It is related to the ticket:
> https://ghc.haskell.org/trac/ghc/ticket/5412
>
>
> I just changed error message so it should be easier (I hope) to
> understand what has happened. No functionality was changed. The patch
> is attached to the ticket.
>
>
> Should I submit it to someone to review?

attaching the patch to the ticket, and setting its status to ?please
review? is the right thing to do. Note that you should attach a ".diff",
not a ".diff.gz", so that we can review it directly in trac.

Greetings,
Joachim


--
Joachim ?nomeata? Breitner
  mail at joachim-breitner.de ? http://www.joachim-breitner.de/
  Jabber: nomeata at joachim-breitner.de  ? GPG-Key: 0x4743206C
  Debian Developer: nomeata at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20131225/8d054572/attachment.sig>

Reply | Threaded
Open this post in threaded view
|

My first patch

Krzysztof Langner
2013/12/25 Joachim Breitner <mail at joachim-breitner.de>

> Hi,
>
> Am Mittwoch, den 25.12.2013, 11:43 +0100 schrieb Krzysztof Langner:
>
> > So here is my first patch. It is related to the ticket:
> > https://ghc.haskell.org/trac/ghc/ticket/5412
> >
> >
> > I just changed error message so it should be easier (I hope) to
> > understand what has happened. No functionality was changed. The patch
> > is attached to the ticket.
> >
> >
> > Should I submit it to someone to review?
>
> attaching the patch to the ticket, and setting its status to ?please
> review? is the right thing to do. Note that you should attach a ".diff",
> not a ".diff.gz", so that we can review it directly in trac.
>
>
Done. Thank you for the information.

--
Thanks
Krzysztof
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20131225/c05941a2/attachment.html>