[PATCH] Fix typo in User's Guide

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix typo in User's Guide

Pedro Rodrigues
---
 docs/users_guide/glasgow_exts.xml |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/docs/users_guide/glasgow_exts.xml b/docs/users_guide/glasgow_exts.xml
index ce07806..d61ff7a 100644
--- a/docs/users_guide/glasgow_exts.xml
+++ b/docs/users_guide/glasgow_exts.xml
@@ -8673,7 +8673,7 @@ proc (x,y) ->
 which is translated to
 <screen>
 arr (\ (x,y) -> if f x y then Left x else Right y) >>>
-        (arr (\x -> x+1) >>> f) ||| (arr (\y -> y+2) >>> g)
+        (arr (\x -> x+1) >>> g) ||| (arr (\y -> y+2) >>> h)
 </screen>
 Since the translation uses <function>|||</function>,
 the arrow concerned must belong to the <literal>ArrowChoice</literal> class.
--
1.7.4.1


Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix typo in User's Guide

Carter Schonwald
could you file a ticket on trac with the patch?


On Tue, Nov 5, 2013 at 6:27 AM, Pedro Rodrigues <pedro at onimail.net> wrote:

> ---
>  docs/users_guide/glasgow_exts.xml |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/docs/users_guide/glasgow_exts.xml
> b/docs/users_guide/glasgow_exts.xml
> index ce07806..d61ff7a 100644
> --- a/docs/users_guide/glasgow_exts.xml
> +++ b/docs/users_guide/glasgow_exts.xml
> @@ -8673,7 +8673,7 @@ proc (x,y) ->
>  which is translated to
>  <screen>
>  arr (\ (x,y) -> if f x y then Left x else Right y) >>>
> -        (arr (\x -> x+1) >>> f) ||| (arr (\y -> y+2) >>> g)
> +        (arr (\x -> x+1) >>> g) ||| (arr (\y -> y+2) >>> h)
>  </screen>
>  Since the translation uses <function>|||</function>,
>  the arrow concerned must belong to the <literal>ArrowChoice</literal>
> class.
> --
> 1.7.4.1
>
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-devs
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20131105/ecb29ffd/attachment.html>

Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix typo in User's Guide

Pedro Rodrigues
Sure, here it is http://ghc.haskell.org/trac/ghc/ticket/8505

Should every bug fix have an associated ticket? Because from the
instructions on
Trac<http://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/FixingBugs>,
I got the impression that for quick fixes it was not necessary to create a
ticket.

Cheers,
Pedro Rodrigues


On 5 November 2013 18:56, Carter Schonwald <carter.schonwald at gmail.com>wrote:

> could you file a ticket on trac with the patch?
>
>
> On Tue, Nov 5, 2013 at 6:27 AM, Pedro Rodrigues <pedro at onimail.net> wrote:
>
>> ---
>>  docs/users_guide/glasgow_exts.xml |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/docs/users_guide/glasgow_exts.xml
>> b/docs/users_guide/glasgow_exts.xml
>> index ce07806..d61ff7a 100644
>> --- a/docs/users_guide/glasgow_exts.xml
>> +++ b/docs/users_guide/glasgow_exts.xml
>> @@ -8673,7 +8673,7 @@ proc (x,y) ->
>>  which is translated to
>>  <screen>
>>  arr (\ (x,y) -> if f x y then Left x else Right y) >>>
>> -        (arr (\x -> x+1) >>> f) ||| (arr (\y -> y+2) >>> g)
>> +        (arr (\x -> x+1) >>> g) ||| (arr (\y -> y+2) >>> h)
>>  </screen>
>>  Since the translation uses <function>|||</function>,
>>  the arrow concerned must belong to the <literal>ArrowChoice</literal>
>> class.
>> --
>> 1.7.4.1
>>
>> _______________________________________________
>> ghc-devs mailing list
>> ghc-devs at haskell.org
>> http://www.haskell.org/mailman/listinfo/ghc-devs
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20131105/5a5cb10c/attachment.html>

Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix typo in User's Guide

Simon Peyton Jones
Thanks.  the instructions are really out of date.  Now that so many of us work on GHC, it's too easy for an email to get lost. Trac is better.  I'll update the instructions!

S

From: ghc-devs [mailto:ghc-devs-bounces at haskell.org] On Behalf Of Pedro Rodrigues
Sent: 05 November 2013 21:47
To: Carter Schonwald
Cc: ghc-devs at haskell.org
Subject: Re: [PATCH] Fix typo in User's Guide

Sure, here it is http://ghc.haskell.org/trac/ghc/ticket/8505

Should every bug fix have an associated ticket? Because from the instructions on Trac<http://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/FixingBugs>, I got the impression that for quick fixes it was not necessary to create a ticket.

Cheers,
Pedro Rodrigues

On 5 November 2013 18:56, Carter Schonwald <carter.schonwald at gmail.com<mailto:carter.schonwald at gmail.com>> wrote:
could you file a ticket on trac with the patch?

On Tue, Nov 5, 2013 at 6:27 AM, Pedro Rodrigues <pedro at onimail.net<mailto:pedro at onimail.net>> wrote:
---
 docs/users_guide/glasgow_exts.xml |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/docs/users_guide/glasgow_exts.xml b/docs/users_guide/glasgow_exts.xml
index ce07806..d61ff7a 100644
--- a/docs/users_guide/glasgow_exts.xml
+++ b/docs/users_guide/glasgow_exts.xml
@@ -8673,7 +8673,7 @@ proc (x,y) ->
 which is translated to
 <screen>
 arr (\ (x,y) -> if f x y then Left x else Right y) >>>
-        (arr (\x -> x+1) >>> f) ||| (arr (\y -> y+2) >>> g)
+        (arr (\x -> x+1) >>> g) ||| (arr (\y -> y+2) >>> h)
 </screen>
 Since the translation uses <function>|||</function>,
 the arrow concerned must belong to the <literal>ArrowChoice</literal> class.
--
1.7.4.1

_______________________________________________
ghc-devs mailing list
ghc-devs at haskell.org<mailto:ghc-devs at haskell.org>
http://www.haskell.org/mailman/listinfo/ghc-devs


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20131105/5d2c8689/attachment.html>

Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix typo in User's Guide

Arash Rouhani
Hello Simon,

If you look at this wikipage [1], it still says we can contribute using
the `git send-email` to ghc-devs. Now I know you like for people to
create tickets for bug fixes. But what about really tiny documentation
patches? The WorkingConventions [2] page only mentions how to submit
bugfixes and new feature patches.

So should I still use the instructions at [1] or is there some
information missing in the wiki? Or should I really create a ticket for
tiny patches?

[1]:
https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/Git#Contributingpatches
[2]: https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions


Best Regards,
Arash

On 2013-11-05 23:04, Simon Peyton-Jones wrote:

>
> Thanks. the instructions are really out of date.  Now that so many of
> us work on GHC, it's too easy for an email to get lost. Trac is
> better.  I'll update the instructions!
>
> S
>
> *From:*ghc-devs [mailto:ghc-devs-bounces at haskell.org] *On Behalf Of
> *Pedro Rodrigues
> *Sent:* 05 November 2013 21:47
> *To:* Carter Schonwald
> *Cc:* ghc-devs at haskell.org
> *Subject:* Re: [PATCH] Fix typo in User's Guide
>
> Sure, here it is http://ghc.haskell.org/trac/ghc/ticket/8505
>
> Should every bug fix have an associated ticket? Because from the
> instructions on Trac
> <http://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/FixingBugs>,
> I got the impression that for quick fixes it was not necessary to
> create a ticket.
>
> Cheers,
>
> Pedro Rodrigues
>
> On 5 November 2013 18:56, Carter Schonwald <carter.schonwald at gmail.com
> <mailto:carter.schonwald at gmail.com>> wrote:
>
>     could you file a ticket on trac with the patch?
>
>     On Tue, Nov 5, 2013 at 6:27 AM, Pedro Rodrigues <pedro at onimail.net
>     <mailto:pedro at onimail.net>> wrote:
>
>         ---
>          docs/users_guide/glasgow_exts.xml |    2 +-
>          1 files changed, 1 insertions(+), 1 deletions(-)
>
>         diff --git a/docs/users_guide/glasgow_exts.xml
>         b/docs/users_guide/glasgow_exts.xml
>         index ce07806..d61ff7a 100644
>         --- a/docs/users_guide/glasgow_exts.xml
>         +++ b/docs/users_guide/glasgow_exts.xml
>         @@ -8673,7 +8673,7 @@ proc (x,y) ->
>          which is translated to
>          <screen>
>          arr (\ (x,y) -> if f x y then Left x else Right y) >>>
>         -        (arr (\x -> x+1) >>> f) ||| (arr (\y -> y+2) >>> g)
>         +        (arr (\x -> x+1) >>> g) ||| (arr (\y -> y+2) >>> h)
>          </screen>
>          Since the translation uses <function>|||</function>,
>          the arrow concerned must belong to the
>         <literal>ArrowChoice</literal> class.
>         --
>         1.7.4.1
>
>         _______________________________________________
>         ghc-devs mailing list
>         ghc-devs at haskell.org <mailto:ghc-devs at haskell.org>
>         http://www.haskell.org/mailman/listinfo/ghc-devs
>
>
>
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-devs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20131121/d7562665/attachment.html>

Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix typo in User's Guide

Simon Peyton Jones
Personally I think that even tiny patches should turn into tickets, and we should update the wiki to say so.   For non-committers, there is too much danger that the patch simply gets lost if it's not in a ticket with "patch" status.

People with commit rights can simply commit the tiny patch, so the issue doesn't arise.  And if you are in a dialogue with a committer you can send the patches that they are going to commit.  But for otherwise-unconnected patches, make a ticket.

Does everyone agree? If so does anyone feel able to update the wiki pages to say this?

Simon

From: ghc-devs [mailto:ghc-devs-bounces at haskell.org] On Behalf Of Arash Rouhani
Sent: 21 November 2013 10:39
To: ghc-devs at haskell.org
Subject: Re: [PATCH] Fix typo in User's Guide

Hello Simon,

If you look at this wikipage [1], it still says we can contribute using the `git send-email` to ghc-devs. Now I know you like for people to create tickets for bug fixes. But what about really tiny documentation patches? The WorkingConventions [2] page only mentions how to submit bugfixes and new feature patches.

So should I still use the instructions at [1] or is there some information missing in the wiki? Or should I really create a ticket for tiny patches?

[1]: https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/Git#Contributingpatches
[2]: https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions


Best Regards,
Arash
On 2013-11-05 23:04, Simon Peyton-Jones wrote:
Thanks.  the instructions are really out of date.  Now that so many of us work on GHC, it's too easy for an email to get lost. Trac is better.  I'll update the instructions!

S

From: ghc-devs [mailto:ghc-devs-bounces at haskell.org] On Behalf Of Pedro Rodrigues
Sent: 05 November 2013 21:47
To: Carter Schonwald
Cc: ghc-devs at haskell.org<mailto:ghc-devs at haskell.org>
Subject: Re: [PATCH] Fix typo in User's Guide

Sure, here it is http://ghc.haskell.org/trac/ghc/ticket/8505

Should every bug fix have an associated ticket? Because from the instructions on Trac<http://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/FixingBugs>, I got the impression that for quick fixes it was not necessary to create a ticket.

Cheers,
Pedro Rodrigues

On 5 November 2013 18:56, Carter Schonwald <carter.schonwald at gmail.com<mailto:carter.schonwald at gmail.com>> wrote:
could you file a ticket on trac with the patch?

On Tue, Nov 5, 2013 at 6:27 AM, Pedro Rodrigues <pedro at onimail.net<mailto:pedro at onimail.net>> wrote:
---
 docs/users_guide/glasgow_exts.xml |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/docs/users_guide/glasgow_exts.xml b/docs/users_guide/glasgow_exts.xml
index ce07806..d61ff7a 100644
--- a/docs/users_guide/glasgow_exts.xml
+++ b/docs/users_guide/glasgow_exts.xml
@@ -8673,7 +8673,7 @@ proc (x,y) ->
 which is translated to
 <screen>
 arr (\ (x,y) -> if f x y then Left x else Right y) >>>
-        (arr (\x -> x+1) >>> f) ||| (arr (\y -> y+2) >>> g)
+        (arr (\x -> x+1) >>> g) ||| (arr (\y -> y+2) >>> h)
 </screen>
 Since the translation uses <function>|||</function>,
 the arrow concerned must belong to the <literal>ArrowChoice</literal> class.
--
1.7.4.1

_______________________________________________
ghc-devs mailing list
ghc-devs at haskell.org<mailto:ghc-devs at haskell.org>
http://www.haskell.org/mailman/listinfo/ghc-devs






_______________________________________________

ghc-devs mailing list

ghc-devs at haskell.org<mailto:ghc-devs at haskell.org>

http://www.haskell.org/mailman/listinfo/ghc-devs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20131121/975618a5/attachment.html>

Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix typo in User's Guide

Joachim Breitner-2
Hi,

Am Donnerstag, den 21.11.2013, 11:50 +0000 schrieb Simon Peyton-Jones:
> Personally I think that even tiny patches should turn into tickets,
> and we should update the wiki to say so.   For non-committers, there
> is too much danger that the patch simply gets lost if it?s not in a
> ticket with ?patch? status.  
>
> People with commit rights can simply commit the tiny patch, so the
> issue doesn?t arise.  And if you are in a dialogue with a committer
> you can send the patches that they are going to commit.  But for
> otherwise-unconnected patches, make a ticket.

I would phrase it this way (or similar):

?Tiny patches do not require a ticket, so if you can commit it yourself,
or get a committer to do it right away, go ahead. Otherwise, please open
a ticket so that your contribution is not lost.?

(This sounds less like strict rules and more like ?we care about your
contributions, please help us not lose them?.)

Greetings,
Joachim


--
Joachim ?nomeata? Breitner
  mail at joachim-breitner.de ? http://www.joachim-breitner.de/
  Jabber: nomeata at joachim-breitner.de  ? GPG-Key: 0x4743206C
  Debian Developer: nomeata at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20131121/005f0b46/attachment.sig>