Perf for T5837

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Perf for T5837

GHC - devs mailing list

Ben

Why did you revert this?

commit 2756117bd26c2cb70d3f51954a88b7d7bdf3d3f2

Author: Ben Gamari <[hidden email]>

Date:   Thu Mar 1 14:06:04 2018 -0500

 

    Revert "Better stats for T5837"

   

    This reverts commit d675a354e8db67d87d1f257c3d1d2bf2d58c2b3f.

 

-           (wordsize(64), 55813608, 7)])

+           (wordsize(64), 51294232, 7)])

 

It’s consistently 8% better for me, but I guess not for you.

Does anyone else find this?

Simon


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Perf for T5837

Bartosz Nitka
I commented on https://phabricator.haskell.org/rGHCd675a354e8db67d87d1f257c3d1d2bf2d58c2b3f
that Harbormaster started failing after this.
It reproduced locally for me.
You can see here:
https://phabricator.haskell.org/diffusion/GHC/history/master/ that the
revert fixed the build.

2018-03-05 8:50 GMT+00:00 Simon Peyton Jones via ghc-devs
<[hidden email]>:

> Ben
>
> Why did you revert this?
>
> commit 2756117bd26c2cb70d3f51954a88b7d7bdf3d3f2
>
> Author: Ben Gamari <[hidden email]>
>
> Date:   Thu Mar 1 14:06:04 2018 -0500
>
>
>
>     Revert "Better stats for T5837"
>
>
>
>     This reverts commit d675a354e8db67d87d1f257c3d1d2bf2d58c2b3f.
>
>
>
> -           (wordsize(64), 55813608, 7)])
>
> +           (wordsize(64), 51294232, 7)])
>
>
>
> It’s consistently 8% better for me, but I guess not for you.
>
> Does anyone else find this?
>
> Simon
>
>
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
>
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Perf for T5837

Ben Gamari-3
In reply to this post by GHC - devs mailing list
Simon Peyton Jones via ghc-devs <[hidden email]> writes:

> Ben
> Why did you revert this?
>
As Bartosz mentioned, Harbormaster didn't reproduce the change.
I've also not seen it locally. Admittedly, it possible that it does
change on Harbormaster, just by a much different amount than what you
observed.

Cheers,

- Ben

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment