RE: [commit: ghc] master: Refactor in TcMatches (bdd9042)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

RE: [commit: ghc] master: Refactor in TcMatches (bdd9042)

Simon Peyton Jones
Ben, Austin

The group of around six refactoring patches I have just committed are inessential for 8.0, but I think they are solid enough to merge if some other later patch depends on them.

Simon

|  -----Original Message-----
|  From: ghc-commits [mailto:[hidden email]] On Behalf Of
|  [hidden email]
|  Sent: 31 March 2016 08:02
|  To: [hidden email]
|  Subject: [commit: ghc] master: Refactor in TcMatches (bdd9042)
|  
|  Repository : ssh://[hidden email]/ghc
|  
|  On branch  : master
|  Link       :
|  https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fghc.has
|  kell.org%2ftrac%2fghc%2fchangeset%2fbdd90426a7f88d57bedf15411fa00f62aeb
|  22172%2fghc&data=01%7c01%7csimonpj%40064d.mgd.microsoft.com%7c23c66899d
|  70e4e74cd8608d35932b916%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Lw
|  9ByEHKPpKZb%2fsgZQc1dpCjTm8yNAh5%2b1izy9PdgX0%3d
|  
|  >---------------------------------------------------------------
|  
|  commit bdd90426a7f88d57bedf15411fa00f62aeb22172
|  Author: Simon Peyton Jones <[hidden email]>
|  Date:   Wed Mar 30 17:14:11 2016 +0100
|  
|      Refactor in TcMatches
|  
|      * Move the several calls of tauifyMultipleMatches into tcMatches,
|        so that it can be called only once, and the invariants are
|        clearer
|  
|      * I discovered in doing this that HsLamCase had a redundant and
|        tiresome argument, so I removed it. That in turn allowed some
|        modest but nice code simplification
|  
|  
|  >---------------------------------------------------------------
|  
|  bdd90426a7f88d57bedf15411fa00f62aeb22172
|   compiler/deSugar/Coverage.hs    |  2 +-
|   compiler/deSugar/DsExpr.hs      |  7 +++----
|   compiler/deSugar/DsMeta.hs      |  2 +-
|   compiler/hsSyn/Convert.hs       |  3 +--
|   compiler/hsSyn/HsExpr.hs        | 16 +++++++++-------
|   compiler/parser/Parser.y        |  2 +-
|   compiler/rename/RnExpr.hs       |  5 ++---
|   compiler/typecheck/TcExpr.hs    | 17 +++++++++--------
|   compiler/typecheck/TcHsSyn.hs   |  7 +++----
|   compiler/typecheck/TcMatches.hs | 24 ++++++++----------------
|  compiler/typecheck/TcRnTypes.hs |  2 +-
|   11 files changed, 39 insertions(+), 48 deletions(-)
|  
|  Diff suppressed because of size. To see it, use:
|  
|      git diff-tree --root --patch-with-stat --no-color --find-copies-
|  harder --ignore-space-at-eol --cc
|  bdd90426a7f88d57bedf15411fa00f62aeb22172
|  _______________________________________________
|  ghc-commits mailing list
|  [hidden email]
|  https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail.ha
|  skell.org%2fcgi-bin%2fmailman%2flistinfo%2fghc-
|  commits&data=01%7c01%7csimonpj%40064d.mgd.microsoft.com%7c23c66899d70e4
|  e74cd8608d35932b916%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=8kgpTH
|  G1JUjyHegki%2bBXMZ6gdSlUReHDY5pQIdaUqMg%3d
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs