RE: [commit: ghc] wip/T16188: testsuite: Report stdout and stderr in JUnit output (224fec6)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RE: [commit: ghc] wip/T16188: testsuite: Report stdout and stderr in JUnit output (224fec6)

GHC - devs mailing list
Are these commits really for #16188?  For which we have a MR in progress
https://gitlab.haskell.org/ghc/ghc/merge_requests/207

I was just surprised to see wip/T16188 going by.

Simon

|  -----Original Message-----
|  From: ghc-commits <[hidden email]> On Behalf Of
|  [hidden email]
|  Sent: 10 February 2019 21:32
|  To: [hidden email]
|  Subject: [commit: ghc] wip/T16188: testsuite: Report stdout and stderr in
|  JUnit output (224fec6)
|  
|  Repository : ssh://[hidden email]/ghc
|  
|  On branch  : wip/T16188
|  Link       :
|  https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.hask
|  ell.org%2Ftrac%2Fghc%2Fchangeset%2F224fec6983e16ecfc44a80d47e591a2425468e
|  af%2Fghc&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cec8ee4f808cd416cf0d
|  d08d68f9f2e48%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C63685431128635
|  6725&amp;sdata=ZS4Bp%2FMsebLALA27waYiWgtyx%2FyrKSkiCLcFXvSfXBE%3D&amp;res
|  erved=0
|  
|  >---------------------------------------------------------------
|  
|  commit 224fec6983e16ecfc44a80d47e591a2425468eaf
|  Author: Ben Gamari <[hidden email]>
|  Date:   Thu Jan 24 14:20:11 2019 -0500
|  
|      testsuite: Report stdout and stderr in JUnit output
|  
|      This patch makes the JUnit output more useful as now we also report
|  the
|      stdout/stderr in the message which can be used to quickly identify
|  why a
|      test is failing without downloading the log.
|  
|      This also introduces TestResult,
|      previously we were simply passing around tuples, making things the
|      implementation rather difficult to follow and harder to extend.
|  
|  
|  >---------------------------------------------------------------
|  
|  224fec6983e16ecfc44a80d47e591a2425468eaf
|   testsuite/driver/junit.py       | 23 ++++++++--------
|   testsuite/driver/testglobals.py | 15 +++++++++++
|   testsuite/driver/testlib.py     | 58 ++++++++++++++++++++++++++---------
|  ------
|   testsuite/driver/testutil.py    |  7 +++--
|   4 files changed, 69 insertions(+), 34 deletions(-)
|  
|  Diff suppressed because of size. To see it, use:
|  
|      git diff-tree --root --patch-with-stat --no-color --find-copies-
|  harder --ignore-space-at-eol --cc
|  224fec6983e16ecfc44a80d47e591a2425468eaf
|  _______________________________________________
|  ghc-commits mailing list
|  [hidden email]
|  https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.has
|  kell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-
|  commits&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cec8ee4f808cd416cf0dd
|  08d68f9f2e48%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636854311286366
|  720&amp;sdata=RH6Jnvs7cNsnGyLpwONSZ0Cldighb85HZtuWfn4Gc9Q%3D&amp;reserved
|  =0
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: [commit: ghc] wip/T16188: testsuite: Report stdout and stderr in JUnit output (224fec6)

Matthew Pickering
Ryan rebased Richard's patch to try and get it merged but was
disallowed from pushing to Richard's branch. That's why he made
wip/T16188 and the corresponding MR
(https://gitlab.haskell.org/ghc/ghc/merge_requests/342).

Cheers,

Matt

On Mon, Feb 11, 2019 at 11:30 AM Simon Peyton Jones via ghc-devs
<[hidden email]> wrote:

>
> Are these commits really for #16188?  For which we have a MR in progress
> https://gitlab.haskell.org/ghc/ghc/merge_requests/207
>
> I was just surprised to see wip/T16188 going by.
>
> Simon
>
> |  -----Original Message-----
> |  From: ghc-commits <[hidden email]> On Behalf Of
> |  [hidden email]
> |  Sent: 10 February 2019 21:32
> |  To: [hidden email]
> |  Subject: [commit: ghc] wip/T16188: testsuite: Report stdout and stderr in
> |  JUnit output (224fec6)
> |
> |  Repository : ssh://[hidden email]/ghc
> |
> |  On branch  : wip/T16188
> |  Link       :
> |  https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.hask
> |  ell.org%2Ftrac%2Fghc%2Fchangeset%2F224fec6983e16ecfc44a80d47e591a2425468e
> |  af%2Fghc&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cec8ee4f808cd416cf0d
> |  d08d68f9f2e48%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C63685431128635
> |  6725&amp;sdata=ZS4Bp%2FMsebLALA27waYiWgtyx%2FyrKSkiCLcFXvSfXBE%3D&amp;res
> |  erved=0
> |
> |  >---------------------------------------------------------------
> |
> |  commit 224fec6983e16ecfc44a80d47e591a2425468eaf
> |  Author: Ben Gamari <[hidden email]>
> |  Date:   Thu Jan 24 14:20:11 2019 -0500
> |
> |      testsuite: Report stdout and stderr in JUnit output
> |
> |      This patch makes the JUnit output more useful as now we also report
> |  the
> |      stdout/stderr in the message which can be used to quickly identify
> |  why a
> |      test is failing without downloading the log.
> |
> |      This also introduces TestResult,
> |      previously we were simply passing around tuples, making things the
> |      implementation rather difficult to follow and harder to extend.
> |
> |
> |  >---------------------------------------------------------------
> |
> |  224fec6983e16ecfc44a80d47e591a2425468eaf
> |   testsuite/driver/junit.py       | 23 ++++++++--------
> |   testsuite/driver/testglobals.py | 15 +++++++++++
> |   testsuite/driver/testlib.py     | 58 ++++++++++++++++++++++++++---------
> |  ------
> |   testsuite/driver/testutil.py    |  7 +++--
> |   4 files changed, 69 insertions(+), 34 deletions(-)
> |
> |  Diff suppressed because of size. To see it, use:
> |
> |      git diff-tree --root --patch-with-stat --no-color --find-copies-
> |  harder --ignore-space-at-eol --cc
> |  224fec6983e16ecfc44a80d47e591a2425468eaf
> |  _______________________________________________
> |  ghc-commits mailing list
> |  [hidden email]
> |  https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.has
> |  kell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-
> |  commits&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cec8ee4f808cd416cf0dd
> |  08d68f9f2e48%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636854311286366
> |  720&amp;sdata=RH6Jnvs7cNsnGyLpwONSZ0Cldighb85HZtuWfn4Gc9Q%3D&amp;reserved
> |  =0
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs