Re: [commit: ghc] master: Kill redundant import (da58d15)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [commit: ghc] master: Kill redundant import (da58d15)

Herbert Valerio Riedel

originally,

 http://git.haskell.org/ghc.git/commitdiff/7eb5e29b4a7b6fef55512bc7bf3308e712ca3eba

the import looked like this:

 import qualified HsSyn -- hack as we want to reexport the whole module
 import HsSyn hiding ((<.>))

so it wasn't redundant back then at least.

> commit da58d1517ce9c57514f7b2bd7d444c9e3051a717
> Author: Simon Peyton Jones <[hidden email]>
> Date:   Fri Oct 30 09:45:16 2015 +0000
>
>     Kill redundant import
>    
>     I don't really understand this.  GHC.hs had:
>    
>       module GHC( ...,  module HsSyn, ... ) where
>         import HsSyn
>         import qualified HsSyn -- hack as we want to reexport the whole module
>    
>     GHC now reports the 'import qualified' line as redundant; and it certainly
>     is, because 'import HsSyn' brings everything into scope qualified *and*
>     unqualified.   I have no idea why the "hack" was necessary before, but
>     following my refactoring of tcg_used_gres (previous commit), it's reported
>     as redundant, so I've deleted it.
>    
>     I'm making it a separate commit because it seems a bit mysterious and I
>     wanted to draw attention to it.

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs