Request for comments on dry-run Trac -> GitLab migration

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Request for comments on dry-run Trac -> GitLab migration

Ben Gamari-3
TL;DR. Have a look at this [2] test import of GHC's Trac tickets. Tell us
       what issues you find.


Hello everyone,

As you likely know, we are currently in the process of consolidating
GHC's infrastructure on GitLab [1]. The last step of this process is to
migrate our tickets and wiki from Trac.

Towards this end I am happy to announce the availability of a test
GitLab instance [2] for the community's review. This is a clone of
gitlab.haskell.org but with the addition of tickets [3] and GHC wiki [4]
content imported from a Trac dump from earlier this month.

There are a few known issues:

 * There are currently around 50 tickets missing from the import; we are
   working on identifying where they escaped to

 * The revision history of the Wiki is currently squashed due to
   performance issues [6] with GitLab's wiki implementation

We intend to resolve both of these problems by the time of the final
migration. If you find a ticket on the staging instance with problems
that are not in the above list please do add the `import problems` label
to it so we can have a look.

There are a few aesthetic questions that could use community input:

 * Should the "Trac Metadata" boxes be always visible?

 * How do we make the Wiki index [7] more usable? Imposing more
   hierarchy to the page names would likely help but I'm still a bit
   worried that it will be hard to browse.

Please do take a few minutes to peruse the test import and check for
mistakes or potential usability issues. GHC's Trac tickets are one of
the crown-jewels of the project; we want to make sure we get this
migration right as will be living with the result for a long time to
come.

Cheers,

- Ben


[1] https://gitlab.haskell.org/
[2] https://gitlab.staging.haskell.org/ghc/ghc/
[3] https://gitlab.staging.haskell.org/ghc/ghc/issues
[4] https://gitlab.staging.haskell.org/ghc/ghc/wiki
[6] https://gitlab.com/gitlab-org/gitlab-ce/issues/57179
[7] https://ghc.haskell.org/trac/ghc/ticket/16212

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Request for comments on dry-run Trac -> GitLab migration

GHC - devs mailing list
Could we arrange that searching for the ticket number succeeds?
Eg searching for 12088 fails, and 16013.

Simon

|  -----Original Message-----
|  From: ghc-devs <[hidden email]> On Behalf Of Ben Gamari
|  Sent: 04 February 2019 16:07
|  To: GHC developers <[hidden email]>; glasgow-haskell-users-
|  [hidden email]
|  Subject: Request for comments on dry-run Trac -> GitLab migration
|  
|  TL;DR. Have a look at this [2] test import of GHC's Trac tickets. Tell us
|         what issues you find.
|  
|  
|  Hello everyone,
|  
|  As you likely know, we are currently in the process of consolidating
|  GHC's infrastructure on GitLab [1]. The last step of this process is to
|  migrate our tickets and wiki from Trac.
|  
|  Towards this end I am happy to announce the availability of a test GitLab
|  instance [2] for the community's review. This is a clone of
|  gitlab.haskell.org but with the addition of tickets [3] and GHC wiki [4]
|  content imported from a Trac dump from earlier this month.
|  
|  There are a few known issues:
|  
|   * There are currently around 50 tickets missing from the import; we are
|     working on identifying where they escaped to
|  
|   * The revision history of the Wiki is currently squashed due to
|     performance issues [6] with GitLab's wiki implementation
|  
|  We intend to resolve both of these problems by the time of the final
|  migration. If you find a ticket on the staging instance with problems
|  that are not in the above list please do add the `import problems` label
|  to it so we can have a look.
|  
|  There are a few aesthetic questions that could use community input:
|  
|   * Should the "Trac Metadata" boxes be always visible?
|  
|   * How do we make the Wiki index [7] more usable? Imposing more
|     hierarchy to the page names would likely help but I'm still a bit
|     worried that it will be hard to browse.
|  
|  Please do take a few minutes to peruse the test import and check for
|  mistakes or potential usability issues. GHC's Trac tickets are one of the
|  crown-jewels of the project; we want to make sure we get this migration
|  right as will be living with the result for a long time to come.
|  
|  Cheers,
|  
|  - Ben
|  
|  
|  [1]
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
|  haskell.org%2F&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C6ce4426dfbe84
|  7712d6908d68abac7c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63684893
|  2159173148&amp;sdata=NyzSJFXs2d7QiTDkFMiZULc7qUQb2rDCgo%2FC82vbGL8%3D&amp
|  ;reserved=0
|  [2]
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
|  staging.haskell.org%2Fghc%2Fghc%2F&amp;data=02%7C01%7Csimonpj%40microsoft
|  .com%7C6ce4426dfbe847712d6908d68abac7c1%7C72f988bf86f141af91ab2d7cd011db4
|  7%7C1%7C0%7C636848932159173148&amp;sdata=YHWYMFhCqpvBtfeIqRwWq6d9Q5BrhUH0
|  L8onmpTlyxw%3D&amp;reserved=0
|  [3]
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
|  staging.haskell.org%2Fghc%2Fghc%2Fissues&amp;data=02%7C01%7Csimonpj%40mic
|  rosoft.com%7C6ce4426dfbe847712d6908d68abac7c1%7C72f988bf86f141af91ab2d7cd
|  011db47%7C1%7C0%7C636848932159173148&amp;sdata=GL201PBxtGV79y%2BZwzxOEAFg
|  Bc%2BJ5zOWB5jjrkl%2BZM0%3D&amp;reserved=0
|  [4]
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
|  staging.haskell.org%2Fghc%2Fghc%2Fwiki&amp;data=02%7C01%7Csimonpj%40micro
|  soft.com%7C6ce4426dfbe847712d6908d68abac7c1%7C72f988bf86f141af91ab2d7cd01
|  1db47%7C1%7C0%7C636848932159173148&amp;sdata=PTWjeNeT7nHDlJW%2BqvaSJPndlQ
|  Tm91tIpIbvIhrh0Ng%3D&amp;reserved=0
|  [6]
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
|  com%2Fgitlab-org%2Fgitlab-
|  ce%2Fissues%2F57179&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C6ce4426d
|  fbe847712d6908d68abac7c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636
|  848932159173148&amp;sdata=ew87BU5UBIRdpZfiIl5ETAAXnvDKd0VUYwsLtsMGsM8%3D&
|  amp;reserved=0
|  [7]
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.has
|  kell.org%2Ftrac%2Fghc%2Fticket%2F16212&amp;data=02%7C01%7Csimonpj%40micro
|  soft.com%7C6ce4426dfbe847712d6908d68abac7c1%7C72f988bf86f141af91ab2d7cd01
|  1db47%7C1%7C0%7C636848932159173148&amp;sdata=0wS1xPHe%2F5fKlFj%2FJ6dU9TJ5
|  I8ZmWcxI%2By4zTHYSS1w%3D&amp;reserved=0
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Request for comments on dry-run Trac -> GitLab migration

Matthew Pickering
In reply to this post by Ben Gamari-3
Thanks Ben, looks amazing.

I don't think the trac metadata boxes should always be visible. They
are unobtrusive now and tbh, I don't think I will be opening them up
much when looking at tickets.

Simon, I think if you start the query with a # then it "works". For
example, search for #12088 instead of 12088.

https://gitlab.com/gitlab-org/gitlab-ce/issues/13306

Cheers,

Matt

On Mon, Feb 4, 2019 at 4:06 PM Ben Gamari <[hidden email]> wrote:

>
> TL;DR. Have a look at this [2] test import of GHC's Trac tickets. Tell us
>        what issues you find.
>
>
> Hello everyone,
>
> As you likely know, we are currently in the process of consolidating
> GHC's infrastructure on GitLab [1]. The last step of this process is to
> migrate our tickets and wiki from Trac.
>
> Towards this end I am happy to announce the availability of a test
> GitLab instance [2] for the community's review. This is a clone of
> gitlab.haskell.org but with the addition of tickets [3] and GHC wiki [4]
> content imported from a Trac dump from earlier this month.
>
> There are a few known issues:
>
>  * There are currently around 50 tickets missing from the import; we are
>    working on identifying where they escaped to
>
>  * The revision history of the Wiki is currently squashed due to
>    performance issues [6] with GitLab's wiki implementation
>
> We intend to resolve both of these problems by the time of the final
> migration. If you find a ticket on the staging instance with problems
> that are not in the above list please do add the `import problems` label
> to it so we can have a look.
>
> There are a few aesthetic questions that could use community input:
>
>  * Should the "Trac Metadata" boxes be always visible?
>
>  * How do we make the Wiki index [7] more usable? Imposing more
>    hierarchy to the page names would likely help but I'm still a bit
>    worried that it will be hard to browse.
>
> Please do take a few minutes to peruse the test import and check for
> mistakes or potential usability issues. GHC's Trac tickets are one of
> the crown-jewels of the project; we want to make sure we get this
> migration right as will be living with the result for a long time to
> come.
>
> Cheers,
>
> - Ben
>
>
> [1] https://gitlab.haskell.org/
> [2] https://gitlab.staging.haskell.org/ghc/ghc/
> [3] https://gitlab.staging.haskell.org/ghc/ghc/issues
> [4] https://gitlab.staging.haskell.org/ghc/ghc/wiki
> [6] https://gitlab.com/gitlab-org/gitlab-ce/issues/57179
> [7] https://ghc.haskell.org/trac/ghc/ticket/16212
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Request for comments on dry-run Trac -> GitLab migration

Matthew Pickering
There is this other issue though which explains that searching in the
issues view for a ticket number does fail.

https://gitlab.com/gitlab-org/gitlab-ce/issues/30974

https://gitlab.staging.haskell.org/ghc/ghc/issues?scope=all&utf8=%E2%9C%93&state=opened&search=%231234

So if you want to search for a ticket by number you have to use the
global search.

On Mon, Feb 4, 2019 at 5:03 PM Matthew Pickering
<[hidden email]> wrote:

>
> Thanks Ben, looks amazing.
>
> I don't think the trac metadata boxes should always be visible. They
> are unobtrusive now and tbh, I don't think I will be opening them up
> much when looking at tickets.
>
> Simon, I think if you start the query with a # then it "works". For
> example, search for #12088 instead of 12088.
>
> https://gitlab.com/gitlab-org/gitlab-ce/issues/13306
>
> Cheers,
>
> Matt
>
> On Mon, Feb 4, 2019 at 4:06 PM Ben Gamari <[hidden email]> wrote:
> >
> > TL;DR. Have a look at this [2] test import of GHC's Trac tickets. Tell us
> >        what issues you find.
> >
> >
> > Hello everyone,
> >
> > As you likely know, we are currently in the process of consolidating
> > GHC's infrastructure on GitLab [1]. The last step of this process is to
> > migrate our tickets and wiki from Trac.
> >
> > Towards this end I am happy to announce the availability of a test
> > GitLab instance [2] for the community's review. This is a clone of
> > gitlab.haskell.org but with the addition of tickets [3] and GHC wiki [4]
> > content imported from a Trac dump from earlier this month.
> >
> > There are a few known issues:
> >
> >  * There are currently around 50 tickets missing from the import; we are
> >    working on identifying where they escaped to
> >
> >  * The revision history of the Wiki is currently squashed due to
> >    performance issues [6] with GitLab's wiki implementation
> >
> > We intend to resolve both of these problems by the time of the final
> > migration. If you find a ticket on the staging instance with problems
> > that are not in the above list please do add the `import problems` label
> > to it so we can have a look.
> >
> > There are a few aesthetic questions that could use community input:
> >
> >  * Should the "Trac Metadata" boxes be always visible?
> >
> >  * How do we make the Wiki index [7] more usable? Imposing more
> >    hierarchy to the page names would likely help but I'm still a bit
> >    worried that it will be hard to browse.
> >
> > Please do take a few minutes to peruse the test import and check for
> > mistakes or potential usability issues. GHC's Trac tickets are one of
> > the crown-jewels of the project; we want to make sure we get this
> > migration right as will be living with the result for a long time to
> > come.
> >
> > Cheers,
> >
> > - Ben
> >
> >
> > [1] https://gitlab.haskell.org/
> > [2] https://gitlab.staging.haskell.org/ghc/ghc/
> > [3] https://gitlab.staging.haskell.org/ghc/ghc/issues
> > [4] https://gitlab.staging.haskell.org/ghc/ghc/wiki
> > [6] https://gitlab.com/gitlab-org/gitlab-ce/issues/57179
> > [7] https://ghc.haskell.org/trac/ghc/ticket/16212
> > _______________________________________________
> > ghc-devs mailing list
> > [hidden email]
> > http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Request for comments on dry-run Trac -> GitLab migration

Ryan Scott
In reply to this post by Ben Gamari-3
There appears to be some impedance mismatches between GitLab's formatting and Trac's formatting in certain places. For example, see the bottom of this issue [1], which has a long, hyperlinked line with the phrase:

    Icanproducethe`missinginstance`issuewithouthavingtorecompileGHC,whichiswhyIthinkitmightbeindependentofthisbug.

Ryan S.
-----

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: Request for comments on dry-run Trac -> GitLab migration

Ben Gamari-3
In reply to this post by GHC - devs mailing list
Simon Peyton Jones via ghc-devs <[hidden email]> writes:

> Could we arrange that searching for the ticket number succeeds?
> Eg searching for 12088 fails, and 16013.
>
Yes, this is a bug [1]. I will bring it up with David.

Cheers,

- Ben


[1] https://gitlab.com/gitlab-org/gitlab-ce/issues/30974

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Request for comments on dry-run Trac -> GitLab migration

Niklas Hambüchen
In reply to this post by Ben Gamari-3
I find that commits aren't mentioned on the corresponding issues, for example there's no equivalent of

     https://ghc.haskell.org/trac/ghc/ticket/13497#comment:27

on

     https://gitlab.staging.haskell.org/ghc/ghc/issues/13497

I vaguely remember these "commit posts" being discussed before somewhere.
But that's not even what I'm after.

The commit itself mentions the ticket ("This fixes #13497").
Usually when such a commit is pushed to Gitlab, it automatically creates an entry like:

      Niklas Hambüchen @nh2 mentioned in commit abc123456 3 months ago

But this isn't the case here.
Is it because the issues were imported *after* the repo commits already exist?

Can it be fixed?
E.g. can Gitlab be told to re-index the repo accordingly?
Or could it be done by deleting `master` and re-pushing the entire history?
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Request for comments on dry-run Trac -> GitLab migration

Ben Gamari-3
Niklas Hambüchen <[hidden email]> writes:

> I find that commits aren't mentioned on the corresponding issues, for example there's no equivalent of
>
>      https://ghc.haskell.org/trac/ghc/ticket/13497#comment:27
>
> on
>
>      https://gitlab.staging.haskell.org/ghc/ghc/issues/13497
>
> I vaguely remember these "commit posts" being discussed before somewhere.
> But that's not even what I'm after.
>
> The commit itself mentions the ticket ("This fixes #13497").
> Usually when such a commit is pushed to Gitlab, it automatically creates an entry like:
>
>       Niklas Hambüchen @nh2 mentioned in commit abc123456 3 months ago
>
> But this isn't the case here.
> Is it because the issues were imported *after* the repo commits already exist?
>
Yes, this is the cause and the import does handle this; I just (yet
again) forgot to rerun this stage of the import. This should be fixed now.

Cheers,

- Ben

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Request for comments on dry-run Trac -> GitLab migration

Niklas Hambüchen
On 05/02/2019 4:49 AM, Ben Gamari wrote:> Yes, this is the cause and the import does handle this; I just (yet
> again) forgot to rerun this stage of the import. This should be fixed now.

For me, nothing seems to have changed on https://gitlab.staging.haskell.org/ghc/ghc/issues/13497
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Request for comments on dry-run Trac -> GitLab migration

Julian Leviston-2
In reply to this post by Ben Gamari-3

On 5 Feb 2019, at 3:06 am, Ben Gamari <[hidden email]> wrote:

TL;DR. Have a look at this [2] test import of GHC's Trac tickets. Tell us
      what issues you find.


First up, it’s utterly amazing to me that this is importable and with all links transferred and syntax highlighting and whatnot! so great!
However, attachments don’t seem to be present (At least, where I’m looking: at https://gitlab.staging.haskell.org/ghc/ghc/issues/3372)

Julian

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Request for comments on dry-run Trac -> GitLab migration

Tobias Dammers
In reply to this post by Ryan Scott
Noted, thanks for reporting.

On Mon, Feb 04, 2019 at 02:05:07PM -0500, Ryan Scott wrote:

> There appears to be some impedance mismatches between GitLab's formatting
> and Trac's formatting in certain places. For example, see the bottom of
> this issue [1], which has a long, hyperlinked line with the phrase:
>
>
> Icanproducethe`missinginstance`issuewithouthavingtorecompileGHC,whichiswhyIthinkitmightbeindependentofthisbug.
>
> Ryan S.
> -----
> [1] https://gitlab.staging.haskell.org/ghc/ghc/issues/16211

> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


--
Tobias Dammers - [hidden email]
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs