Reviews

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

Reviews

GHC - devs mailing list

When reviewing a MR, I sometimes want to look at (and even add comments to) code that isn’t displayed in the MR window.  With Phab there was a “show 20 more lines” link, and even “show the whole file”.  How do I do that in GitLab?

 

When submitting a review, I often want to add an overall comment, not related to  a particular line of code?  How do I do that?

 

Thanks

 

Simoin


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Reviews

Evan Laforge
On Tue, Jan 8, 2019 at 6:01 PM Simon Peyton Jones via ghc-devs
<[hidden email]> wrote:
>
> When reviewing a MR, I sometimes want to look at (and even add comments to) code that isn’t displayed in the MR window.  With Phab there was a “show 20 more lines” link, and even “show the whole file”.  How do I do that in GitLab?

If you click on the gray-ish text on the top and bottom edges of the
displayed greed/red diff areas, it should give you some more lines.

> When submitting a review, I often want to add an overall comment, not related to  a particular line of code?  How do I do that?

I do that by going back to the "Discussion" tab and adding something
at the bottom.
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: Reviews

GHC - devs mailing list
|  > When submitting a review, I often want to add an overall comment, not
|  related to  a particular line of code?  How do I do that?
|  
|  I do that by going back to the "Discussion" tab and adding something at the
|  bottom.

But alas then it does not form part of the review, landing as a single email. It becomes a separate, disconnected comment.

Simon

|  -----Original Message-----
|  From: Evan Laforge <[hidden email]>
|  Sent: 08 January 2019 12:48
|  To: Simon Peyton Jones <[hidden email]>
|  Cc: ghc-devs <[hidden email]>
|  Subject: Re: Reviews
|  
|  On Tue, Jan 8, 2019 at 6:01 PM Simon Peyton Jones via ghc-devs <ghc-
|  [hidden email]> wrote:
|  >
|  > When reviewing a MR, I sometimes want to look at (and even add comments
|  to) code that isn’t displayed in the MR window.  With Phab there was a
|  “show 20 more lines” link, and even “show the whole file”.  How do I do
|  that in GitLab?
|  
|  If you click on the gray-ish text on the top and bottom edges of the
|  displayed greed/red diff areas, it should give you some more lines.
|  
|  > When submitting a review, I often want to add an overall comment, not
|  related to  a particular line of code?  How do I do that?
|  
|  I do that by going back to the "Discussion" tab and adding something at the
|  bottom.
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Reviews

Evan Laforge
On Tue, Jan 8, 2019 at 8:54 PM Simon Peyton Jones <[hidden email]> wrote:
> |  > When submitting a review, I often want to add an overall comment, not
> |  related to  a particular line of code?  How do I do that?
> |
> |  I do that by going back to the "Discussion" tab and adding something at the
> |  bottom.
>
> But alas then it does not form part of the review, landing as a single email. It becomes a separate, disconnected comment.

As far as I can tell, Gitlab doesn't really have a concept of a
review, it's just big pile of disconnected comments... or rather,
they're just all connected to the MR.  But there's no concept of a
"review cycle" except by what you impose by convention.  At work, we
simulate it with assigning to author and reviewer, and the reviewer
signs off by resolving all comments.  Gitlab supports this a bit, it
can prevent you from merging until all comments are resolved, and that
includes the unconnected "discussion" ones.
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Reviews

Ben Gamari-2
Evan Laforge <[hidden email]> writes:

> On Tue, Jan 8, 2019 at 8:54 PM Simon Peyton Jones <[hidden email]> wrote:
>> |  > When submitting a review, I often want to add an overall comment, not
>> |  related to  a particular line of code?  How do I do that?
>> |
>> |  I do that by going back to the "Discussion" tab and adding something at the
>> |  bottom.
>>
>> But alas then it does not form part of the review, landing as a single email. It becomes a separate, disconnected comment.
>
> As far as I can tell, Gitlab doesn't really have a concept of a
> review, it's just big pile of disconnected comments... or rather,
> they're just all connected to the MR.

This isn't quite true. Transactional reviews were added in GitLab 11.4
[1]. That being said, the connection between the comments in a review is
a bit looser than it was in Phabricator.


Cheers,

- Ben

[1] https://gitlab.com/gitlab-org/gitlab-ee/issues/1984

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Reviews

GHC - devs mailing list
To return to the original question, how do I add an overall comment for a (multi-comment) review?

Simon

|  -----Original Message-----
|  From: Ben Gamari <[hidden email]>
|  Sent: 10 January 2019 17:41
|  To: Evan Laforge <[hidden email]>; Simon Peyton Jones
|  <[hidden email]>
|  Cc: ghc-devs <[hidden email]>
|  Subject: Re: Reviews
|  
|  Evan Laforge <[hidden email]> writes:
|  
|  > On Tue, Jan 8, 2019 at 8:54 PM Simon Peyton Jones <[hidden email]>
|  wrote:
|  >> |  > When submitting a review, I often want to add an overall
|  >> | comment, not  related to  a particular line of code?  How do I do
|  that?
|  >> |
|  >> |  I do that by going back to the "Discussion" tab and adding
|  >> | something at the  bottom.
|  >>
|  >> But alas then it does not form part of the review, landing as a single
|  email. It becomes a separate, disconnected comment.
|  >
|  > As far as I can tell, Gitlab doesn't really have a concept of a
|  > review, it's just big pile of disconnected comments... or rather,
|  > they're just all connected to the MR.
|  
|  
|  This isn't quite true. Transactional reviews were added in GitLab 11.4 [1].
|  That being said, the connection between the comments in a review is a bit
|  looser than it was in Phabricator.
|  
|  
|  Cheers,
|  
|  - Ben
|  
|  [1] https://gitlab.com/gitlab-org/gitlab-ee/issues/1984
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: Reviews

Ben Gamari-2
In reply to this post by GHC - devs mailing list
Simon Peyton Jones via ghc-devs <[hidden email]> writes:

> |  > When submitting a review, I often want to add an overall comment, not
> |  related to  a particular line of code?  How do I do that?
> |  
> |  I do that by going back to the "Discussion" tab and adding something at the
> |  bottom.
>
> But alas then it does not form part of the review, landing as a single
> email. It becomes a separate, disconnected comment.
>
Right, while code comments are transactional unfortunately "discussion"
comments are currently not. I'm not sure there are currently plans to
change this.

Another issue is that apparently GitLab still sends one email per
comment instead of one comment per batch. This will evidently be fixed
in GitLab 11.6 [1].

Cheers,

- Ben


[1] https://gitlab.com/gitlab-org/gitlab-ee/issues/4326

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Reviews

GHC - devs mailing list
|  Another issue is that apparently GitLab still sends one email per comment
|  instead of one comment per batch. This will evidently be fixed in GitLab
|  11.6 [1].

yes that is TERRIBLE.  When does 11.6 land?

What I want is to have a batch of comments with an overview message.  We used that /all the time/ in Phab!  For example:

   I like this patch but you might want to think about X and Y.
   Meanwhile I have added a bunch of detailed comments.

This would fit very well with the "batch of comments in one email" change.

Simon

|  -----Original Message-----
|  From: Ben Gamari <[hidden email]>
|  Sent: 10 January 2019 17:46
|  To: Simon Peyton Jones <[hidden email]>; Evan Laforge
|  <[hidden email]>
|  Cc: ghc-devs <[hidden email]>
|  Subject: RE: Reviews
|  
|  Simon Peyton Jones via ghc-devs <[hidden email]> writes:
|  
|  > |  > When submitting a review, I often want to add an overall comment,
|  > | not  related to  a particular line of code?  How do I do that?
|  > |
|  > |  I do that by going back to the "Discussion" tab and adding
|  > | something at the  bottom.
|  >
|  > But alas then it does not form part of the review, landing as a single
|  > email. It becomes a separate, disconnected comment.
|  >
|  Right, while code comments are transactional unfortunately "discussion"
|  comments are currently not. I'm not sure there are currently plans to
|  change this.
|  
|  Another issue is that apparently GitLab still sends one email per comment
|  instead of one comment per batch. This will evidently be fixed in GitLab
|  11.6 [1].
|  
|  Cheers,
|  
|  - Ben
|  
|  
|  [1] https://gitlab.com/gitlab-org/gitlab-ee/issues/4326
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: Reviews

Ben Gamari-2
In reply to this post by GHC - devs mailing list
Simon Peyton Jones <[hidden email]> writes:

> To return to the original question, how do I add an overall comment for a (multi-comment) review?
>
Unfortunately you can only add an overall comment separate from the
multi-comment review. I have inquired [1] about the status of this
feature with upstream.

Cheers,

- Ben

[1] https://gitlab.com/gitlab-org/gitlab-ee/issues/1984#note_130609989

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Reviews

Ben Gamari-2
In reply to this post by GHC - devs mailing list
Simon Peyton Jones <[hidden email]> writes:

> |  Another issue is that apparently GitLab still sends one email per comment
> |  instead of one comment per batch. This will evidently be fixed in GitLab
> |  11.6 [1].
>
> yes that is TERRIBLE.  When does 11.6 land?
>
It is the next release. I will poke our contact to make sure that they
realize the severity of the issue.

> What I want is to have a batch of comments with an overview message.
> We used that /all the time/ in Phab! For example:
>
>    I like this patch but you might want to think about X and Y.
>    Meanwhile I have added a bunch of detailed comments.
>
> This would fit very well with the "batch of comments in one email" change.
>
Indeed and upstream agrees. They created a feature request [1] in response
to my suggestion. I'll make sure that I mention this to our GitLab contact.

Cheers,

- Ben


[1] https://gitlab.com/gitlab-org/gitlab-ee/issues/9145


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Reviews

Richard Eisenberg-4
While we're whinging:

- I'm looking at the Discussion page for an MR (https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904) and I see a comment Simon made, beginning with "No, I am not!". I wanted a bit more context. So I click on the filename above the Discussion and am warped to the Changes view (https://gitlab.haskell.org/ghc/ghc/merge_requests/74/diffs#9f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853). But Simon's comment isn't there. Instead, I see a different comment, beginning with "In canEqTyVar we now compare kinds...". So I'm lost here.

- Simon recently posted a bunch of comments in response to a bunch of my comments. I have a thick stack of emails about each individual comment. But when I view the discussion page (https://gitlab.haskell.org/ghc/ghc/merge_requests/74), I can find Simon's comments only buried in the Discussions that I started. There appears to be no way to glean, from the web page, what has happened since last I looked. Is there a way to see a "log" of activity on an MR? That way, in case I'm drowning in email (common occurrence) and just want to get up to speed on a given MR, I can get an idea of what's gone on. Now, the thick stack of emails seems like the only way to do this.

- Is there a way to get a timestamped list of what discussions are resolved? Sometimes it's nice to be able to check that the resolution was what I had hoped for.

- The Changes page has a table of contents on the left. This is useful sometimes. (In this way, GL beats Phab, where it was sometimes hard to find where a certain file is listed when in the middle of a review.) But is there a way to collapse the ToC? Most of the time, I'm focused on the code itself, and the ToC drastically reduces the number of characters per line, when I view diffs side-by-side.

Thanks!
Richard

PS: I well remember how phrustrated I was with Phab when that rolled out, and how I eventually came to appreciate it. I'm being more patient this time around. In retrospect my trouble was more with arcanist than with Phab itself. (Arcanist and I never really got along... we just reached an unsteady truce, and I won't miss it.) I am happy to be using git as the tool now. But it's effortful to figure out efficient workflows in a new space, and I'm grateful for any help here. Thanks.

On Jan 10, 2019, at 1:27 PM, Ben Gamari <[hidden email]> wrote:

Simon Peyton Jones <[hidden email]> writes:

|  Another issue is that apparently GitLab still sends one email per comment
|  instead of one comment per batch. This will evidently be fixed in GitLab
|  11.6 [1].

yes that is TERRIBLE.  When does 11.6 land?

It is the next release. I will poke our contact to make sure that they
realize the severity of the issue.

What I want is to have a batch of comments with an overview message.
We used that /all the time/ in Phab! For example:

  I like this patch but you might want to think about X and Y.
  Meanwhile I have added a bunch of detailed comments.

This would fit very well with the "batch of comments in one email" change.

Indeed and upstream agrees. They created a feature request [1] in response
to my suggestion. I'll make sure that I mention this to our GitLab contact.

Cheers,

- Ben


[1] https://gitlab.com/gitlab-org/gitlab-ee/issues/9145

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: Reviews

GHC - devs mailing list

So I click on the filename above the Discussion and am warped to the Changes view (https://gitlab.haskell.org/ghc/ghc/merge_requests/74/diffs#9f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853). But Simon's comment isn't there. Instead, I see a different comment, beginning with "In canEqTyVar we now compare kinds...". So I'm lost here.

 

When I try that, it starts by displaying the code from the file.  No rotating circles or anything. But if I wait ten seconds, suddenly the comments appear.   So:

  • rendering seems terribly slow
  • there is no indication that it is incomplete

 

Maybe you just weren’t waiting long enough?

 

Even displaying the original MR https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904 is slow. For 18 seconds it displays a kind of skeleton page with horizontal grey bars that flash occasionally.  Then it renders.

 

Simon

 

From: Richard Eisenberg <[hidden email]>
Sent: 10 January 2019 19:05
To: Ben Gamari <[hidden email]>
Cc: Simon Peyton Jones <[hidden email]>; Evan Laforge <[hidden email]>; ghc-devs <[hidden email]>
Subject: Re: Reviews

 

While we're whinging:

 

- I'm looking at the Discussion page for an MR (https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904) and I see a comment Simon made, beginning with "No, I am not!". I wanted a bit more context. So I click on the filename above the Discussion and am warped to the Changes view (https://gitlab.haskell.org/ghc/ghc/merge_requests/74/diffs#9f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853). But Simon's comment isn't there. Instead, I see a different comment, beginning with "In canEqTyVar we now compare kinds...". So I'm lost here.

 

- Simon recently posted a bunch of comments in response to a bunch of my comments. I have a thick stack of emails about each individual comment. But when I view the discussion page (https://gitlab.haskell.org/ghc/ghc/merge_requests/74), I can find Simon's comments only buried in the Discussions that I started. There appears to be no way to glean, from the web page, what has happened since last I looked. Is there a way to see a "log" of activity on an MR? That way, in case I'm drowning in email (common occurrence) and just want to get up to speed on a given MR, I can get an idea of what's gone on. Now, the thick stack of emails seems like the only way to do this.

 

- Is there a way to get a timestamped list of what discussions are resolved? Sometimes it's nice to be able to check that the resolution was what I had hoped for.

 

- The Changes page has a table of contents on the left. This is useful sometimes. (In this way, GL beats Phab, where it was sometimes hard to find where a certain file is listed when in the middle of a review.) But is there a way to collapse the ToC? Most of the time, I'm focused on the code itself, and the ToC drastically reduces the number of characters per line, when I view diffs side-by-side.

 

Thanks!

Richard

 

PS: I well remember how phrustrated I was with Phab when that rolled out, and how I eventually came to appreciate it. I'm being more patient this time around. In retrospect my trouble was more with arcanist than with Phab itself. (Arcanist and I never really got along... we just reached an unsteady truce, and I won't miss it.) I am happy to be using git as the tool now. But it's effortful to figure out efficient workflows in a new space, and I'm grateful for any help here. Thanks.



On Jan 10, 2019, at 1:27 PM, Ben Gamari <[hidden email]> wrote:

 

Simon Peyton Jones <[hidden email]> writes:


|  Another issue is that apparently GitLab still sends one email per comment
|  instead of one comment per batch. This will evidently be fixed in GitLab
|  11.6 [1].

yes that is TERRIBLE.  When does 11.6 land?

It is the next release. I will poke our contact to make sure that they
realize the severity of the issue.


What I want is to have a batch of comments with an overview message.
We used that /all the time/ in Phab! For example:

  I like this patch but you might want to think about X and Y.
  Meanwhile I have added a bunch of detailed comments.

This would fit very well with the "batch of comments in one email" change.

Indeed and upstream agrees. They created a feature request [1] in response
to my suggestion. I'll make sure that I mention this to our GitLab contact.

Cheers,

- Ben


[1] https://gitlab.com/gitlab-org/gitlab-ee/issues/9145

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

 


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: Reviews

GHC - devs mailing list
In reply to this post by Richard Eisenberg-4

Is there a way to see a "log" of activity on an MR? That way, in case I'm drowning in email (common occurrence) and just want to get up to speed on a given MR, I can get an idea of what's gone on.

 

What I expected was:

 

  • The Discussion tab shows a time-sequenced log of activity
  • The Changes tab shows topic-focused threads of discussion, each thread starting at a line of code.

 

(This is more or less what Phab did.)

 

But actually the Discussion tab seems to be no more than a concatenation of the threads in the Changes tab, so as Richard says there is no way to see the recent changes.

 

How sad!

 

Simon

 

From: Richard Eisenberg <[hidden email]>
Sent: 10 January 2019 19:05
To: Ben Gamari <[hidden email]>
Cc: Simon Peyton Jones <[hidden email]>; Evan Laforge <[hidden email]>; ghc-devs <[hidden email]>
Subject: Re: Reviews

 

While we're whinging:

 

- I'm looking at the Discussion page for an MR (https://gitlab.haskell.org/ghc/ghc/merge_requests/74#note_1904) and I see a comment Simon made, beginning with "No, I am not!". I wanted a bit more context. So I click on the filename above the Discussion and am warped to the Changes view (https://gitlab.haskell.org/ghc/ghc/merge_requests/74/diffs#9f8e9eab0dc8b12ae9f92fbb76ddca15c817667a_1852_1853). But Simon's comment isn't there. Instead, I see a different comment, beginning with "In canEqTyVar we now compare kinds...". So I'm lost here.

 

- Simon recently posted a bunch of comments in response to a bunch of my comments. I have a thick stack of emails about each individual comment. But when I view the discussion page (https://gitlab.haskell.org/ghc/ghc/merge_requests/74), I can find Simon's comments only buried in the Discussions that I started. There appears to be no way to glean, from the web page, what has happened since last I looked. Is there a way to see a "log" of activity on an MR? That way, in case I'm drowning in email (common occurrence) and just want to get up to speed on a given MR, I can get an idea of what's gone on. Now, the thick stack of emails seems like the only way to do this.

 

- Is there a way to get a timestamped list of what discussions are resolved? Sometimes it's nice to be able to check that the resolution was what I had hoped for.

 

- The Changes page has a table of contents on the left. This is useful sometimes. (In this way, GL beats Phab, where it was sometimes hard to find where a certain file is listed when in the middle of a review.) But is there a way to collapse the ToC? Most of the time, I'm focused on the code itself, and the ToC drastically reduces the number of characters per line, when I view diffs side-by-side.

 

Thanks!

Richard

 

PS: I well remember how phrustrated I was with Phab when that rolled out, and how I eventually came to appreciate it. I'm being more patient this time around. In retrospect my trouble was more with arcanist than with Phab itself. (Arcanist and I never really got along... we just reached an unsteady truce, and I won't miss it.) I am happy to be using git as the tool now. But it's effortful to figure out efficient workflows in a new space, and I'm grateful for any help here. Thanks.



On Jan 10, 2019, at 1:27 PM, Ben Gamari <[hidden email]> wrote:

 

Simon Peyton Jones <[hidden email]> writes:


|  Another issue is that apparently GitLab still sends one email per comment
|  instead of one comment per batch. This will evidently be fixed in GitLab
|  11.6 [1].

yes that is TERRIBLE.  When does 11.6 land?

It is the next release. I will poke our contact to make sure that they
realize the severity of the issue.


What I want is to have a batch of comments with an overview message.
We used that /all the time/ in Phab! For example:

  I like this patch but you might want to think about X and Y.
  Meanwhile I have added a bunch of detailed comments.

This would fit very well with the "batch of comments in one email" change.

Indeed and upstream agrees. They created a feature request [1] in response
to my suggestion. I'll make sure that I mention this to our GitLab contact.

Cheers,

- Ben


[1] https://gitlab.com/gitlab-org/gitlab-ee/issues/9145

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

 


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Reviews

Richard Eisenberg-4
In reply to this post by GHC - devs mailing list


On Jan 11, 2019, at 4:49 AM, Simon Peyton Jones <[hidden email]> wrote:

When I try that, it starts by displaying the code from the file.  No rotating circles or anything. But if I wait ten seconds, suddenly the comments appear.   So:
  • rendering seems terribly slow
  • there is no indication that it is incomplete
 
Maybe you just weren’t waiting long enough?

I had a similar experience (with comments coming later, and with no indication that I should wait), but then the comments were incomplete when they did appear, including only your new comment, not the older one.

Richard


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Reviews

Carter Schonwald
A similar issue happens in terms of rendering time if you look at a giant change set, the caching seems pretty minimal on a lot of the rendering steps in gitlab. 

On Fri, Jan 11, 2019 at 11:05 AM Richard Eisenberg <[hidden email]> wrote:


On Jan 11, 2019, at 4:49 AM, Simon Peyton Jones <[hidden email]> wrote:

When I try that, it starts by displaying the code from the file.  No rotating circles or anything. But if I wait ten seconds, suddenly the comments appear.   So:
  • rendering seems terribly slow
  • there is no indication that it is incomplete
 
Maybe you just weren’t waiting long enough?

I had a similar experience (with comments coming later, and with no indication that I should wait), but then the comments were incomplete when they did appear, including only your new comment, not the older one.

Richard

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs