T13456

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

T13456

GHC - devs mailing list

Ben, Omer

I find that when running the testsuite, I get the garbage below, for ghci/should_run/T13456.

Adding an empty file T13456.stderr seems to fix it in one of my trees, but not in another.  Very strange.

Any ideas?

Simon

 

Framework failures:

   T13456.run  T13456 [Traceback (most recent call last):

  File "/home/simonpj/code/HEAD-1/testsuite/driver/testlib.py", line 996, in test_common_work

    do_test(name, way, func, args, files)

  File "/home/simonpj/code/HEAD-1/testsuite/driver/testlib.py", line 1094, in do_test

    result = func(*[name,way] + args)

  File "/home/simonpj/code/HEAD-1/testsuite/driver/testlib.py", line 1213, in ghci_script

    return simple_run( name, way, cmd, getTestOpts().extra_run_opts )

  File "/home/simonpj/code/HEAD-1/testsuite/driver/testlib.py", line 1638, in simple_run

    stderr=read_stderr(name),

  File "/home/simonpj/code/HEAD-1/testsuite/driver/testlib.py", line 1808, in read_stderr

    return in_testdir(name, 'run.stderr').read_text(encoding='UTF-8')

  File "/usr/lib/python3.6/pathlib.py", line 1196, in read_text

    with self.open(mode='r', encoding=encoding, errors=errors) as f:

  File "/usr/lib/python3.6/pathlib.py", line 1183, in open

    opener=self._opener)

  File "/usr/lib/python3.6/pathlib.py", line 1037, in _opener

    return self._accessor.open(self, flags, mode)

  File "/usr/lib/python3.6/pathlib.py", line 387, in wrapped

    return strfunc(str(pathobj), *args)

FileNotFoundError: [Errno 2] No such file or directory: 'T13456.run/T13456.run.stderr'

] (ghci)


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

T13456

GHC - devs mailing list

I’m getting this failure (below) from validate fairly consistently.

It is often silenced by adding an empty file ghci/should_run/T13456.stderr

But it’s troubling.  Does anyone else see this?  How can I debug it?

Thanks

Simon

 

 

Framework failures:

   /tmp/ghctest-31oxzmog/test   spaces/ghci/should_run/T13456.run  T13456 [Traceback (most recent call last):

  File "/home/simonpj/code/HEAD-1/testsuite/driver/testlib.py", line 996, in test_common_work

    do_test(name, way, func, args, files)

  File "/home/simonpj/code/HEAD-1/testsuite/driver/testlib.py", line 1094, in do_test

    result = func(*[name,way] + args)

  File "/home/simonpj/code/HEAD-1/testsuite/driver/testlib.py", line 1213, in ghci_script

    return simple_run( name, way, cmd, getTestOpts().extra_run_opts )

  File "/home/simonpj/code/HEAD-1/testsuite/driver/testlib.py", line 1638, in simple_run

    stderr=read_stderr(name),

  File "/home/simonpj/code/HEAD-1/testsuite/driver/testlib.py", line 1808, in read_stderr

    return in_testdir(name, 'run.stderr').read_text(encoding='UTF-8')

  File "/usr/lib/python3.6/pathlib.py", line 1196, in read_text

    with self.open(mode='r', encoding=encoding, errors=errors) as f:

  File "/usr/lib/python3.6/pathlib.py", line 1183, in open

    opener=self._opener)

  File "/usr/lib/python3.6/pathlib.py", line 1037, in _opener

    return self._accessor.open(self, flags, mode)

  File "/usr/lib/python3.6/pathlib.py", line 387, in wrapped

    return strfunc(str(pathobj), *args)

FileNotFoundError: [Errno 2] No such file or directory: '/tmp/ghctest-31oxzmog/test   spaces/ghci/should_run/T13456.run/T13456.run.stderr'

] (ghci)

 


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: T13456

Ben Gamari-3
Simon Peyton Jones via ghc-devs <[hidden email]> writes:

> I'm getting this failure (below) from validate fairly consistently.
> It is often silenced by adding an empty file ghci/should_run/T13456.stderr
> But it's troubling.  Does anyone else see this?  How can I debug it?
>
Indeed this is odd. I have not seen this in CI or my local
builds. It's possible that I have seen it in local builds that were failing
for other reasons but ignored it.

While I don't know why you are seeing these failures in general, the
fact that they are reported as framework failures is arguably a bug. I
would argue that we should treat a non-existing .stderr file as we would
an empty file. I've opened !3121 fixing this. Hopefully you will see a
more helpful error message with this patch.

Cheers,

- Ben

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: T13456

GHC - devs mailing list
Ben

I'm still getting framework failures from the testsuite, as below.

But now it's not just me: it's CI!   See !2600 which is failing in this way.

It'd be good to nail this... it seems wrong to have to ignore framework failures when checking that a build validates.

Simon

|  -----Original Message-----
|  From: Simon Peyton Jones
|  Sent: 20 April 2020 21:42
|  To: Ben Gamari <[hidden email]>
|  Subject: RE: T13456
|  
|  Thanks!
|  
|  | -----Original Message-----
|  | From: Ben Gamari <[hidden email]>
|  | Sent: 20 April 2020 18:57
|  | To: Simon Peyton Jones <[hidden email]>; ghc-devs <ghc-
|  | [hidden email]>
|  | Subject: Re: T13456
|  |
|  | Simon Peyton Jones via ghc-devs <[hidden email]> writes:
|  |
|  | > I'm getting this failure (below) from validate fairly consistently.
|  | > It is often silenced by adding an empty file
|  | > ghci/should_run/T13456.stderr But it's troubling.  Does anyone else
|  see
|  | this?  How can I debug it?
|  | >
|  | Indeed this is odd. I have not seen this in CI or my local builds. It's
|  | possible that I have seen it in local builds that were failing for
|  other
|  | reasons but ignored it.
|  |
|  | While I don't know why you are seeing these failures in general, the
|  fact
|  | that they are reported as framework failures is arguably a bug. I would
|  | argue that we should treat a non-existing .stderr file as we would an
|  | empty file. I've opened !3121 fixing this. Hopefully you will see a
|  more
|  | helpful error message with this patch.
|  |
|  | Cheers,
|  |
|  | - Ben
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: T13456

Sylvain Henry-2
Simon

!2600 doesn't contain the fix introduced by !3121. You should rebase it.

Sylvain


On 28/04/2020 09:50, Simon Peyton Jones via ghc-devs wrote:

> Ben
>
> I'm still getting framework failures from the testsuite, as below.
>
> But now it's not just me: it's CI!   See !2600 which is failing in this way.
>
> It'd be good to nail this... it seems wrong to have to ignore framework failures when checking that a build validates.
>
> Simon
>
> |  -----Original Message-----
> |  From: Simon Peyton Jones
> |  Sent: 20 April 2020 21:42
> |  To: Ben Gamari <[hidden email]>
> |  Subject: RE: T13456
> |
> |  Thanks!
> |
> |  | -----Original Message-----
> |  | From: Ben Gamari <[hidden email]>
> |  | Sent: 20 April 2020 18:57
> |  | To: Simon Peyton Jones <[hidden email]>; ghc-devs <ghc-
> |  | [hidden email]>
> |  | Subject: Re: T13456
> |  |
> |  | Simon Peyton Jones via ghc-devs <[hidden email]> writes:
> |  |
> |  | > I'm getting this failure (below) from validate fairly consistently.
> |  | > It is often silenced by adding an empty file
> |  | > ghci/should_run/T13456.stderr But it's troubling.  Does anyone else
> |  see
> |  | this?  How can I debug it?
> |  | >
> |  | Indeed this is odd. I have not seen this in CI or my local builds. It's
> |  | possible that I have seen it in local builds that were failing for
> |  other
> |  | reasons but ignored it.
> |  |
> |  | While I don't know why you are seeing these failures in general, the
> |  fact
> |  | that they are reported as framework failures is arguably a bug. I would
> |  | argue that we should treat a non-existing .stderr file as we would an
> |  | empty file. I've opened !3121 fixing this. Hopefully you will see a
> |  more
> |  | helpful error message with this patch.
> |  |
> |  | Cheers,
> |  |
> |  | - Ben
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: T13456

GHC - devs mailing list
Aha, thanks. I have just done that.

|  -----Original Message-----
|  From: Sylvain Henry <[hidden email]>
|  Sent: 28 April 2020 09:24
|  To: Simon Peyton Jones <[hidden email]>; Ben Gamari <ben@well-
|  typed.com>
|  Cc: ghc-devs <[hidden email]>
|  Subject: Re: T13456
|  
|  Simon
|  
|  !2600 doesn't contain the fix introduced by !3121. You should rebase it.
|  
|  Sylvain
|  
|  
|  On 28/04/2020 09:50, Simon Peyton Jones via ghc-devs wrote:
|  > Ben
|  >
|  > I'm still getting framework failures from the testsuite, as below.
|  >
|  > But now it's not just me: it's CI!   See !2600 which is failing in this
|  way.
|  >
|  > It'd be good to nail this... it seems wrong to have to ignore framework
|  failures when checking that a build validates.
|  >
|  > Simon
|  >
|  > |  -----Original Message-----
|  > |  From: Simon Peyton Jones
|  > |  Sent: 20 April 2020 21:42
|  > |  To: Ben Gamari <[hidden email]>
|  > |  Subject: RE: T13456
|  > |
|  > |  Thanks!
|  > |
|  > |  | -----Original Message-----
|  > |  | From: Ben Gamari <[hidden email]>
|  > |  | Sent: 20 April 2020 18:57
|  > |  | To: Simon Peyton Jones <[hidden email]>; ghc-devs <ghc-
|  > |  | [hidden email]>
|  > |  | Subject: Re: T13456
|  > |  |
|  > |  | Simon Peyton Jones via ghc-devs <[hidden email]> writes:
|  > |  |
|  > |  | > I'm getting this failure (below) from validate fairly
|  consistently.
|  > |  | > It is often silenced by adding an empty file
|  > |  | > ghci/should_run/T13456.stderr But it's troubling.  Does anyone
|  else
|  > |  see
|  > |  | this?  How can I debug it?
|  > |  | >
|  > |  | Indeed this is odd. I have not seen this in CI or my local builds.
|  It's
|  > |  | possible that I have seen it in local builds that were failing for
|  > |  other
|  > |  | reasons but ignored it.
|  > |  |
|  > |  | While I don't know why you are seeing these failures in general,
|  the
|  > |  fact
|  > |  | that they are reported as framework failures is arguably a bug. I
|  would
|  > |  | argue that we should treat a non-existing .stderr file as we would
|  an
|  > |  | empty file. I've opened !3121 fixing this. Hopefully you will see
|  a
|  > |  more
|  > |  | helpful error message with this patch.
|  > |  |
|  > |  | Cheers,
|  > |  |
|  > |  | - Ben
|  > _______________________________________________
|  > ghc-devs mailing list
|  > [hidden email]
|  >
|  https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.has
|  kell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-
|  devs&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Ca31c492b26c14ca4ed4e08d
|  7eb4d85c6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637236590507618218
|  &amp;sdata=KQpAeNf4ZH4ajU3FlchAKPnN4x9JxiAHNfhsLIfIldY%3D&amp;reserved=0
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs