Trac to GitLab migration underway

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
21 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Trac to GitLab migration underway

Ben Gamari-3
Hello everyone,

I have started the process of migrating GHC's Trac content to GitLab.
GitLab (gitlab.haskell.org) and Trac (ghc.haskell.org) will be down
until this process has finished. I will post updates as necessary.

However, if you do need to refer to a ticket, you are welcome to use the
staging server [1], which has a reasonably up-to-date (read-only)
snapshot of our Trac tickets. However, do note that unfortunately
authentication via GitHub will not work on this site.

Cheers,

- Ben


[1] https://gitlab.staging.haskell.org/

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Ben Gamari-3
Ben Gamari <[hidden email]> writes:

> Hello everyone,
>
> I have started the process of migrating GHC's Trac content to GitLab.
> GitLab (gitlab.haskell.org) and Trac (ghc.haskell.org) will be down
> until this process has finished. I will post updates as necessary.
>
Hi everyone,

I'm happy to announce that the ticket and issue import processes are now
complete and gitlab.haskell.org is back online. There are still a few
final steps remaining which I will be carrying out over the next few
days:

 * Put in place redirect logic for Trac ticket and Wiki URLs

 * Add issue comments showing commit messages, replicating the previous
   Trac behavior

 * Migrate the GHC Blog entries

 * Make the old Trac instance again accessible in read-only mode

However, while I do this you should feel free to use gitlab.haskell.org freely.
If you notice any issues with the import feel free to open a ticket here [1].

Cheers,

- Ben



[1] https://gitlab.haskell.org/bgamari/gitlab-migration/issues

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Trac to GitLab migration underway

Alexandre Rodrigues

Those are great news, I did not expect such a large task with so many avenues for failure to go so well.

 

Thank you for your hard work, Ben and everyone else involved.

 


From: ghc-devs <[hidden email]> on behalf of Ben Gamari <[hidden email]>
Sent: Sunday, March 10, 2019 9:38:42 PM
To: GHC users; GHC developers; Haskell Cafe
Subject: Re: Trac to GitLab migration underway
 
Ben Gamari <[hidden email]> writes:

> Hello everyone,
>
> I have started the process of migrating GHC's Trac content to GitLab.
> GitLab (gitlab.haskell.org) and Trac (ghc.haskell.org) will be down
> until this process has finished. I will post updates as necessary.
>
Hi everyone,

I'm happy to announce that the ticket and issue import processes are now
complete and gitlab.haskell.org is back online. There are still a few
final steps remaining which I will be carrying out over the next few
days:

 * Put in place redirect logic for Trac ticket and Wiki URLs

 * Add issue comments showing commit messages, replicating the previous
   Trac behavior

 * Migrate the GHC Blog entries

 * Make the old Trac instance again accessible in read-only mode

However, while I do this you should feel free to use gitlab.haskell.org freely.
If you notice any issues with the import feel free to open a ticket here [1].

Cheers,

- Ben



[1] https://gitlab.haskell.org/bgamari/gitlab-migration/issues

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

GHC - devs mailing list
In reply to this post by Ben Gamari-3


On Sun, Mar 10, 2019 at 5:38 PM Ben Gamari <[hidden email]> wrote:
Ben Gamari <[hidden email]> writes:

> Hello everyone,
>
> I have started the process of migrating GHC's Trac content to GitLab.
> GitLab (gitlab.haskell.org) and Trac (ghc.haskell.org) will be down
> until this process has finished. I will post updates as necessary.
>
Hi everyone,

I'm happy to announce that the ticket and issue import processes are now
complete and gitlab.haskell.org is back online.
[...]

Thanks for your hard work!
 
Cheers,

- Ben



[1] https://gitlab.haskell.org/bgamari/gitlab-migration/issues
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

This message, and any attachments, is for the intended recipient(s) only, may contain information that is privileged, confidential and/or proprietary and subject to important terms and conditions available at http://www.digitalasset.com/emaildisclaimer.html. If you are not the intended recipient, please delete this message.
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Ara Adkins
Thanks for all the hard work to all involved! I’m very excited for everything to be in one place!

_ara

On 10 Mar 2019, at 22:15, Shayne Fletcher via ghc-devs <[hidden email]> wrote:



On Sun, Mar 10, 2019 at 5:38 PM Ben Gamari <[hidden email]> wrote:
Ben Gamari <[hidden email]> writes:

> Hello everyone,
>
> I have started the process of migrating GHC's Trac content to GitLab.
> GitLab (gitlab.haskell.org) and Trac (ghc.haskell.org) will be down
> until this process has finished. I will post updates as necessary.
>
Hi everyone,

I'm happy to announce that the ticket and issue import processes are now
complete and gitlab.haskell.org is back online.
[...]

Thanks for your hard work!
 
Cheers,

- Ben



[1] https://gitlab.haskell.org/bgamari/gitlab-migration/issues
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

This message, and any attachments, is for the intended recipient(s) only, may contain information that is privileged, confidential and/or proprietary and subject to important terms and conditions available at http://www.digitalasset.com/emaildisclaimer.html. If you are not the intended recipient, please delete this message.
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: Trac to GitLab migration underway

GHC - devs mailing list
In reply to this post by Ben Gamari-3
|  I'm happy to announce that the ticket and issue import processes are now
|  complete and gitlab.haskell.org is back online. There are still a few
|  final steps remaining which I will be carrying out over the next few
|  days:

Great!  I'm sure it'll help to have everything in one place.

Can I ask

* That the old ticket repo be put in read-only mode.  I've just modified the old #16344, but I should have modified the new one.

* Back on the tickets front, how do I record the test cases(s) for a ticket?  

* How do I record the MR for a ticket?  (When it has one.)

* That the banner (on the wiki at least) saying "This site has been deprecated and is in read-only mode" should describe how to get to the corresponding URL on the new wiki. Eg. say "If you are trying to access https://ghc.haskell.org/trac/ghc/wiki/<page>, the new URL is "https://gitlab.haskell.org/ghc/ghc/wikis/<page>".

* Where has https://ghc.haskell.org/trac/ghc/wiki/RichardAndSimon gone?  The corresponding URL on the new wiki doesn't exist.

* How can I list the title index on the new wiki?

* I have lots of pages like this one https://gitlab.haskell.org/ghc/ghc/wikis/proposal/custom-type-errors that list the tickets relevant to a particular keyword.  (Now "label" I think?)   But tat page is now lying: it claims to list current open tickets, but actually it's a frozen snapshot.  What should I do?

Thanks

Simon

|  I'm happy to announce that the ticket and issue import processes are now
|  complete and gitlab.haskell.org is back online. There are still a few
|  final steps remaining which I will be carrying out over the next few
|  days:
|  
|   * Put in place redirect logic for Trac ticket and Wiki URLs
|  
|   * Add issue comments showing commit messages, replicating the previous
|     Trac behavior
|  
|   * Migrate the GHC Blog entries
|  
|   * Make the old Trac instance again accessible in read-only mode
|  
|  However, while I do this you should feel free to use gitlab.haskell.org
|  freely.
|  If you notice any issues with the import feel free to open a ticket here
|  [1].
|  
|  Cheers,
|  
|  - Ben
|  
|  
|  
|  [1]
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
|  askell.org%2Fbgamari%2Fgitlab-
|  migration%2Fissues&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C48ce7f7334
|  c04a54549508d6a5a0cb40%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878
|  507364801779&amp;sdata=DIxKgZy%2B%2BTYq0P%2BEkrxjefMQqUf43ObXi9CLOGo0sk4%3
|  D&amp;reserved=0
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Matthew Pickering
> * That the old ticket repo be put in read-only mode.  I've just modified the old #16344, but I should have modified the new one.

That is tracked https://gitlab.haskell.org/bgamari/gitlab-migration/issues/14

It seems that there are still some problems to iron out though.

> * Back on the tickets front, how do I record the test cases(s) for a ticket?

I don't believe there is a way other than via the commit referencing the ticket.

>
> * How do I record the MR for a ticket?  (When it has one.)

When you mention a ticket in a MR then a reference should be created
from it to the ticket.

For example, when I mentioned !509 on this ticket it now displays in
the UI. https://gitlab.haskell.org/ghc/ghc/issues/16417

>
> * That the banner (on the wiki at least) saying "This site has been deprecated and is in read-only mode" should describe how to get to the corresponding URL on the new wiki. Eg. say "If you are trying to access https://ghc.haskell.org/trac/ghc/wiki/<page>, the new URL is "https://gitlab.haskell.org/ghc/ghc/wikis/<page>".
>
> * Where has https://ghc.haskell.org/trac/ghc/wiki/RichardAndSimon gone?  The corresponding URL on the new wiki doesn't exist.

The page is now located at:
https://gitlab.haskell.org/ghc/ghc/wikis/richard-and-simon

>
> * How can I list the title index on the new wiki?

An automatically generated index is available here

https://gitlab.haskell.org/ghc/ghc/wikis/index

I believe the intention is to automatically update this with a cronjob.

>
> * I have lots of pages like this one https://gitlab.haskell.org/ghc/ghc/wikis/proposal/custom-type-errors that list the tickets relevant to a particular keyword.  (Now "label" I think?)   But tat page is now lying: it claims to list current open tickets, but actually it's a frozen snapshot.  What should I do?

Gitlab Wiki does not support this feature so you have to refer to a
custom search.

For example: https://gitlab.haskell.org/ghc/ghc/issues?label_name%5B%5D=ApplicativeDo

However, it seems that the `CustomTypeErrors` label was lost during
the migration. Do you know why this is Tobias/Ben? It looks like it
will have to be added back manually.

>
> Thanks
>
> Simon
>
> |  I'm happy to announce that the ticket and issue import processes are now
> |  complete and gitlab.haskell.org is back online. There are still a few
> |  final steps remaining which I will be carrying out over the next few
> |  days:
> |
> |   * Put in place redirect logic for Trac ticket and Wiki URLs
> |
> |   * Add issue comments showing commit messages, replicating the previous
> |     Trac behavior
> |
> |   * Migrate the GHC Blog entries
> |
> |   * Make the old Trac instance again accessible in read-only mode
> |
> |  However, while I do this you should feel free to use gitlab.haskell.org
> |  freely.
> |  If you notice any issues with the import feel free to open a ticket here
> |  [1].
> |
> |  Cheers,
> |
> |  - Ben
> |
> |
> |
> |  [1]
> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
> |  askell.org%2Fbgamari%2Fgitlab-
> |  migration%2Fissues&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C48ce7f7334
> |  c04a54549508d6a5a0cb40%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878
> |  507364801779&amp;sdata=DIxKgZy%2B%2BTYq0P%2BEkrxjefMQqUf43ObXi9CLOGo0sk4%3
> |  D&amp;reserved=0
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: Trac to GitLab migration underway

GHC - devs mailing list
|  > * Back on the tickets front, how do I record the test cases(s) for a
|  ticket?
|  
|  I don't believe there is a way other than via the commit referencing the
|  ticket.

That's sad. It's a useful discipline to fill in that field before closing the ticket.  And it's useful later when looking for the test cases for the ticket.

Is this just a straight loss, or is there a longer term plan to recover it?  Do we need a self-imposed discipline, e.g. to ALWAYS add a comment that lists the test cases (and does nothing else) before closing an issue?

|  > * How do I record the MR for a ticket?  (When it has one.)
|  
|  When you mention a ticket in a MR then a reference should be created from
|  it to the ticket.
|  
|  For example, when I mentioned !509 on this ticket it now displays in the
|  UI.

I don't get it.  You manually added "Corresponding MR !509" to the issue Description.  Or are you saying that that apparently-user-written line was added by GitLab? If you have many MRs taht mention (perhaps en passant) the same issue, will there be many such lines?

Or is it another discipline we could impose on ourselves?

Simon

|  -----Original Message-----
|  From: Matthew Pickering <[hidden email]>
|  Sent: 11 March 2019 09:37
|  To: Simon Peyton Jones <[hidden email]>
|  Cc: Ben Gamari <[hidden email]>; GHC developers <[hidden email]>
|  Subject: Re: Trac to GitLab migration underway
|  
|  > * That the old ticket repo be put in read-only mode.  I've just modified
|  the old #16344, but I should have modified the new one.
|  
|  That is tracked
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
|  askell.org%2Fbgamari%2Fgitlab-
|  migration%2Fissues%2F14&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356
|  d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6
|  36878938597242017&amp;sdata=XnY%2Fo62mCkz849XKLKe8V3stFe8sorBQkqI9%2FY%2By
|  CdI%3D&amp;reserved=0
|  
|  It seems that there are still some problems to iron out though.
|  
|  > * Back on the tickets front, how do I record the test cases(s) for a
|  ticket?
|  
|  I don't believe there is a way other than via the commit referencing the
|  ticket.
|  
|  >
|  > * How do I record the MR for a ticket?  (When it has one.)
|  
|  When you mention a ticket in a MR then a reference should be created from
|  it to the ticket.
|  
|  For example, when I mentioned !509 on this ticket it now displays in the
|  UI.
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
|  askell.org%2Fghc%2Fghc%2Fissues%2F16417&amp;data=02%7C01%7Csimonpj%40micro
|  soft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011
|  db47%7C1%7C0%7C636878938597242017&amp;sdata=s5%2FfsXsx5t%2FuRIeq6AJZU5sr8P
|  FJpNt6nkr%2BObzRAmk%3D&amp;reserved=0
|  
|  >
|  > * That the banner (on the wiki at least) saying "This site has been
|  deprecated and is in read-only mode" should describe how to get to the
|  corresponding URL on the new wiki. Eg. say "If you are trying to access
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
|  ell.org%2Ftrac%2Fghc%2Fwiki%2F&amp;data=02%7C01%7Csimonpj%40microsoft.com%
|  7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%
|  7C0%7C636878938597242017&amp;sdata=vq0ZCkxOmaQp4vB3WPzc%2BovCn1oSSak5K6CYM
|  1UyIq4%3D&amp;reserved=0<page>, the new URL is
|  "https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
|  haskell.org%2Fghc%2Fghc%2Fwikis%2F&amp;data=02%7C01%7Csimonpj%40microsoft.
|  com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%
|  7C1%7C0%7C636878938597242017&amp;sdata=ZbZf%2BlVa1rqrngh82QrJAIRmDFaGMp0Gb
|  BUo5ABhqVo%3D&amp;reserved=0<page>".
|  >
|  > * Where has
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
|  ell.org%2Ftrac%2Fghc%2Fwiki%2FRichardAndSimon&amp;data=02%7C01%7Csimonpj%4
|  0microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d
|  7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=xkERHLEyWh8yWLxRS2GUZ4iu
|  Yk0DjFBxuKFkQbnyUeI%3D&amp;reserved=0 gone?  The corresponding URL on the
|  new wiki doesn't exist.
|  
|  The page is now located at:
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
|  askell.org%2Fghc%2Fghc%2Fwikis%2Frichard-and-
|  simon&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d
|  6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&
|  amp;sdata=X%2BOPbJn4zTiGNkH%2Ba5TVoge6dxZmGw0WSxrnxEpk0og%3D&amp;reserved=
|  0
|  
|  >
|  > * How can I list the title index on the new wiki?
|  
|  An automatically generated index is available here
|  
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
|  askell.org%2Fghc%2Fghc%2Fwikis%2Findex&amp;data=02%7C01%7Csimonpj%40micros
|  oft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011d
|  b47%7C1%7C0%7C636878938597242017&amp;sdata=BZ337ak7obJlIGW4GK5R4FOl1uCCH2T
|  D4DGorbNyz28%3D&amp;reserved=0
|  
|  I believe the intention is to automatically update this with a cronjob.
|  
|  >
|  > * I have lots of pages like this one
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
|  askell.org%2Fghc%2Fghc%2Fwikis%2Fproposal%2Fcustom-type-
|  errors&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008
|  d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017
|  &amp;sdata=sueCHGV9aE36gaIqUgxBq1VZl4zOKhCYDOWwsnSgAss%3D&amp;reserved=0
|  that list the tickets relevant to a particular keyword.  (Now "label" I
|  think?)   But tat page is now lying: it claims to list current open
|  tickets, but actually it's a frozen snapshot.  What should I do?
|  
|  Gitlab Wiki does not support this feature so you have to refer to a custom
|  search.
|  
|  For example:
|  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
|  askell.org%2Fghc%2Fghc%2Fissues%3Flabel_name%255B%255D%3DApplicativeDo&amp
|  ;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319
|  %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata
|  =DM%2B9ZPFxUhJW%2B2EokkOJzXF6Ca6PlSgQf1TGsCt36Wc%3D&amp;reserved=0
|  
|  However, it seems that the `CustomTypeErrors` label was lost during the
|  migration. Do you know why this is Tobias/Ben? It looks like it will have
|  to be added back manually.
|  
|  >
|  > Thanks
|  >
|  > Simon
|  >
|  > |  I'm happy to announce that the ticket and issue import processes
|  > | are now  complete and gitlab.haskell.org is back online. There are
|  > | still a few  final steps remaining which I will be carrying out over
|  > | the next few
|  > |  days:
|  > |
|  > |   * Put in place redirect logic for Trac ticket and Wiki URLs
|  > |
|  > |   * Add issue comments showing commit messages, replicating the
|  previous
|  > |     Trac behavior
|  > |
|  > |   * Migrate the GHC Blog entries
|  > |
|  > |   * Make the old Trac instance again accessible in read-only mode
|  > |
|  > |  However, while I do this you should feel free to use
|  > | gitlab.haskell.org  freely.
|  > |  If you notice any issues with the import feel free to open a ticket
|  > | here  [1].
|  > |
|  > |  Cheers,
|  > |
|  > |  - Ben
|  > |
|  > |
|  > |
|  > |  [1]
|  > |
|  > | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
|  > | tlab.h
|  > |  askell.org%2Fbgamari%2Fgitlab-
|  > |
|  > | migration%2Fissues&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C48ce
|  > | 7f7334
|  > |
|  > | c04a54549508d6a5a0cb40%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C
|  > | 636878
|  > |
|  > | 507364801779&amp;sdata=DIxKgZy%2B%2BTYq0P%2BEkrxjefMQqUf43ObXi9CLOGo
|  > | 0sk4%3
|  > |  D&amp;reserved=0
|  > _______________________________________________
|  > ghc-devs mailing list
|  > [hidden email]
|  > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.
|  > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&amp;data=02%7C01
|  > %7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988
|  > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=V5Xq
|  > iP3b87PRpJvS5KSxyM6qkpSnM3KMDtrIhdQhwB0%3D&amp;reserved=0
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Matthew Pickering
I wrote !509 in the ticket which then made gitlab display the "Related
Merge Request" bit underneath. I don't know what happens if you
mention a MR in a comment.

On Mon, Mar 11, 2019 at 10:14 AM Simon Peyton Jones
<[hidden email]> wrote:

>
> |  > * Back on the tickets front, how do I record the test cases(s) for a
> |  ticket?
> |
> |  I don't believe there is a way other than via the commit referencing the
> |  ticket.
>
> That's sad. It's a useful discipline to fill in that field before closing the ticket.  And it's useful later when looking for the test cases for the ticket.
>
> Is this just a straight loss, or is there a longer term plan to recover it?  Do we need a self-imposed discipline, e.g. to ALWAYS add a comment that lists the test cases (and does nothing else) before closing an issue?
>
> |  > * How do I record the MR for a ticket?  (When it has one.)
> |
> |  When you mention a ticket in a MR then a reference should be created from
> |  it to the ticket.
> |
> |  For example, when I mentioned !509 on this ticket it now displays in the
> |  UI.
>
> I don't get it.  You manually added "Corresponding MR !509" to the issue Description.  Or are you saying that that apparently-user-written line was added by GitLab? If you have many MRs taht mention (perhaps en passant) the same issue, will there be many such lines?
>
> Or is it another discipline we could impose on ourselves?
>
> Simon
>
> |  -----Original Message-----
> |  From: Matthew Pickering <[hidden email]>
> |  Sent: 11 March 2019 09:37
> |  To: Simon Peyton Jones <[hidden email]>
> |  Cc: Ben Gamari <[hidden email]>; GHC developers <[hidden email]>
> |  Subject: Re: Trac to GitLab migration underway
> |
> |  > * That the old ticket repo be put in read-only mode.  I've just modified
> |  the old #16344, but I should have modified the new one.
> |
> |  That is tracked
> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
> |  askell.org%2Fbgamari%2Fgitlab-
> |  migration%2Fissues%2F14&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356
> |  d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6
> |  36878938597242017&amp;sdata=XnY%2Fo62mCkz849XKLKe8V3stFe8sorBQkqI9%2FY%2By
> |  CdI%3D&amp;reserved=0
> |
> |  It seems that there are still some problems to iron out though.
> |
> |  > * Back on the tickets front, how do I record the test cases(s) for a
> |  ticket?
> |
> |  I don't believe there is a way other than via the commit referencing the
> |  ticket.
> |
> |  >
> |  > * How do I record the MR for a ticket?  (When it has one.)
> |
> |  When you mention a ticket in a MR then a reference should be created from
> |  it to the ticket.
> |
> |  For example, when I mentioned !509 on this ticket it now displays in the
> |  UI.
> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
> |  askell.org%2Fghc%2Fghc%2Fissues%2F16417&amp;data=02%7C01%7Csimonpj%40micro
> |  soft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011
> |  db47%7C1%7C0%7C636878938597242017&amp;sdata=s5%2FfsXsx5t%2FuRIeq6AJZU5sr8P
> |  FJpNt6nkr%2BObzRAmk%3D&amp;reserved=0
> |
> |  >
> |  > * That the banner (on the wiki at least) saying "This site has been
> |  deprecated and is in read-only mode" should describe how to get to the
> |  corresponding URL on the new wiki. Eg. say "If you are trying to access
> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
> |  ell.org%2Ftrac%2Fghc%2Fwiki%2F&amp;data=02%7C01%7Csimonpj%40microsoft.com%
> |  7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%
> |  7C0%7C636878938597242017&amp;sdata=vq0ZCkxOmaQp4vB3WPzc%2BovCn1oSSak5K6CYM
> |  1UyIq4%3D&amp;reserved=0<page>, the new URL is
> |  "https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
> |  haskell.org%2Fghc%2Fghc%2Fwikis%2F&amp;data=02%7C01%7Csimonpj%40microsoft.
> |  com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%
> |  7C1%7C0%7C636878938597242017&amp;sdata=ZbZf%2BlVa1rqrngh82QrJAIRmDFaGMp0Gb
> |  BUo5ABhqVo%3D&amp;reserved=0<page>".
> |  >
> |  > * Where has
> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
> |  ell.org%2Ftrac%2Fghc%2Fwiki%2FRichardAndSimon&amp;data=02%7C01%7Csimonpj%4
> |  0microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d
> |  7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=xkERHLEyWh8yWLxRS2GUZ4iu
> |  Yk0DjFBxuKFkQbnyUeI%3D&amp;reserved=0 gone?  The corresponding URL on the
> |  new wiki doesn't exist.
> |
> |  The page is now located at:
> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
> |  askell.org%2Fghc%2Fghc%2Fwikis%2Frichard-and-
> |  simon&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d
> |  6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&
> |  amp;sdata=X%2BOPbJn4zTiGNkH%2Ba5TVoge6dxZmGw0WSxrnxEpk0og%3D&amp;reserved=
> |  0
> |
> |  >
> |  > * How can I list the title index on the new wiki?
> |
> |  An automatically generated index is available here
> |
> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
> |  askell.org%2Fghc%2Fghc%2Fwikis%2Findex&amp;data=02%7C01%7Csimonpj%40micros
> |  oft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011d
> |  b47%7C1%7C0%7C636878938597242017&amp;sdata=BZ337ak7obJlIGW4GK5R4FOl1uCCH2T
> |  D4DGorbNyz28%3D&amp;reserved=0
> |
> |  I believe the intention is to automatically update this with a cronjob.
> |
> |  >
> |  > * I have lots of pages like this one
> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
> |  askell.org%2Fghc%2Fghc%2Fwikis%2Fproposal%2Fcustom-type-
> |  errors&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008
> |  d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017
> |  &amp;sdata=sueCHGV9aE36gaIqUgxBq1VZl4zOKhCYDOWwsnSgAss%3D&amp;reserved=0
> |  that list the tickets relevant to a particular keyword.  (Now "label" I
> |  think?)   But tat page is now lying: it claims to list current open
> |  tickets, but actually it's a frozen snapshot.  What should I do?
> |
> |  Gitlab Wiki does not support this feature so you have to refer to a custom
> |  search.
> |
> |  For example:
> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
> |  askell.org%2Fghc%2Fghc%2Fissues%3Flabel_name%255B%255D%3DApplicativeDo&amp
> |  ;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319
> |  %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata
> |  =DM%2B9ZPFxUhJW%2B2EokkOJzXF6Ca6PlSgQf1TGsCt36Wc%3D&amp;reserved=0
> |
> |  However, it seems that the `CustomTypeErrors` label was lost during the
> |  migration. Do you know why this is Tobias/Ben? It looks like it will have
> |  to be added back manually.
> |
> |  >
> |  > Thanks
> |  >
> |  > Simon
> |  >
> |  > |  I'm happy to announce that the ticket and issue import processes
> |  > | are now  complete and gitlab.haskell.org is back online. There are
> |  > | still a few  final steps remaining which I will be carrying out over
> |  > | the next few
> |  > |  days:
> |  > |
> |  > |   * Put in place redirect logic for Trac ticket and Wiki URLs
> |  > |
> |  > |   * Add issue comments showing commit messages, replicating the
> |  previous
> |  > |     Trac behavior
> |  > |
> |  > |   * Migrate the GHC Blog entries
> |  > |
> |  > |   * Make the old Trac instance again accessible in read-only mode
> |  > |
> |  > |  However, while I do this you should feel free to use
> |  > | gitlab.haskell.org  freely.
> |  > |  If you notice any issues with the import feel free to open a ticket
> |  > | here  [1].
> |  > |
> |  > |  Cheers,
> |  > |
> |  > |  - Ben
> |  > |
> |  > |
> |  > |
> |  > |  [1]
> |  > |
> |  > | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
> |  > | tlab.h
> |  > |  askell.org%2Fbgamari%2Fgitlab-
> |  > |
> |  > | migration%2Fissues&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C48ce
> |  > | 7f7334
> |  > |
> |  > | c04a54549508d6a5a0cb40%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C
> |  > | 636878
> |  > |
> |  > | 507364801779&amp;sdata=DIxKgZy%2B%2BTYq0P%2BEkrxjefMQqUf43ObXi9CLOGo
> |  > | 0sk4%3
> |  > |  D&amp;reserved=0
> |  > _______________________________________________
> |  > ghc-devs mailing list
> |  > [hidden email]
> |  > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.
> |  > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&amp;data=02%7C01
> |  > %7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988
> |  > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=V5Xq
> |  > iP3b87PRpJvS5KSxyM6qkpSnM3KMDtrIhdQhwB0%3D&amp;reserved=0
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Richard Eisenberg-4
Thanks to all who have made this happen. Looking forward to having everything in one place!

Do we have any ability to edit the formatting of subject lines of ticket emails? It would be great if we could get the (!234) or (#12345) up front, as this is the effective summary of what's to follow.

I'd also like to second Simon's request, in particular, of having a clear path from an issue to an MR. Getting from an MR to an issue is normally easier -- when the MR is created, most devs would automatically mention the issue number somewhere in the description -- but going from an issue to an MR is harder. It would be a shame to have to search through the commentary looking for the link. I used the old "Phab:D1234" links in the top of a Trac ticket quite often.

I also second the request for a test-case field. This field, to me, is most useful as a reminder to the author that they need to add a test case. But I think the issue-to-MR link is more important than the test-case field.

Thanks!
Richard

> On Mar 11, 2019, at 6:17 AM, Matthew Pickering <[hidden email]> wrote:
>
> I wrote !509 in the ticket which then made gitlab display the "Related
> Merge Request" bit underneath. I don't know what happens if you
> mention a MR in a comment.
>
> On Mon, Mar 11, 2019 at 10:14 AM Simon Peyton Jones
> <[hidden email]> wrote:
>>
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>>
>> That's sad. It's a useful discipline to fill in that field before closing the ticket.  And it's useful later when looking for the test cases for the ticket.
>>
>> Is this just a straight loss, or is there a longer term plan to recover it?  Do we need a self-imposed discipline, e.g. to ALWAYS add a comment that lists the test cases (and does nothing else) before closing an issue?
>>
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>>
>> I don't get it.  You manually added "Corresponding MR !509" to the issue Description.  Or are you saying that that apparently-user-written line was added by GitLab? If you have many MRs taht mention (perhaps en passant) the same issue, will there be many such lines?
>>
>> Or is it another discipline we could impose on ourselves?
>>
>> Simon
>>
>> |  -----Original Message-----
>> |  From: Matthew Pickering <[hidden email]>
>> |  Sent: 11 March 2019 09:37
>> |  To: Simon Peyton Jones <[hidden email]>
>> |  Cc: Ben Gamari <[hidden email]>; GHC developers <[hidden email]>
>> |  Subject: Re: Trac to GitLab migration underway
>> |
>> |  > * That the old ticket repo be put in read-only mode.  I've just modified
>> |  the old #16344, but I should have modified the new one.
>> |
>> |  That is tracked
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fbgamari%2Fgitlab-
>> |  migration%2Fissues%2F14&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356
>> |  d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6
>> |  36878938597242017&amp;sdata=XnY%2Fo62mCkz849XKLKe8V3stFe8sorBQkqI9%2FY%2By
>> |  CdI%3D&amp;reserved=0
>> |
>> |  It seems that there are still some problems to iron out though.
>> |
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>> |
>> |  >
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%2F16417&amp;data=02%7C01%7Csimonpj%40micro
>> |  soft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011
>> |  db47%7C1%7C0%7C636878938597242017&amp;sdata=s5%2FfsXsx5t%2FuRIeq6AJZU5sr8P
>> |  FJpNt6nkr%2BObzRAmk%3D&amp;reserved=0
>> |
>> |  >
>> |  > * That the banner (on the wiki at least) saying "This site has been
>> |  deprecated and is in read-only mode" should describe how to get to the
>> |  corresponding URL on the new wiki. Eg. say "If you are trying to access
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2F&amp;data=02%7C01%7Csimonpj%40microsoft.com%
>> |  7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%
>> |  7C0%7C636878938597242017&amp;sdata=vq0ZCkxOmaQp4vB3WPzc%2BovCn1oSSak5K6CYM
>> |  1UyIq4%3D&amp;reserved=0<page>, the new URL is
>> |  "https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
>> |  haskell.org%2Fghc%2Fghc%2Fwikis%2F&amp;data=02%7C01%7Csimonpj%40microsoft.
>> |  com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%
>> |  7C1%7C0%7C636878938597242017&amp;sdata=ZbZf%2BlVa1rqrngh82QrJAIRmDFaGMp0Gb
>> |  BUo5ABhqVo%3D&amp;reserved=0<page>".
>> |  >
>> |  > * Where has
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2FRichardAndSimon&amp;data=02%7C01%7Csimonpj%4
>> |  0microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d
>> |  7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=xkERHLEyWh8yWLxRS2GUZ4iu
>> |  Yk0DjFBxuKFkQbnyUeI%3D&amp;reserved=0 gone?  The corresponding URL on the
>> |  new wiki doesn't exist.
>> |
>> |  The page is now located at:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Frichard-and-
>> |  simon&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d
>> |  6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&
>> |  amp;sdata=X%2BOPbJn4zTiGNkH%2Ba5TVoge6dxZmGw0WSxrnxEpk0og%3D&amp;reserved=
>> |  0
>> |
>> |  >
>> |  > * How can I list the title index on the new wiki?
>> |
>> |  An automatically generated index is available here
>> |
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Findex&amp;data=02%7C01%7Csimonpj%40micros
>> |  oft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011d
>> |  b47%7C1%7C0%7C636878938597242017&amp;sdata=BZ337ak7obJlIGW4GK5R4FOl1uCCH2T
>> |  D4DGorbNyz28%3D&amp;reserved=0
>> |
>> |  I believe the intention is to automatically update this with a cronjob.
>> |
>> |  >
>> |  > * I have lots of pages like this one
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Fproposal%2Fcustom-type-
>> |  errors&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008
>> |  d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017
>> |  &amp;sdata=sueCHGV9aE36gaIqUgxBq1VZl4zOKhCYDOWwsnSgAss%3D&amp;reserved=0
>> |  that list the tickets relevant to a particular keyword.  (Now "label" I
>> |  think?)   But tat page is now lying: it claims to list current open
>> |  tickets, but actually it's a frozen snapshot.  What should I do?
>> |
>> |  Gitlab Wiki does not support this feature so you have to refer to a custom
>> |  search.
>> |
>> |  For example:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%3Flabel_name%255B%255D%3DApplicativeDo&amp
>> |  ;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319
>> |  %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata
>> |  =DM%2B9ZPFxUhJW%2B2EokkOJzXF6Ca6PlSgQf1TGsCt36Wc%3D&amp;reserved=0
>> |
>> |  However, it seems that the `CustomTypeErrors` label was lost during the
>> |  migration. Do you know why this is Tobias/Ben? It looks like it will have
>> |  to be added back manually.
>> |
>> |  >
>> |  > Thanks
>> |  >
>> |  > Simon
>> |  >
>> |  > |  I'm happy to announce that the ticket and issue import processes
>> |  > | are now  complete and gitlab.haskell.org is back online. There are
>> |  > | still a few  final steps remaining which I will be carrying out over
>> |  > | the next few
>> |  > |  days:
>> |  > |
>> |  > |   * Put in place redirect logic for Trac ticket and Wiki URLs
>> |  > |
>> |  > |   * Add issue comments showing commit messages, replicating the
>> |  previous
>> |  > |     Trac behavior
>> |  > |
>> |  > |   * Migrate the GHC Blog entries
>> |  > |
>> |  > |   * Make the old Trac instance again accessible in read-only mode
>> |  > |
>> |  > |  However, while I do this you should feel free to use
>> |  > | gitlab.haskell.org  freely.
>> |  > |  If you notice any issues with the import feel free to open a ticket
>> |  > | here  [1].
>> |  > |
>> |  > |  Cheers,
>> |  > |
>> |  > |  - Ben
>> |  > |
>> |  > |
>> |  > |
>> |  > |  [1]
>> |  > |
>> |  > | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
>> |  > | tlab.h
>> |  > |  askell.org%2Fbgamari%2Fgitlab-
>> |  > |
>> |  > | migration%2Fissues&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C48ce
>> |  > | 7f7334
>> |  > |
>> |  > | c04a54549508d6a5a0cb40%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C
>> |  > | 636878
>> |  > |
>> |  > | 507364801779&amp;sdata=DIxKgZy%2B%2BTYq0P%2BEkrxjefMQqUf43ObXi9CLOGo
>> |  > | 0sk4%3
>> |  > |  D&amp;reserved=0
>> |  > _______________________________________________
>> |  > ghc-devs mailing list
>> |  > [hidden email]
>> |  > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.
>> |  > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&amp;data=02%7C01
>> |  > %7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988
>> |  > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=V5Xq
>> |  > iP3b87PRpJvS5KSxyM6qkpSnM3KMDtrIhdQhwB0%3D&amp;reserved=0
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Artem Pelenitsyn
Hello,

I just wanted to thank Ben and everyone involved for this transition. And also reiterate Richard's point about having !123 / #12345 in the front of mail subjects — I think, this is small but quite important detail to ease navigating the flow of notifications.

--
Best regards,
Artem

On Mon, Mar 11, 2019, 9:13 AM Richard Eisenberg <[hidden email]> wrote:
Thanks to all who have made this happen. Looking forward to having everything in one place!

Do we have any ability to edit the formatting of subject lines of ticket emails? It would be great if we could get the (!234) or (#12345) up front, as this is the effective summary of what's to follow.

I'd also like to second Simon's request, in particular, of having a clear path from an issue to an MR. Getting from an MR to an issue is normally easier -- when the MR is created, most devs would automatically mention the issue number somewhere in the description -- but going from an issue to an MR is harder. It would be a shame to have to search through the commentary looking for the link. I used the old "Phab:D1234" links in the top of a Trac ticket quite often.

I also second the request for a test-case field. This field, to me, is most useful as a reminder to the author that they need to add a test case. But I think the issue-to-MR link is more important than the test-case field.

Thanks!
Richard

> On Mar 11, 2019, at 6:17 AM, Matthew Pickering <[hidden email]> wrote:
>
> I wrote !509 in the ticket which then made gitlab display the "Related
> Merge Request" bit underneath. I don't know what happens if you
> mention a MR in a comment.
>
> On Mon, Mar 11, 2019 at 10:14 AM Simon Peyton Jones
> <[hidden email]> wrote:
>>
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>>
>> That's sad. It's a useful discipline to fill in that field before closing the ticket.  And it's useful later when looking for the test cases for the ticket.
>>
>> Is this just a straight loss, or is there a longer term plan to recover it?  Do we need a self-imposed discipline, e.g. to ALWAYS add a comment that lists the test cases (and does nothing else) before closing an issue?
>>
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>>
>> I don't get it.  You manually added "Corresponding MR !509" to the issue Description.  Or are you saying that that apparently-user-written line was added by GitLab? If you have many MRs taht mention (perhaps en passant) the same issue, will there be many such lines?
>>
>> Or is it another discipline we could impose on ourselves?
>>
>> Simon
>>
>> |  -----Original Message-----
>> |  From: Matthew Pickering <[hidden email]>
>> |  Sent: 11 March 2019 09:37
>> |  To: Simon Peyton Jones <[hidden email]>
>> |  Cc: Ben Gamari <[hidden email]>; GHC developers <[hidden email]>
>> |  Subject: Re: Trac to GitLab migration underway
>> |
>> |  > * That the old ticket repo be put in read-only mode.  I've just modified
>> |  the old #16344, but I should have modified the new one.
>> |
>> |  That is tracked
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fbgamari%2Fgitlab-
>> |  migration%2Fissues%2F14&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356
>> |  d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6
>> |  36878938597242017&amp;sdata=XnY%2Fo62mCkz849XKLKe8V3stFe8sorBQkqI9%2FY%2By
>> |  CdI%3D&amp;reserved=0
>> |
>> |  It seems that there are still some problems to iron out though.
>> |
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>> |
>> |  >
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%2F16417&amp;data=02%7C01%7Csimonpj%40micro
>> |  soft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011
>> |  db47%7C1%7C0%7C636878938597242017&amp;sdata=s5%2FfsXsx5t%2FuRIeq6AJZU5sr8P
>> |  FJpNt6nkr%2BObzRAmk%3D&amp;reserved=0
>> |
>> |  >
>> |  > * That the banner (on the wiki at least) saying "This site has been
>> |  deprecated and is in read-only mode" should describe how to get to the
>> |  corresponding URL on the new wiki. Eg. say "If you are trying to access
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2F&amp;data=02%7C01%7Csimonpj%40microsoft.com%
>> |  7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%
>> |  7C0%7C636878938597242017&amp;sdata=vq0ZCkxOmaQp4vB3WPzc%2BovCn1oSSak5K6CYM
>> |  1UyIq4%3D&amp;reserved=0<page>, the new URL is
>> |  "https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
>> |  haskell.org%2Fghc%2Fghc%2Fwikis%2F&amp;data=02%7C01%7Csimonpj%40microsoft.
>> |  com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%
>> |  7C1%7C0%7C636878938597242017&amp;sdata=ZbZf%2BlVa1rqrngh82QrJAIRmDFaGMp0Gb
>> |  BUo5ABhqVo%3D&amp;reserved=0<page>".
>> |  >
>> |  > * Where has
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2FRichardAndSimon&amp;data=02%7C01%7Csimonpj%4
>> |  0microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d
>> |  7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=xkERHLEyWh8yWLxRS2GUZ4iu
>> |  Yk0DjFBxuKFkQbnyUeI%3D&amp;reserved=0 gone?  The corresponding URL on the
>> |  new wiki doesn't exist.
>> |
>> |  The page is now located at:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Frichard-and-
>> |  simon&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d
>> |  6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&
>> |  amp;sdata=X%2BOPbJn4zTiGNkH%2Ba5TVoge6dxZmGw0WSxrnxEpk0og%3D&amp;reserved=
>> |  0
>> |
>> |  >
>> |  > * How can I list the title index on the new wiki?
>> |
>> |  An automatically generated index is available here
>> |
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Findex&amp;data=02%7C01%7Csimonpj%40micros
>> |  oft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011d
>> |  b47%7C1%7C0%7C636878938597242017&amp;sdata=BZ337ak7obJlIGW4GK5R4FOl1uCCH2T
>> |  D4DGorbNyz28%3D&amp;reserved=0
>> |
>> |  I believe the intention is to automatically update this with a cronjob.
>> |
>> |  >
>> |  > * I have lots of pages like this one
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Fproposal%2Fcustom-type-
>> |  errors&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008
>> |  d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017
>> |  &amp;sdata=sueCHGV9aE36gaIqUgxBq1VZl4zOKhCYDOWwsnSgAss%3D&amp;reserved=0
>> |  that list the tickets relevant to a particular keyword.  (Now "label" I
>> |  think?)   But tat page is now lying: it claims to list current open
>> |  tickets, but actually it's a frozen snapshot.  What should I do?
>> |
>> |  Gitlab Wiki does not support this feature so you have to refer to a custom
>> |  search.
>> |
>> |  For example:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%3Flabel_name%255B%255D%3DApplicativeDo&amp
>> |  ;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319
>> |  %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata
>> |  =DM%2B9ZPFxUhJW%2B2EokkOJzXF6Ca6PlSgQf1TGsCt36Wc%3D&amp;reserved=0
>> |
>> |  However, it seems that the `CustomTypeErrors` label was lost during the
>> |  migration. Do you know why this is Tobias/Ben? It looks like it will have
>> |  to be added back manually.
>> |
>> |  >
>> |  > Thanks
>> |  >
>> |  > Simon
>> |  >
>> |  > |  I'm happy to announce that the ticket and issue import processes
>> |  > | are now  complete and gitlab.haskell.org is back online. There are
>> |  > | still a few  final steps remaining which I will be carrying out over
>> |  > | the next few
>> |  > |  days:
>> |  > |
>> |  > |   * Put in place redirect logic for Trac ticket and Wiki URLs
>> |  > |
>> |  > |   * Add issue comments showing commit messages, replicating the
>> |  previous
>> |  > |     Trac behavior
>> |  > |
>> |  > |   * Migrate the GHC Blog entries
>> |  > |
>> |  > |   * Make the old Trac instance again accessible in read-only mode
>> |  > |
>> |  > |  However, while I do this you should feel free to use
>> |  > | gitlab.haskell.org  freely.
>> |  > |  If you notice any issues with the import feel free to open a ticket
>> |  > | here  [1].
>> |  > |
>> |  > |  Cheers,
>> |  > |
>> |  > |  - Ben
>> |  > |
>> |  > |
>> |  > |
>> |  > |  [1]
>> |  > |
>> |  > | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
>> |  > | tlab.h
>> |  > |  askell.org%2Fbgamari%2Fgitlab-
>> |  > |
>> |  > | migration%2Fissues&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C48ce
>> |  > | 7f7334
>> |  > |
>> |  > | c04a54549508d6a5a0cb40%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C
>> |  > | 636878
>> |  > |
>> |  > | 507364801779&amp;sdata=DIxKgZy%2B%2BTYq0P%2BEkrxjefMQqUf43ObXi9CLOGo
>> |  > | 0sk4%3
>> |  > |  D&amp;reserved=0
>> |  > _______________________________________________
>> |  > ghc-devs mailing list
>> |  > [hidden email]
>> |  > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.
>> |  > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&amp;data=02%7C01
>> |  > %7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988
>> |  > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=V5Xq
>> |  > iP3b87PRpJvS5KSxyM6qkpSnM3KMDtrIhdQhwB0%3D&amp;reserved=0
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Richard Eisenberg-4
This old ticket might be related: https://gitlab.com/gitlab-org/gitlab-ce/issues/1734   It advocates for moving numbers to the front of tab names, too. Looks like it was shut down by judgment call. Perhaps if we raise our voices in chorus against this decision, we can get some action (or a new configuration switch).

On Mar 11, 2019, at 10:25 AM, Artem Pelenitsyn <[hidden email]> wrote:

Hello,

I just wanted to thank Ben and everyone involved for this transition. And also reiterate Richard's point about having !123 / #12345 in the front of mail subjects — I think, this is small but quite important detail to ease navigating the flow of notifications.

--
Best regards,
Artem

On Mon, Mar 11, 2019, 9:13 AM Richard Eisenberg <[hidden email]> wrote:
Thanks to all who have made this happen. Looking forward to having everything in one place!

Do we have any ability to edit the formatting of subject lines of ticket emails? It would be great if we could get the (!234) or (#12345) up front, as this is the effective summary of what's to follow.

I'd also like to second Simon's request, in particular, of having a clear path from an issue to an MR. Getting from an MR to an issue is normally easier -- when the MR is created, most devs would automatically mention the issue number somewhere in the description -- but going from an issue to an MR is harder. It would be a shame to have to search through the commentary looking for the link. I used the old "Phab:D1234" links in the top of a Trac ticket quite often.

I also second the request for a test-case field. This field, to me, is most useful as a reminder to the author that they need to add a test case. But I think the issue-to-MR link is more important than the test-case field.

Thanks!
Richard

> On Mar 11, 2019, at 6:17 AM, Matthew Pickering <[hidden email]> wrote:
>
> I wrote !509 in the ticket which then made gitlab display the "Related
> Merge Request" bit underneath. I don't know what happens if you
> mention a MR in a comment.
>
> On Mon, Mar 11, 2019 at 10:14 AM Simon Peyton Jones
> <[hidden email]> wrote:
>>
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>>
>> That's sad. It's a useful discipline to fill in that field before closing the ticket.  And it's useful later when looking for the test cases for the ticket.
>>
>> Is this just a straight loss, or is there a longer term plan to recover it?  Do we need a self-imposed discipline, e.g. to ALWAYS add a comment that lists the test cases (and does nothing else) before closing an issue?
>>
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>>
>> I don't get it.  You manually added "Corresponding MR !509" to the issue Description.  Or are you saying that that apparently-user-written line was added by GitLab? If you have many MRs taht mention (perhaps en passant) the same issue, will there be many such lines?
>>
>> Or is it another discipline we could impose on ourselves?
>>
>> Simon
>>
>> |  -----Original Message-----
>> |  From: Matthew Pickering <[hidden email]>
>> |  Sent: 11 March 2019 09:37
>> |  To: Simon Peyton Jones <[hidden email]>
>> |  Cc: Ben Gamari <[hidden email]>; GHC developers <[hidden email]>
>> |  Subject: Re: Trac to GitLab migration underway
>> |
>> |  > * That the old ticket repo be put in read-only mode.  I've just modified
>> |  the old #16344, but I should have modified the new one.
>> |
>> |  That is tracked
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fbgamari%2Fgitlab-
>> |  migration%2Fissues%2F14&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356
>> |  d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6
>> |  36878938597242017&amp;sdata=XnY%2Fo62mCkz849XKLKe8V3stFe8sorBQkqI9%2FY%2By
>> |  CdI%3D&amp;reserved=0
>> |
>> |  It seems that there are still some problems to iron out though.
>> |
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>> |
>> |  >
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%2F16417&amp;data=02%7C01%7Csimonpj%40micro
>> |  soft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011
>> |  db47%7C1%7C0%7C636878938597242017&amp;sdata=s5%2FfsXsx5t%2FuRIeq6AJZU5sr8P
>> |  FJpNt6nkr%2BObzRAmk%3D&amp;reserved=0
>> |
>> |  >
>> |  > * That the banner (on the wiki at least) saying "This site has been
>> |  deprecated and is in read-only mode" should describe how to get to the
>> |  corresponding URL on the new wiki. Eg. say "If you are trying to access
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2F&amp;data=02%7C01%7Csimonpj%40microsoft.com%
>> |  7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%
>> |  7C0%7C636878938597242017&amp;sdata=vq0ZCkxOmaQp4vB3WPzc%2BovCn1oSSak5K6CYM
>> |  1UyIq4%3D&amp;reserved=0<page>, the new URL is
>> |  "https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
>> |  haskell.org%2Fghc%2Fghc%2Fwikis%2F&amp;data=02%7C01%7Csimonpj%40microsoft.
>> |  com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%
>> |  7C1%7C0%7C636878938597242017&amp;sdata=ZbZf%2BlVa1rqrngh82QrJAIRmDFaGMp0Gb
>> |  BUo5ABhqVo%3D&amp;reserved=0<page>".
>> |  >
>> |  > * Where has
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2FRichardAndSimon&amp;data=02%7C01%7Csimonpj%4
>> |  0microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d
>> |  7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=xkERHLEyWh8yWLxRS2GUZ4iu
>> |  Yk0DjFBxuKFkQbnyUeI%3D&amp;reserved=0 gone?  The corresponding URL on the
>> |  new wiki doesn't exist.
>> |
>> |  The page is now located at:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Frichard-and-
>> |  simon&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d
>> |  6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&
>> |  amp;sdata=X%2BOPbJn4zTiGNkH%2Ba5TVoge6dxZmGw0WSxrnxEpk0og%3D&amp;reserved=
>> |  0
>> |
>> |  >
>> |  > * How can I list the title index on the new wiki?
>> |
>> |  An automatically generated index is available here
>> |
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Findex&amp;data=02%7C01%7Csimonpj%40micros
>> |  oft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011d
>> |  b47%7C1%7C0%7C636878938597242017&amp;sdata=BZ337ak7obJlIGW4GK5R4FOl1uCCH2T
>> |  D4DGorbNyz28%3D&amp;reserved=0
>> |
>> |  I believe the intention is to automatically update this with a cronjob.
>> |
>> |  >
>> |  > * I have lots of pages like this one
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Fproposal%2Fcustom-type-
>> |  errors&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008
>> |  d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017
>> |  &amp;sdata=sueCHGV9aE36gaIqUgxBq1VZl4zOKhCYDOWwsnSgAss%3D&amp;reserved=0
>> |  that list the tickets relevant to a particular keyword.  (Now "label" I
>> |  think?)   But tat page is now lying: it claims to list current open
>> |  tickets, but actually it's a frozen snapshot.  What should I do?
>> |
>> |  Gitlab Wiki does not support this feature so you have to refer to a custom
>> |  search.
>> |
>> |  For example:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%3Flabel_name%255B%255D%3DApplicativeDo&amp
>> |  ;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319
>> |  %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata
>> |  =DM%2B9ZPFxUhJW%2B2EokkOJzXF6Ca6PlSgQf1TGsCt36Wc%3D&amp;reserved=0
>> |
>> |  However, it seems that the `CustomTypeErrors` label was lost during the
>> |  migration. Do you know why this is Tobias/Ben? It looks like it will have
>> |  to be added back manually.
>> |
>> |  >
>> |  > Thanks
>> |  >
>> |  > Simon
>> |  >
>> |  > |  I'm happy to announce that the ticket and issue import processes
>> |  > | are now  complete and gitlab.haskell.org is back online. There are
>> |  > | still a few  final steps remaining which I will be carrying out over
>> |  > | the next few
>> |  > |  days:
>> |  > |
>> |  > |   * Put in place redirect logic for Trac ticket and Wiki URLs
>> |  > |
>> |  > |   * Add issue comments showing commit messages, replicating the
>> |  previous
>> |  > |     Trac behavior
>> |  > |
>> |  > |   * Migrate the GHC Blog entries
>> |  > |
>> |  > |   * Make the old Trac instance again accessible in read-only mode
>> |  > |
>> |  > |  However, while I do this you should feel free to use
>> |  > | gitlab.haskell.org  freely.
>> |  > |  If you notice any issues with the import feel free to open a ticket
>> |  > | here  [1].
>> |  > |
>> |  > |  Cheers,
>> |  > |
>> |  > |  - Ben
>> |  > |
>> |  > |
>> |  > |
>> |  > |  [1]
>> |  > |
>> |  > | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
>> |  > | tlab.h
>> |  > |  askell.org%2Fbgamari%2Fgitlab-
>> |  > |
>> |  > | migration%2Fissues&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C48ce
>> |  > | 7f7334
>> |  > |
>> |  > | c04a54549508d6a5a0cb40%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C
>> |  > | 636878
>> |  > |
>> |  > | 507364801779&amp;sdata=DIxKgZy%2B%2BTYq0P%2BEkrxjefMQqUf43ObXi9CLOGo
>> |  > | 0sk4%3
>> |  > |  D&amp;reserved=0
>> |  > _______________________________________________
>> |  > ghc-devs mailing list
>> |  > [hidden email]
>> |  > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.
>> |  > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&amp;data=02%7C01
>> |  > %7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988
>> |  > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=V5Xq
>> |  > iP3b87PRpJvS5KSxyM6qkpSnM3KMDtrIhdQhwB0%3D&amp;reserved=0
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Artem Pelenitsyn
Hi Richard,

Good catch! What troubles me in that issue, is (subjectively) the passive-aggressive form of the initial post. Given that it is email that we are worrying about, not the browser tabs, maybe it is better to start over with a new issue referencing that one in passing.

--
Best, Artem

On Mon, 11 Mar 2019 at 11:56 Richard Eisenberg <[hidden email]> wrote:
This old ticket might be related: https://gitlab.com/gitlab-org/gitlab-ce/issues/1734   It advocates for moving numbers to the front of tab names, too. Looks like it was shut down by judgment call. Perhaps if we raise our voices in chorus against this decision, we can get some action (or a new configuration switch).

On Mar 11, 2019, at 10:25 AM, Artem Pelenitsyn <[hidden email]> wrote:

Hello,

I just wanted to thank Ben and everyone involved for this transition. And also reiterate Richard's point about having !123 / #12345 in the front of mail subjects — I think, this is small but quite important detail to ease navigating the flow of notifications.

--
Best regards,
Artem

On Mon, Mar 11, 2019, 9:13 AM Richard Eisenberg <[hidden email]> wrote:
Thanks to all who have made this happen. Looking forward to having everything in one place!

Do we have any ability to edit the formatting of subject lines of ticket emails? It would be great if we could get the (!234) or (#12345) up front, as this is the effective summary of what's to follow.

I'd also like to second Simon's request, in particular, of having a clear path from an issue to an MR. Getting from an MR to an issue is normally easier -- when the MR is created, most devs would automatically mention the issue number somewhere in the description -- but going from an issue to an MR is harder. It would be a shame to have to search through the commentary looking for the link. I used the old "Phab:D1234" links in the top of a Trac ticket quite often.

I also second the request for a test-case field. This field, to me, is most useful as a reminder to the author that they need to add a test case. But I think the issue-to-MR link is more important than the test-case field.

Thanks!
Richard

> On Mar 11, 2019, at 6:17 AM, Matthew Pickering <[hidden email]> wrote:
>
> I wrote !509 in the ticket which then made gitlab display the "Related
> Merge Request" bit underneath. I don't know what happens if you
> mention a MR in a comment.
>
> On Mon, Mar 11, 2019 at 10:14 AM Simon Peyton Jones
> <[hidden email]> wrote:
>>
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>>
>> That's sad. It's a useful discipline to fill in that field before closing the ticket.  And it's useful later when looking for the test cases for the ticket.
>>
>> Is this just a straight loss, or is there a longer term plan to recover it?  Do we need a self-imposed discipline, e.g. to ALWAYS add a comment that lists the test cases (and does nothing else) before closing an issue?
>>
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>>
>> I don't get it.  You manually added "Corresponding MR !509" to the issue Description.  Or are you saying that that apparently-user-written line was added by GitLab? If you have many MRs taht mention (perhaps en passant) the same issue, will there be many such lines?
>>
>> Or is it another discipline we could impose on ourselves?
>>
>> Simon
>>
>> |  -----Original Message-----
>> |  From: Matthew Pickering <[hidden email]>
>> |  Sent: 11 March 2019 09:37
>> |  To: Simon Peyton Jones <[hidden email]>
>> |  Cc: Ben Gamari <[hidden email]>; GHC developers <[hidden email]>
>> |  Subject: Re: Trac to GitLab migration underway
>> |
>> |  > * That the old ticket repo be put in read-only mode.  I've just modified
>> |  the old #16344, but I should have modified the new one.
>> |
>> |  That is tracked
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fbgamari%2Fgitlab-
>> |  migration%2Fissues%2F14&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356
>> |  d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6
>> |  36878938597242017&amp;sdata=XnY%2Fo62mCkz849XKLKe8V3stFe8sorBQkqI9%2FY%2By
>> |  CdI%3D&amp;reserved=0
>> |
>> |  It seems that there are still some problems to iron out though.
>> |
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>> |
>> |  >
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%2F16417&amp;data=02%7C01%7Csimonpj%40micro
>> |  soft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011
>> |  db47%7C1%7C0%7C636878938597242017&amp;sdata=s5%2FfsXsx5t%2FuRIeq6AJZU5sr8P
>> |  FJpNt6nkr%2BObzRAmk%3D&amp;reserved=0
>> |
>> |  >
>> |  > * That the banner (on the wiki at least) saying "This site has been
>> |  deprecated and is in read-only mode" should describe how to get to the
>> |  corresponding URL on the new wiki. Eg. say "If you are trying to access
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2F&amp;data=02%7C01%7Csimonpj%40microsoft.com%
>> |  7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%
>> |  7C0%7C636878938597242017&amp;sdata=vq0ZCkxOmaQp4vB3WPzc%2BovCn1oSSak5K6CYM
>> |  1UyIq4%3D&amp;reserved=0<page>, the new URL is
>> |  "https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
>> |  haskell.org%2Fghc%2Fghc%2Fwikis%2F&amp;data=02%7C01%7Csimonpj%40microsoft.
>> |  com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%
>> |  7C1%7C0%7C636878938597242017&amp;sdata=ZbZf%2BlVa1rqrngh82QrJAIRmDFaGMp0Gb
>> |  BUo5ABhqVo%3D&amp;reserved=0<page>".
>> |  >
>> |  > * Where has
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2FRichardAndSimon&amp;data=02%7C01%7Csimonpj%4
>> |  0microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d
>> |  7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=xkERHLEyWh8yWLxRS2GUZ4iu
>> |  Yk0DjFBxuKFkQbnyUeI%3D&amp;reserved=0 gone?  The corresponding URL on the
>> |  new wiki doesn't exist.
>> |
>> |  The page is now located at:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Frichard-and-
>> |  simon&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d
>> |  6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&
>> |  amp;sdata=X%2BOPbJn4zTiGNkH%2Ba5TVoge6dxZmGw0WSxrnxEpk0og%3D&amp;reserved=
>> |  0
>> |
>> |  >
>> |  > * How can I list the title index on the new wiki?
>> |
>> |  An automatically generated index is available here
>> |
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Findex&amp;data=02%7C01%7Csimonpj%40micros
>> |  oft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011d
>> |  b47%7C1%7C0%7C636878938597242017&amp;sdata=BZ337ak7obJlIGW4GK5R4FOl1uCCH2T
>> |  D4DGorbNyz28%3D&amp;reserved=0
>> |
>> |  I believe the intention is to automatically update this with a cronjob.
>> |
>> |  >
>> |  > * I have lots of pages like this one
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Fproposal%2Fcustom-type-
>> |  errors&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008
>> |  d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017
>> |  &amp;sdata=sueCHGV9aE36gaIqUgxBq1VZl4zOKhCYDOWwsnSgAss%3D&amp;reserved=0
>> |  that list the tickets relevant to a particular keyword.  (Now "label" I
>> |  think?)   But tat page is now lying: it claims to list current open
>> |  tickets, but actually it's a frozen snapshot.  What should I do?
>> |
>> |  Gitlab Wiki does not support this feature so you have to refer to a custom
>> |  search.
>> |
>> |  For example:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%3Flabel_name%255B%255D%3DApplicativeDo&amp
>> |  ;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319
>> |  %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata
>> |  =DM%2B9ZPFxUhJW%2B2EokkOJzXF6Ca6PlSgQf1TGsCt36Wc%3D&amp;reserved=0
>> |
>> |  However, it seems that the `CustomTypeErrors` label was lost during the
>> |  migration. Do you know why this is Tobias/Ben? It looks like it will have
>> |  to be added back manually.
>> |
>> |  >
>> |  > Thanks
>> |  >
>> |  > Simon
>> |  >
>> |  > |  I'm happy to announce that the ticket and issue import processes
>> |  > | are now  complete and gitlab.haskell.org is back online. There are
>> |  > | still a few  final steps remaining which I will be carrying out over
>> |  > | the next few
>> |  > |  days:
>> |  > |
>> |  > |   * Put in place redirect logic for Trac ticket and Wiki URLs
>> |  > |
>> |  > |   * Add issue comments showing commit messages, replicating the
>> |  previous
>> |  > |     Trac behavior
>> |  > |
>> |  > |   * Migrate the GHC Blog entries
>> |  > |
>> |  > |   * Make the old Trac instance again accessible in read-only mode
>> |  > |
>> |  > |  However, while I do this you should feel free to use
>> |  > | gitlab.haskell.org  freely.
>> |  > |  If you notice any issues with the import feel free to open a ticket
>> |  > | here  [1].
>> |  > |
>> |  > |  Cheers,
>> |  > |
>> |  > |  - Ben
>> |  > |
>> |  > |
>> |  > |
>> |  > |  [1]
>> |  > |
>> |  > | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
>> |  > | tlab.h
>> |  > |  askell.org%2Fbgamari%2Fgitlab-
>> |  > |
>> |  > | migration%2Fissues&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C48ce
>> |  > | 7f7334
>> |  > |
>> |  > | c04a54549508d6a5a0cb40%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C
>> |  > | 636878
>> |  > |
>> |  > | 507364801779&amp;sdata=DIxKgZy%2B%2BTYq0P%2BEkrxjefMQqUf43ObXi9CLOGo
>> |  > | 0sk4%3
>> |  > |  D&amp;reserved=0
>> |  > _______________________________________________
>> |  > ghc-devs mailing list
>> |  > [hidden email]
>> |  > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.
>> |  > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&amp;data=02%7C01
>> |  > %7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988
>> |  > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=V5Xq
>> |  > iP3b87PRpJvS5KSxyM6qkpSnM3KMDtrIhdQhwB0%3D&amp;reserved=0
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Richard Eisenberg-5
Good point -- I hadn't noticed the unfortunate phrasing of the original post.

You're right that the current focus is on email, but the tabs issue affects me, too. In any case, let's not link to that ticket.

But before I take further action, I know that we have some side channels with GitLab, and I don't want to muddy the waters by working outside of those channels. If I should take further action, please let me know.

Richard

On Mar 11, 2019, at 1:54 PM, Artem Pelenitsyn <[hidden email]> wrote:

Hi Richard,

Good catch! What troubles me in that issue, is (subjectively) the passive-aggressive form of the initial post. Given that it is email that we are worrying about, not the browser tabs, maybe it is better to start over with a new issue referencing that one in passing.

--
Best, Artem

On Mon, 11 Mar 2019 at 11:56 Richard Eisenberg <[hidden email]> wrote:
This old ticket might be related: https://gitlab.com/gitlab-org/gitlab-ce/issues/1734   It advocates for moving numbers to the front of tab names, too. Looks like it was shut down by judgment call. Perhaps if we raise our voices in chorus against this decision, we can get some action (or a new configuration switch).

On Mar 11, 2019, at 10:25 AM, Artem Pelenitsyn <[hidden email]> wrote:

Hello,

I just wanted to thank Ben and everyone involved for this transition. And also reiterate Richard's point about having !123 / #12345 in the front of mail subjects — I think, this is small but quite important detail to ease navigating the flow of notifications.

--
Best regards,
Artem

On Mon, Mar 11, 2019, 9:13 AM Richard Eisenberg <[hidden email]> wrote:
Thanks to all who have made this happen. Looking forward to having everything in one place!

Do we have any ability to edit the formatting of subject lines of ticket emails? It would be great if we could get the (!234) or (#12345) up front, as this is the effective summary of what's to follow.

I'd also like to second Simon's request, in particular, of having a clear path from an issue to an MR. Getting from an MR to an issue is normally easier -- when the MR is created, most devs would automatically mention the issue number somewhere in the description -- but going from an issue to an MR is harder. It would be a shame to have to search through the commentary looking for the link. I used the old "Phab:D1234" links in the top of a Trac ticket quite often.

I also second the request for a test-case field. This field, to me, is most useful as a reminder to the author that they need to add a test case. But I think the issue-to-MR link is more important than the test-case field.

Thanks!
Richard

> On Mar 11, 2019, at 6:17 AM, Matthew Pickering <[hidden email]> wrote:
>
> I wrote !509 in the ticket which then made gitlab display the "Related
> Merge Request" bit underneath. I don't know what happens if you
> mention a MR in a comment.
>
> On Mon, Mar 11, 2019 at 10:14 AM Simon Peyton Jones
> <[hidden email]> wrote:
>>
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>>
>> That's sad. It's a useful discipline to fill in that field before closing the ticket.  And it's useful later when looking for the test cases for the ticket.
>>
>> Is this just a straight loss, or is there a longer term plan to recover it?  Do we need a self-imposed discipline, e.g. to ALWAYS add a comment that lists the test cases (and does nothing else) before closing an issue?
>>
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>>
>> I don't get it.  You manually added "Corresponding MR !509" to the issue Description.  Or are you saying that that apparently-user-written line was added by GitLab? If you have many MRs taht mention (perhaps en passant) the same issue, will there be many such lines?
>>
>> Or is it another discipline we could impose on ourselves?
>>
>> Simon
>>
>> |  -----Original Message-----
>> |  From: Matthew Pickering <[hidden email]>
>> |  Sent: 11 March 2019 09:37
>> |  To: Simon Peyton Jones <[hidden email]>
>> |  Cc: Ben Gamari <[hidden email]>; GHC developers <[hidden email]>
>> |  Subject: Re: Trac to GitLab migration underway
>> |
>> |  > * That the old ticket repo be put in read-only mode.  I've just modified
>> |  the old #16344, but I should have modified the new one.
>> |
>> |  That is tracked
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fbgamari%2Fgitlab-
>> |  migration%2Fissues%2F14&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356
>> |  d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6
>> |  36878938597242017&amp;sdata=XnY%2Fo62mCkz849XKLKe8V3stFe8sorBQkqI9%2FY%2By
>> |  CdI%3D&amp;reserved=0
>> |
>> |  It seems that there are still some problems to iron out though.
>> |
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>> |
>> |  >
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%2F16417&amp;data=02%7C01%7Csimonpj%40micro
>> |  soft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011
>> |  db47%7C1%7C0%7C636878938597242017&amp;sdata=s5%2FfsXsx5t%2FuRIeq6AJZU5sr8P
>> |  FJpNt6nkr%2BObzRAmk%3D&amp;reserved=0
>> |
>> |  >
>> |  > * That the banner (on the wiki at least) saying "This site has been
>> |  deprecated and is in read-only mode" should describe how to get to the
>> |  corresponding URL on the new wiki. Eg. say "If you are trying to access
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2F&amp;data=02%7C01%7Csimonpj%40microsoft.com%
>> |  7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%
>> |  7C0%7C636878938597242017&amp;sdata=vq0ZCkxOmaQp4vB3WPzc%2BovCn1oSSak5K6CYM
>> |  1UyIq4%3D&amp;reserved=0<page>, the new URL is
>> |  "https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
>> |  haskell.org%2Fghc%2Fghc%2Fwikis%2F&amp;data=02%7C01%7Csimonpj%40microsoft.
>> |  com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%
>> |  7C1%7C0%7C636878938597242017&amp;sdata=ZbZf%2BlVa1rqrngh82QrJAIRmDFaGMp0Gb
>> |  BUo5ABhqVo%3D&amp;reserved=0<page>".
>> |  >
>> |  > * Where has
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2FRichardAndSimon&amp;data=02%7C01%7Csimonpj%4
>> |  0microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d
>> |  7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=xkERHLEyWh8yWLxRS2GUZ4iu
>> |  Yk0DjFBxuKFkQbnyUeI%3D&amp;reserved=0 gone?  The corresponding URL on the
>> |  new wiki doesn't exist.
>> |
>> |  The page is now located at:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Frichard-and-
>> |  simon&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d
>> |  6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&
>> |  amp;sdata=X%2BOPbJn4zTiGNkH%2Ba5TVoge6dxZmGw0WSxrnxEpk0og%3D&amp;reserved=
>> |  0
>> |
>> |  >
>> |  > * How can I list the title index on the new wiki?
>> |
>> |  An automatically generated index is available here
>> |
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Findex&amp;data=02%7C01%7Csimonpj%40micros
>> |  oft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011d
>> |  b47%7C1%7C0%7C636878938597242017&amp;sdata=BZ337ak7obJlIGW4GK5R4FOl1uCCH2T
>> |  D4DGorbNyz28%3D&amp;reserved=0
>> |
>> |  I believe the intention is to automatically update this with a cronjob.
>> |
>> |  >
>> |  > * I have lots of pages like this one
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Fproposal%2Fcustom-type-
>> |  errors&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008
>> |  d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017
>> |  &amp;sdata=sueCHGV9aE36gaIqUgxBq1VZl4zOKhCYDOWwsnSgAss%3D&amp;reserved=0
>> |  that list the tickets relevant to a particular keyword.  (Now "label" I
>> |  think?)   But tat page is now lying: it claims to list current open
>> |  tickets, but actually it's a frozen snapshot.  What should I do?
>> |
>> |  Gitlab Wiki does not support this feature so you have to refer to a custom
>> |  search.
>> |
>> |  For example:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%3Flabel_name%255B%255D%3DApplicativeDo&amp
>> |  ;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319
>> |  %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata
>> |  =DM%2B9ZPFxUhJW%2B2EokkOJzXF6Ca6PlSgQf1TGsCt36Wc%3D&amp;reserved=0
>> |
>> |  However, it seems that the `CustomTypeErrors` label was lost during the
>> |  migration. Do you know why this is Tobias/Ben? It looks like it will have
>> |  to be added back manually.
>> |
>> |  >
>> |  > Thanks
>> |  >
>> |  > Simon
>> |  >
>> |  > |  I'm happy to announce that the ticket and issue import processes
>> |  > | are now  complete and gitlab.haskell.org is back online. There are
>> |  > | still a few  final steps remaining which I will be carrying out over
>> |  > | the next few
>> |  > |  days:
>> |  > |
>> |  > |   * Put in place redirect logic for Trac ticket and Wiki URLs
>> |  > |
>> |  > |   * Add issue comments showing commit messages, replicating the
>> |  previous
>> |  > |     Trac behavior
>> |  > |
>> |  > |   * Migrate the GHC Blog entries
>> |  > |
>> |  > |   * Make the old Trac instance again accessible in read-only mode
>> |  > |
>> |  > |  However, while I do this you should feel free to use
>> |  > | gitlab.haskell.org  freely.
>> |  > |  If you notice any issues with the import feel free to open a ticket
>> |  > | here  [1].
>> |  > |
>> |  > |  Cheers,
>> |  > |
>> |  > |  - Ben
>> |  > |
>> |  > |
>> |  > |
>> |  > |  [1]
>> |  > |
>> |  > | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
>> |  > | tlab.h
>> |  > |  askell.org%2Fbgamari%2Fgitlab-
>> |  > |
>> |  > | migration%2Fissues&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C48ce
>> |  > | 7f7334
>> |  > |
>> |  > | c04a54549508d6a5a0cb40%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C
>> |  > | 636878
>> |  > |
>> |  > | 507364801779&amp;sdata=DIxKgZy%2B%2BTYq0P%2BEkrxjefMQqUf43ObXi9CLOGo
>> |  > | 0sk4%3
>> |  > |  D&amp;reserved=0
>> |  > _______________________________________________
>> |  > ghc-devs mailing list
>> |  > [hidden email]
>> |  > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.
>> |  > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&amp;data=02%7C01
>> |  > %7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988
>> |  > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=V5Xq
>> |  > iP3b87PRpJvS5KSxyM6qkpSnM3KMDtrIhdQhwB0%3D&amp;reserved=0
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

RE: Trac to GitLab migration underway

Ben Gamari-3
In reply to this post by GHC - devs mailing list
Simon Peyton Jones via ghc-devs <[hidden email]> writes:

> |  I'm happy to announce that the ticket and issue import processes are now
> |  complete and gitlab.haskell.org is back online. There are still a few
> |  final steps remaining which I will be carrying out over the next few
> |  days:
>
> Great!  I'm sure it'll help to have everything in one place.
>
> Can I ask
>
> * That the old ticket repo be put in read-only mode. I've just
> modified the old #16344, but I should have modified the new one.
>
Indeed this was supposed to be already done but it looks like I failed
to remove a few permissions for developers which allowed further
changes. This has been fixed.

> * Back on the tickets front, how do I record the test cases(s) for a ticket?  
>
This is unfortunately one of the casualties of the migration. GitLab
doesn't have support for custom ticket fields (although they have
indicated that they may introduce such support in the future).

In the meantime we have a few options:

 * we introduce a convention to document this in comments

 * we give up tracking this in the issue tracker

> * How do I record the MR for a ticket?  (When it has one.)
>
Referring to the ticket from the MR description will result in a
reference being added to the ticket.

> * That the banner (on the wiki at least) saying "This site has been
> deprecated and is in read-only mode" should describe how to get to the
> corresponding URL on the new wiki. Eg. say "If you are trying to
> access https://ghc.haskell.org/trac/ghc/wiki/<page>, the new URL is
> "https://gitlab.haskell.org/ghc/ghc/wikis/<page>".
>
Ultimately the plan is to make Trac URLs directly forward to GitLab's
Wiki. The current state of affairs is temporary.

> * Where has https://ghc.haskell.org/trac/ghc/wiki/RichardAndSimon
> gone? The corresponding URL on the new wiki doesn't exist.
>
This is an unfortunate effect of the move to GitLab's wiki, which
insists on a different naming convention than Trac (kebab-case instead
of CamelCase).


> * How can I list the title index on the new wiki?
>
As Matthew mentioned, there is a table of contents page here [1]. Note
that this is quite a hack; ideally we would be able to use GitLab's
provided pages list feature [2] but unfortunately it's essentially
unusable with a Wiki of non-trivial size. I have reported this upstream
[3,4].

> * I have lots of pages like this one
> https://gitlab.haskell.org/ghc/ghc/wikis/proposal/custom-type-errors
> that list the tickets relevant to a particular keyword. (Now "label" I
> think?) But tat page is now lying: it claims to list current open
> tickets, but actually it's a frozen snapshot. What should I do?

I can take care of replacing these with links to the appropriate query.

Cheers,

- Ben


[1] https://gitlab.haskell.org/ghc/ghc/wikis/index
[2] https://gitlab.haskell.org/ghc/ghc/wikis/pages
[3] https://gitlab.com/gitlab-org/gitlab-ce/issues/57751
[4] https://gitlab.com/gitlab-org/gitlab-ce/issues/57179


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Trac to GitLab migration underway

GHC - devs mailing list
In reply to this post by Richard Eisenberg-5

I suggest adding it to

https://docs.google.com/document/d/1sdGlDJSTiBZSH6kBU5pyn1HASE9XFqQhzILcYcH1QJQ/edit?usp=sharing

which is our “GHC project wishlist for GitLab”.

 

But Ben may have a way to bring it up directly as well.

 

Simon

 

From: ghc-devs <[hidden email]> On Behalf Of Richard Eisenberg
Sent: 11 March 2019 20:43
To: Artem Pelenitsyn <[hidden email]>
Cc: GHC developers <[hidden email]>
Subject: Re: Trac to GitLab migration underway

 

Good point -- I hadn't noticed the unfortunate phrasing of the original post.

 

You're right that the current focus is on email, but the tabs issue affects me, too. In any case, let's not link to that ticket.

 

But before I take further action, I know that we have some side channels with GitLab, and I don't want to muddy the waters by working outside of those channels. If I should take further action, please let me know.

 

Richard



On Mar 11, 2019, at 1:54 PM, Artem Pelenitsyn <[hidden email]> wrote:

 

Hi Richard,

 

Good catch! What troubles me in that issue, is (subjectively) the passive-aggressive form of the initial post. Given that it is email that we are worrying about, not the browser tabs, maybe it is better to start over with a new issue referencing that one in passing.

 

--

Best, Artem

 

On Mon, 11 Mar 2019 at 11:56 Richard Eisenberg <[hidden email]> wrote:

This old ticket might be related: https://gitlab.com/gitlab-org/gitlab-ce/issues/1734   It advocates for moving numbers to the front of tab names, too. Looks like it was shut down by judgment call. Perhaps if we raise our voices in chorus against this decision, we can get some action (or a new configuration switch).



On Mar 11, 2019, at 10:25 AM, Artem Pelenitsyn <[hidden email]> wrote:

 

Hello,

 

I just wanted to thank Ben and everyone involved for this transition. And also reiterate Richard's point about having !123 / #12345 in the front of mail subjects — I think, this is small but quite important detail to ease navigating the flow of notifications.

 

--

Best regards,

Artem

 

On Mon, Mar 11, 2019, 9:13 AM Richard Eisenberg <[hidden email]> wrote:

Thanks to all who have made this happen. Looking forward to having everything in one place!

Do we have any ability to edit the formatting of subject lines of ticket emails? It would be great if we could get the (!234) or (#12345) up front, as this is the effective summary of what's to follow.

I'd also like to second Simon's request, in particular, of having a clear path from an issue to an MR. Getting from an MR to an issue is normally easier -- when the MR is created, most devs would automatically mention the issue number somewhere in the description -- but going from an issue to an MR is harder. It would be a shame to have to search through the commentary looking for the link. I used the old "Phab:D1234" links in the top of a Trac ticket quite often.

I also second the request for a test-case field. This field, to me, is most useful as a reminder to the author that they need to add a test case. But I think the issue-to-MR link is more important than the test-case field.

Thanks!
Richard

> On Mar 11, 2019, at 6:17 AM, Matthew Pickering <[hidden email]> wrote:
>
> I wrote !509 in the ticket which then made gitlab display the "Related
> Merge Request" bit underneath. I don't know what happens if you
> mention a MR in a comment.
>
> On Mon, Mar 11, 2019 at 10:14 AM Simon Peyton Jones
> <[hidden email]> wrote:
>>
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>>
>> That's sad. It's a useful discipline to fill in that field before closing the ticket.  And it's useful later when looking for the test cases for the ticket.
>>
>> Is this just a straight loss, or is there a longer term plan to recover it?  Do we need a self-imposed discipline, e.g. to ALWAYS add a comment that lists the test cases (and does nothing else) before closing an issue?
>>
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>>
>> I don't get it.  You manually added "Corresponding MR !509" to the issue Description.  Or are you saying that that apparently-user-written line was added by GitLab? If you have many MRs taht mention (perhaps en passant) the same issue, will there be many such lines?
>>
>> Or is it another discipline we could impose on ourselves?
>>
>> Simon
>>
>> |  -----Original Message-----
>> |  From: Matthew Pickering <[hidden email]>
>> |  Sent: 11 March 2019 09:37
>> |  To: Simon Peyton Jones <[hidden email]>
>> |  Cc: Ben Gamari <[hidden email]>; GHC developers <[hidden email]>
>> |  Subject: Re: Trac to GitLab migration underway
>> |
>> |  > * That the old ticket repo be put in read-only mode.  I've just modified
>> |  the old #16344, but I should have modified the new one.
>> |
>> |  That is tracked
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fbgamari%2Fgitlab-
>> |  migration%2Fissues%2F14&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356
>> |  d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6
>> |  36878938597242017&amp;sdata=XnY%2Fo62mCkz849XKLKe8V3stFe8sorBQkqI9%2FY%2By
>> |  CdI%3D&amp;reserved=0
>> |
>> |  It seems that there are still some problems to iron out though.
>> |
>> |  > * Back on the tickets front, how do I record the test cases(s) for a
>> |  ticket?
>> |
>> |  I don't believe there is a way other than via the commit referencing the
>> |  ticket.
>> |
>> |  >
>> |  > * How do I record the MR for a ticket?  (When it has one.)
>> |
>> |  When you mention a ticket in a MR then a reference should be created from
>> |  it to the ticket.
>> |
>> |  For example, when I mentioned !509 on this ticket it now displays in the
>> |  UI.
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%2F16417&amp;data=02%7C01%7Csimonpj%40micro
>> |  soft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011
>> |  db47%7C1%7C0%7C636878938597242017&amp;sdata=s5%2FfsXsx5t%2FuRIeq6AJZU5sr8P
>> |  FJpNt6nkr%2BObzRAmk%3D&amp;reserved=0
>> |
>> |  >
>> |  > * That the banner (on the wiki at least) saying "This site has been
>> |  deprecated and is in read-only mode" should describe how to get to the
>> |  corresponding URL on the new wiki. Eg. say "If you are trying to access
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2F&amp;data=02%7C01%7Csimonpj%40microsoft.com%
>> |  7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%
>> |  7C0%7C636878938597242017&amp;sdata=vq0ZCkxOmaQp4vB3WPzc%2BovCn1oSSak5K6CYM
>> |  1UyIq4%3D&amp;reserved=0<page>, the new URL is
>> |  "https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.
>> |  haskell.org%2Fghc%2Fghc%2Fwikis%2F&amp;data=02%7C01%7Csimonpj%40microsoft.
>> |  com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%
>> |  7C1%7C0%7C636878938597242017&amp;sdata=ZbZf%2BlVa1rqrngh82QrJAIRmDFaGMp0Gb
>> |  BUo5ABhqVo%3D&amp;reserved=0<page>".
>> |  >
>> |  > * Where has
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fghc.hask
>> |  ell.org%2Ftrac%2Fghc%2Fwiki%2FRichardAndSimon&amp;data=02%7C01%7Csimonpj%4
>> |  0microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d
>> |  7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=xkERHLEyWh8yWLxRS2GUZ4iu
>> |  Yk0DjFBxuKFkQbnyUeI%3D&amp;reserved=0 gone?  The corresponding URL on the
>> |  new wiki doesn't exist.
>> |
>> |  The page is now located at:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Frichard-and-
>> |  simon&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d
>> |  6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&
>> |  amp;sdata=X%2BOPbJn4zTiGNkH%2Ba5TVoge6dxZmGw0WSxrnxEpk0og%3D&amp;reserved=
>> |  0
>> |
>> |  >
>> |  > * How can I list the title index on the new wiki?
>> |
>> |  An automatically generated index is available here
>> |
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Findex&amp;data=02%7C01%7Csimonpj%40micros
>> |  oft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988bf86f141af91ab2d7cd011d
>> |  b47%7C1%7C0%7C636878938597242017&amp;sdata=BZ337ak7obJlIGW4GK5R4FOl1uCCH2T
>> |  D4DGorbNyz28%3D&amp;reserved=0
>> |
>> |  I believe the intention is to automatically update this with a cronjob.
>> |
>> |  >
>> |  > * I have lots of pages like this one
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fwikis%2Fproposal%2Fcustom-type-
>> |  errors&amp;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008
>> |  d6a6053319%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017
>> |  &amp;sdata=sueCHGV9aE36gaIqUgxBq1VZl4zOKhCYDOWwsnSgAss%3D&amp;reserved=0
>> |  that list the tickets relevant to a particular keyword.  (Now "label" I
>> |  think?)   But tat page is now lying: it claims to list current open
>> |  tickets, but actually it's a frozen snapshot.  What should I do?
>> |
>> |  Gitlab Wiki does not support this feature so you have to refer to a custom
>> |  search.
>> |
>> |  For example:
>> |  https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h
>> |  askell.org%2Fghc%2Fghc%2Fissues%3Flabel_name%255B%255D%3DApplicativeDo&amp
>> |  ;data=02%7C01%7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319
>> |  %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata
>> |  =DM%2B9ZPFxUhJW%2B2EokkOJzXF6Ca6PlSgQf1TGsCt36Wc%3D&amp;reserved=0
>> |
>> |  However, it seems that the `CustomTypeErrors` label was lost during the
>> |  migration. Do you know why this is Tobias/Ben? It looks like it will have
>> |  to be added back manually.
>> |
>> |  >
>> |  > Thanks
>> |  >
>> |  > Simon
>> |  >
>> |  > |  I'm happy to announce that the ticket and issue import processes
>> |  > | are now  complete and gitlab.haskell.org is back online. There are
>> |  > | still a few  final steps remaining which I will be carrying out over
>> |  > | the next few
>> |  > |  days:
>> |  > |
>> |  > |   * Put in place redirect logic for Trac ticket and Wiki URLs
>> |  > |
>> |  > |   * Add issue comments showing commit messages, replicating the
>> |  previous
>> |  > |     Trac behavior
>> |  > |
>> |  > |   * Migrate the GHC Blog entries
>> |  > |
>> |  > |   * Make the old Trac instance again accessible in read-only mode
>> |  > |
>> |  > |  However, while I do this you should feel free to use
>> |  > | gitlab.haskell.org  freely.
>> |  > |  If you notice any issues with the import feel free to open a ticket
>> |  > | here  [1].
>> |  > |
>> |  > |  Cheers,
>> |  > |
>> |  > |  - Ben
>> |  > |
>> |  > |
>> |  > |
>> |  > |  [1]
>> |  > |
>> |  > | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
>> |  > | tlab.h
>> |  > |  askell.org%2Fbgamari%2Fgitlab-
>> |  > |
>> |  > | migration%2Fissues&amp;data=02%7C01%7Csimonpj%40microsoft.com%7C48ce
>> |  > | 7f7334
>> |  > |
>> |  > | c04a54549508d6a5a0cb40%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C
>> |  > | 636878
>> |  > |
>> |  > | 507364801779&amp;sdata=DIxKgZy%2B%2BTYq0P%2BEkrxjefMQqUf43ObXi9CLOGo
>> |  > | 0sk4%3
>> |  > |  D&amp;reserved=0
>> |  > _______________________________________________
>> |  > ghc-devs mailing list
>> |  > [hidden email]
>> |  > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.
>> |  > haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-devs&amp;data=02%7C01
>> |  > %7Csimonpj%40microsoft.com%7Cac356d50797a44abf82008d6a6053319%7C72f988
>> |  > bf86f141af91ab2d7cd011db47%7C1%7C0%7C636878938597242017&amp;sdata=V5Xq
>> |  > iP3b87PRpJvS5KSxyM6qkpSnM3KMDtrIhdQhwB0%3D&amp;reserved=0
> _______________________________________________
> ghc-devs mailing list
> [hidden email]
> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

 

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

 


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Ben Gamari-2
In reply to this post by Richard Eisenberg-4
Richard Eisenberg <[hidden email]> writes:

> Thanks to all who have made this happen. Looking forward to having
> everything in one place!
>
> Do we have any ability to edit the formatting of subject lines of
> ticket emails? It would be great if we could get the (!234) or
> (#12345) up front, as this is the effective summary of what's to
> follow.
>
I think we can manage that. Ideally I'd like to stay as close to an
unmodified GitLab installation as possible but this particular issue
doesn't sound like it should be a hard thing to fix.

> I'd also like to second Simon's request, in particular, of having a
> clear path from an issue to an MR. Getting from an MR to an issue is
> normally easier -- when the MR is created, most devs would
> automatically mention the issue number somewhere in the description --
> but going from an issue to an MR is harder. It would be a shame to
> have to search through the commentary looking for the link. I used the
> old "Phab:D1234" links in the top of a Trac ticket quite often.
>
In principle it shouldn't be any harder to go from an issue to an MR
than it is to go the other direction. For instance, consider the case of
#16347 [1]. You will note that below the "Related issues" section there
is a list of related merge requests (strangely formatted completely
differently).

To be honest, how this list is formed is a bit of a mystery to me. The
fact that !525 is included is not surprises: !525 mentions #16347 in
its description. However, !436 is a bit less obvious since it does not
mention #16347 at all. My hypothesis is that it is transitively included
via #16344, which does mention #16437 and is related to it.


[1] https://gitlab.haskell.org/ghc/ghc/issues/16347


> I also second the request for a test-case field. This field, to me, is
> most useful as a reminder to the author that they need to add a test
> case. But I think the issue-to-MR link is more important than the
> test-case field.
>
Indeed, as I mentioned earlier this may be a bit of a hard thing to
accomplish in the near-term. One measure we could take to ensure that
tests aren't forgotten is to include a "field" in the default merge
request description which contributors would be asked to fill in with
the names of the tests that cover their change. That being said, this is
no substitute for a proper field.

Cheers,

- Ben

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Ben Gamari-2
In reply to this post by Richard Eisenberg-5
Richard Eisenberg <[hidden email]> writes:

> Good point -- I hadn't noticed the unfortunate phrasing of the
> original post.
>
> You're right that the current focus is on email, but the tabs issue
> affects me, too. In any case, let's not link to that ticket.
>
> But before I take further action, I know that we have some side
> channels with GitLab, and I don't want to muddy the waters by working
> outside of those channels. If I should take further action, please let
> me know.
>
Opening a ticket is always a good first step. Generally my interactions
with our contact take the form of opening new tickets or bringing
existing tickets to his attention.

Cheers,

- Ben


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Trac to GitLab migration underway

GHC - devs mailing list
In reply to this post by Ben Gamari-3
|  > * I have lots of pages like this one
|  > https://gitlab.haskell.org/ghc/ghc/wikis/proposal/custom-type-errors
|  > that list the tickets relevant to a particular keyword. (Now "label" I
|  > think?) But tat page is now lying: it claims to list current open
|  > tickets, but actually it's a frozen snapshot. What should I do?
|  
|  I can take care of replacing these with links to the appropriate query.

Actually, clicking on a label icon takes you to a page that lists the open and closed issues associated with that label.  That's enough I think. No need to make a custom query.

I have done an example here:
https://gitlab.haskell.org/ghc/ghc/wikis/partial-type-signatures

Simon


|  -----Original Message-----
|  From: Ben Gamari <[hidden email]>
|  Sent: 11 March 2019 22:37
|  To: Simon Peyton Jones <[hidden email]>; GHC developers <ghc-
|  [hidden email]>
|  Subject: RE: Trac to GitLab migration underway
|  
|  Simon Peyton Jones via ghc-devs <[hidden email]> writes:
|  
|  > |  I'm happy to announce that the ticket and issue import processes
|  > | are now  complete and gitlab.haskell.org is back online. There are
|  > | still a few  final steps remaining which I will be carrying out over
|  > | the next few
|  > |  days:
|  >
|  > Great!  I'm sure it'll help to have everything in one place.
|  >
|  > Can I ask
|  >
|  > * That the old ticket repo be put in read-only mode. I've just
|  > modified the old #16344, but I should have modified the new one.
|  >
|  Indeed this was supposed to be already done but it looks like I failed to
|  remove a few permissions for developers which allowed further changes.
|  This has been fixed.
|  
|  > * Back on the tickets front, how do I record the test cases(s) for a
|  ticket?
|  >
|  This is unfortunately one of the casualties of the migration. GitLab
|  doesn't have support for custom ticket fields (although they have
|  indicated that they may introduce such support in the future).
|  
|  In the meantime we have a few options:
|  
|   * we introduce a convention to document this in comments
|  
|   * we give up tracking this in the issue tracker
|  
|  > * How do I record the MR for a ticket?  (When it has one.)
|  >
|  Referring to the ticket from the MR description will result in a reference
|  being added to the ticket.
|  
|  > * That the banner (on the wiki at least) saying "This site has been
|  > deprecated and is in read-only mode" should describe how to get to the
|  > corresponding URL on the new wiki. Eg. say "If you are trying to
|  > access https://ghc.haskell.org/trac/ghc/wiki/<page>, the new URL is
|  > "https://gitlab.haskell.org/ghc/ghc/wikis/<page>".
|  >
|  Ultimately the plan is to make Trac URLs directly forward to GitLab's
|  Wiki. The current state of affairs is temporary.
|  
|  > * Where has https://ghc.haskell.org/trac/ghc/wiki/RichardAndSimon
|  > gone? The corresponding URL on the new wiki doesn't exist.
|  >
|  This is an unfortunate effect of the move to GitLab's wiki, which insists
|  on a different naming convention than Trac (kebab-case instead of
|  CamelCase).
|  
|  
|  > * How can I list the title index on the new wiki?
|  >
|  As Matthew mentioned, there is a table of contents page here [1]. Note
|  that this is quite a hack; ideally we would be able to use GitLab's
|  provided pages list feature [2] but unfortunately it's essentially
|  unusable with a Wiki of non-trivial size. I have reported this upstream
|  [3,4].
|  
|  > * I have lots of pages like this one
|  > https://gitlab.haskell.org/ghc/ghc/wikis/proposal/custom-type-errors
|  > that list the tickets relevant to a particular keyword. (Now "label" I
|  > think?) But tat page is now lying: it claims to list current open
|  > tickets, but actually it's a frozen snapshot. What should I do?
|  
|  I can take care of replacing these with links to the appropriate query.
|  
|  Cheers,
|  
|  - Ben
|  
|  
|  [1] https://gitlab.haskell.org/ghc/ghc/wikis/index
|  [2] https://gitlab.haskell.org/ghc/ghc/wikis/pages
|  [3] https://gitlab.com/gitlab-org/gitlab-ce/issues/57751
|  [4] https://gitlab.com/gitlab-org/gitlab-ce/issues/57179

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Trac to GitLab migration underway

Richard Eisenberg-5
In reply to this post by Ben Gamari-2

> On Mar 11, 2019, at 8:13 PM, Ben Gamari <[hidden email]> wrote:
>
> Richard Eisenberg <[hidden email]> writes:
> For instance, consider the case of
> #16347 [1]. You will note that below the "Related issues" section there
> is a list of related merge requests (strangely formatted completely
> differently).

Aha. That's exactly what I wanted. If that note is added to an issue when an MR mentions the issue number, I'm quite satisfied.

>
> To be honest, how this list is formed is a bit of a mystery to me. The
> fact that !525 is included is not surprises: !525 mentions #16347 in
> its description. However, !436 is a bit less obvious since it does not
> mention #16347 at all. My hypothesis is that it is transitively included
> via #16344, which does mention #16437 and is related to it.

Transitive closures have a habit of sometimes getting large. But we'll tackle that problem when/if it comes up.
> Indeed, as I mentioned earlier this may be a bit of a hard thing to
> accomplish in the near-term. One measure we could take to ensure that
> tests aren't forgotten is to include a "field" in the default merge
> request description which contributors would be asked to fill in with
> the names of the tests that cover their change.

That's not a bad starting point. But it will hit only new contributors, right? Or will I be filling out such a form too (it's been a few weeks since my last patch submission, I'm afraid.)

Thanks!
Richard


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
12