Unifying verbosity flags (ticket #12822)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Unifying verbosity flags (ticket #12822)

Sergey Bykov

Hi, I'm working with the #12822 task, which is a refactoring for the verbosity flag. It should be reimplemented in a way, similar to the 'optimization' flag. After studying the codebase, specifically optLevelFlags, I'm stuck with the following questions:

  1. Should I add a new data 'VerbosityFlag' similar to GeneralFlag, DumpFlag, etc or should I extend any of existing data types?
  2. How to determine a set of verbosity options to implement? Is grepping through all the codebase and adding corresponding options a good approach?


Thanks!

-- 
Best regards,
Sergey Bykov

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: Unifying verbosity flags (ticket #12822)

Ben Gamari-2
Sergey Bykov <[hidden email]> writes:

> Hi, I'm working with the #12822 task, which is a refactoring for the
> verbosity flag. It should be reimplemented in a way, similar to the
> 'optimization' flag. After studying the codebase, specifically
> *optLevelFlags*, I'm stuck with the following questions:
>
>  1. Should I add a new data 'VerbosityFlag' similar to GeneralFlag,
>     DumpFlag, etc or should I extend any of existing data types?
>  2. How to determine a set of verbosity options to implement? Is
>     grepping through all the codebase and adding corresponding options a
>     good approach?
>
As I understand it, the task is to split up the current -v<n> flags into
distinct flags. The current role of -v is described roughly in
Note [Verbosity levels] (although it references -ddump-most and
-ddump-all, which don't exist anymore).

Grepping the source tree (e.g. for "verbosity dflags") would indeed be a
good way to find the various places it's used. For now let's just add
the new flags to GeneralFlag. If there are enough that GeneralFlags
becomes bloated we can refactor later.

Thanks for looking at this.

Cheers,

- Ben

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Unifying verbosity flags (ticket #12822)

Ben Gamari-2
Ben Gamari <[hidden email]> writes:

> Sergey Bykov <[hidden email]> writes:
>
>> Hi, I'm working with the #12822 task, which is a refactoring for the
>> verbosity flag. It should be reimplemented in a way, similar to the
>> 'optimization' flag. After studying the codebase, specifically
>> *optLevelFlags*, I'm stuck with the following questions:
>>
>>  1. Should I add a new data 'VerbosityFlag' similar to GeneralFlag,
>>     DumpFlag, etc or should I extend any of existing data types?
>>  2. How to determine a set of verbosity options to implement? Is
>>     grepping through all the codebase and adding corresponding options a
>>     good approach?
>>
> As I understand it, the task is to split up the current -v<n> flags into
> distinct flags. The current role of -v is described roughly in
> Note [Verbosity levels] (although it references -ddump-most and
> -ddump-all, which don't exist anymore).
>
> Grepping the source tree (e.g. for "verbosity dflags") would indeed be a
> good way to find the various places it's used. For now let's just add
> the new flags to GeneralFlag. If there are enough that GeneralFlags
> becomes bloated we can refactor later.
>
> Thanks for looking at this.
>
I also left a comment on the ticket listing the relevant uses of
verbosity.

Cheers,

- Ben

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

signature.asc (497 bytes) Download Attachment