[commit: packages/base] master: Improve error messages for partial functions in Data.Data (d0b74ca)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[commit: packages/base] master: Improve error messages for partial functions in Data.Data (d0b74ca)

Gabor Greif-2
On 1/1/14, git at git.haskell.org <git at git.haskell.org> wrote:

> Repository : ssh://git at git.haskell.org/base
>
> On branch  : master
> Link       :
> http://ghc.haskell.org/trac/ghc/changeset/d0b74cac0b0ab5371d15b6f73c0e627b41c3a152/base
>
>>---------------------------------------------------------------
>
> commit d0b74cac0b0ab5371d15b6f73c0e627b41c3a152
> Author: Krzysztof Langner <klangner at gmail.com>
> Date:   Wed Jan 1 14:14:46 2014 +0100
>
>     Improve error messages for partial functions in Data.Data
>
>     This closes: #5412

Hi Krzysztof,

there are typos "an Real" --> "a Real"
but this actually your commit begs for a refactoring

> "something" `notAsExpected` "a Real"

etc. as it would eliminate a bunch of (string) redundancy.

Cheers,

   Gabor

>
>
>>---------------------------------------------------------------
>
> d0b74cac0b0ab5371d15b6f73c0e627b41c3a152
>  Data/Data.hs |   76
> ++++++++++++++++++++++++++++++++++++++++------------------
>  1 file changed, 53 insertions(+), 23 deletions(-)
>
> Diff suppressed because of size. To see it, use:
>
>     git diff-tree --root --patch-with-stat --no-color --find-copies-harder
> --ignore-space-at-eol --cc d0b74cac0b0ab5371d15b6f73c0e627b41c3a152
> _______________________________________________
> ghc-commits mailing list
> ghc-commits at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-commits
>