[commit: testsuite] master: Summarily skip compiler_perf tests when DEBUG is on (715e313)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[commit: testsuite] master: Summarily skip compiler_perf tests when DEBUG is on (715e313)

Simon Peyton Jones
Good!  but please add a comment to explain why!  The code is fully of mysterious un-commented things like this.

Simon

| -----Original Message-----
| From: ghc-commits [mailto:ghc-commits-bounces at haskell.org] On Behalf Of
| git at git.haskell.org
| Sent: 28 November 2013 14:19
| To: ghc-commits at haskell.org
| Subject: [commit: testsuite] master: Summarily skip compiler_perf tests
| when DEBUG is on (715e313)
|
| Repository : ssh://git at git.haskell.org/testsuite
|
| On branch  : master
| Link       :
| http://ghc.haskell.org/trac/ghc/changeset/715e313d84f4e919e12c6bba6cd646
| e488cffa74/testsuite
|
| >---------------------------------------------------------------
|
| commit 715e313d84f4e919e12c6bba6cd646e488cffa74
| Author: Joachim Breitner <mail at joachim-breitner.de>
| Date:   Thu Nov 28 14:17:35 2013 +0000
|
|     Summarily skip compiler_perf tests when DEBUG is on
|
|     by ensuring this in the test runner.
|
|
| >---------------------------------------------------------------
|
| 715e313d84f4e919e12c6bba6cd646e488cffa74
|  driver/testlib.py |    3 +++
|  1 file changed, 3 insertions(+)
|
| diff --git a/driver/testlib.py b/driver/testlib.py
| index ed7d02f..bdb91b8 100644
| --- a/driver/testlib.py
| +++ b/driver/testlib.py
| @@ -291,6 +291,9 @@ def _compiler_stats_num_field( name, opts, field,
| expecteds ):
|      if field in opts.compiler_stats_range_fields:
|          framework_fail(name, 'duplicate-numfield', 'Duplicate ' + field
| + ' num_field check')
|
| +    if compiler_debugged():
| +        skip(name, opts)
| +
|      for (b, expected, dev) in expecteds:
|          if b:
|              opts.compiler_stats_range_fields[field] = (expected, dev)
|
| _______________________________________________
| ghc-commits mailing list
| ghc-commits at haskell.org
| http://www.haskell.org/mailman/listinfo/ghc-commits