fyi: I broke DEBUG

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

fyi: I broke DEBUG

Nicolas Frisby
I've validating the reversion of my offending patch right now.

I now see that validate doesn't test DEBUG unless you provide --slow.
Lesson learned.

My apologies.

Thanks.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20130412/d574876a/attachment.htm>

Reply | Threaded
Open this post in threaded view
|

fyi: I broke DEBUG

Nicolas Frisby
I just pushed my "git revert" of the commit that broke DEBUG.

Two points:

 1) ./validate --slow froze a couple of times, and I'm running out of time
in this building (end of internship), so...

 2) I again validated without --slow

My logic is: my patch only affected DEBUG, my reversion probably fixes
that, and I have confirmed that this patch also passes a standard validate,
so I pushed.

I'll keep checking my email in case I have somehow made things worse. (My
nerves are a little fritzed.)

HTH. Sorry for the noise.


On Fri, Apr 12, 2013 at 3:48 PM, Nicolas Frisby <nicolas.frisby at gmail.com>wrote:

> I've validating the reversion of my offending patch right now.
>
> I now see that validate doesn't test DEBUG unless you provide --slow.
> Lesson learned.
>
> My apologies.
>
> Thanks.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20130412/63ea7a72/attachment.htm>