gitlab upgrade - change in approval system

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

gitlab upgrade - change in approval system

Matthew Pickering
Hi,

I just noticed that the gitlab upgrade has caused the approval system
to change.

Before all that was required was 1 approval from anyone.

Now, at least one approval from the default group is required (me,
Ben, Omer, Tobias, David)

I couldn't see a way to turn back to the old behaviour from a brief
look at the UI. Do you know if there is a way Ben?

Cheers,

Matt
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: gitlab upgrade - change in approval system

Ryan Scott
I would definitely appreciate changing Marge's behavior back to the old one. As things stand currently, I am unable to approve anything that I'm not explicitly listed as a reviewer for. See here [1] for an example of where this has happened.

Ryan S.
-----

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: gitlab upgrade - change in approval system

Phyx
I have noticed that you can work around this by editing the Mr and adding yourself explicitly to the approvals list for it. 

It then allows you to approve it. 

Sent from my Mobile

On Fri, May 17, 2019, 13:54 Ryan Scott <[hidden email]> wrote:
I would definitely appreciate changing Marge's behavior back to the old one. As things stand currently, I am unable to approve anything that I'm not explicitly listed as a reviewer for. See here [1] for an example of where this has happened.

Ryan S.
-----
_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs
Reply | Threaded
Open this post in threaded view
|

Re: gitlab upgrade - change in approval system

Ryan Scott
In reply to this post by Matthew Pickering
To be clear, your workaround is precisely what I used to do, but that is no longer working after the GitLab upgrade. I can add myself as a reviewer, but only to a group besides the default approvers list. Because Marge only counts approvals from those who belong to the default approvers list, my approvals don't count anymore.

Ryan S.


_______________________________________________
ghc-devs mailing list
[hidden email]
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs