recomp013

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

recomp013

Simon Peyton Jones
I'm getting the failure below for recomp013.  Any ideas? It was added by Joachim:

commit b1f6cab360faf79d586eda8ee3c1c486e53d0066
Author: Joachim Breitner <mail at joachim-breitner.de>
Date:   Tue Sep 17 22:37:51 2013 +0200

    Recompilation test case for #8247

Joachim: when you have a test for a ticket, please use "T8247" as the test name.  Much easier to track back!  Thanks.

Simon


Microsoft Research Limited (company number 03369488) is registered in England and Wales
Registered office is at 21 Station Road, Cambridge, CB1 2FB

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20130919/23a5030c/attachment.htm>

Reply | Threaded
Open this post in threaded view
|

recomp013

Jan Stolarek
Simon, I think you didn't paste the failure.

Janek

----- Oryginalna wiadomo?? -----
Od: "Simon Peyton-Jones" <simonpj at microsoft.com>
Do: ghc-devs at haskell.org, "Joachim Breitner" <mail at joachim-breitner.de>
Wys?ane: czwartek, 19 wrzesie? 2013 12:17:29
Temat: recomp013



I?m getting the failure below for recomp013.? Any ideas? It was added by Joachim:

?

commit b1f6cab360faf79d586eda8ee3c1c486e53d0066

Author: Joachim Breitner <mail at joachim-breitner.de>

Date:?? Tue Sep 17 22:37:51 2013 +0200

?

??? Recompilation test case for #8247

???

Joachim: when you have a test for a ticket, please use ?T8247? as the test name.? Much easier to track back!? Thanks.

?

Simon

?

?

Microsoft Research Limited (company number 03369488) is registered in England and Wales

Registered office is at 21 Station Road, Cambridge, CB1 2FB

?

_______________________________________________
ghc-devs mailing list
ghc-devs at haskell.org
http://www.haskell.org/mailman/listinfo/ghc-devs


Reply | Threaded
Open this post in threaded view
|

recomp013

Simon Peyton Jones
Sorry, here

=====> recomp013(normal) 89 of 114 [0, 0, 0]
cd ./recomp013 && $MAKE -s --no-print-directory recomp013    </dev/null >recomp013.run.stdout 2>recomp013.run.stderr
Actual stdout output differs from expected:
--- ./recomp013/recomp013.stdout 2013-09-18 12:38:22.000000000 +0100
+++ ./recomp013/recomp013.run.stdout 2013-09-19 12:15:22.611120935 +0100
@@ -3,5 +3,3 @@
 [2 of 3] Compiling B                ( B.hs, B.o )
 [3 of 3] Compiling C                ( C.hs, C.o )
 second run
-[2 of 3] Compiling B                ( B.hs, B.o )
-[3 of 3] Compiling C                ( C.hs, C.o ) [B changed]
*** unexpected failure for recomp013(normal)

| -----Original Message-----
| From: Jan Stolarek [mailto:jan.stolarek at p.lodz.pl]
| Sent: 19 September 2013 12:22
| To: Simon Peyton-Jones
| Cc: ghc-devs at haskell.org; Joachim Breitner
| Subject: Re: recomp013
|
| Simon, I think you didn't paste the failure.
|
| Janek
|
| ----- Oryginalna wiadomo?? -----
| Od: "Simon Peyton-Jones" <simonpj at microsoft.com>
| Do: ghc-devs at haskell.org, "Joachim Breitner" <mail at joachim-breitner.de>
| Wys?ane: czwartek, 19 wrzesie? 2013 12:17:29
| Temat: recomp013
|
|
|
| I?m getting the failure below for recomp013.? Any ideas? It was added by
| Joachim:
|
|
|
| commit b1f6cab360faf79d586eda8ee3c1c486e53d0066
|
| Author: Joachim Breitner <mail at joachim-breitner.de>
|
| Date:?? Tue Sep 17 22:37:51 2013 +0200
|
|
|
| ??? Recompilation test case for #8247
|
|
|
| Joachim: when you have a test for a ticket, please use ?T8247? as the
| test name.? Much easier to track back!? Thanks.
|
|
|
| Simon
|
|
|
|
|
| Microsoft Research Limited (company number 03369488) is registered in
| England and Wales
|
| Registered office is at 21 Station Road, Cambridge, CB1 2FB
|
|
|
| _______________________________________________
| ghc-devs mailing list
| ghc-devs at haskell.org
| http://www.haskell.org/mailman/listinfo/ghc-devs

Reply | Threaded
Open this post in threaded view
|

recomp013

Joachim Breitner-2
Dear Simon,

Am Donnerstag, den 19.09.2013, 11:33 +0000 schrieb Simon Peyton-Jones:

> =====> recomp013(normal) 89 of 114 [0, 0, 0]
> cd ./recomp013 && $MAKE -s --no-print-directory recomp013    </dev/null >recomp013.run.stdout 2>recomp013.run.stderr
> Actual stdout output differs from expected:
> --- ./recomp013/recomp013.stdout 2013-09-18 12:38:22.000000000 +0100
> +++ ./recomp013/recomp013.run.stdout 2013-09-19 12:15:22.611120935 +0100
> @@ -3,5 +3,3 @@
>  [2 of 3] Compiling B                ( B.hs, B.o )
>  [3 of 3] Compiling C                ( C.hs, C.o )
>  second run
> -[2 of 3] Compiling B                ( B.hs, B.o )
> -[3 of 3] Compiling C                ( C.hs, C.o ) [B changed]
> *** unexpected failure for recomp013(normal)

It works here. So that means either two things:
 * that the bug described in #8247 is actually present in HEAD, but
   only under certain circumstances, or
 * that there is a timing issue with the update of B.hs.

The latter seems to be more likely. I notice that other recomp-tests
have a "sleep 1" before updating the file: If you insert that in
recomp013/Makefile, does it go through for you?

Greetings,
Joachim

--
Joachim ?nomeata? Breitner
  mail at joachim-breitner.de ? http://www.joachim-breitner.de/
  Jabber: nomeata at joachim-breitner.de  ? GPG-Key: 0x4743206C
  Debian Developer: nomeata at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20130919/1e903894/attachment.pgp>

Reply | Threaded
Open this post in threaded view
|

recomp013

Simon Peyton Jones
that makes it work.!

| -----Original Message-----
| From: Joachim Breitner [mailto:mail at joachim-breitner.de]
| Sent: 19 September 2013 12:41
| To: Simon Peyton-Jones; ghc-devs at haskell.org
| Subject: Re: recomp013
|
| Dear Simon,
|
| Am Donnerstag, den 19.09.2013, 11:33 +0000 schrieb Simon Peyton-Jones:
| > =====> recomp013(normal) 89 of 114 [0, 0, 0]
| > cd ./recomp013 && $MAKE -s --no-print-directory recomp013
| </dev/null >recomp013.run.stdout 2>recomp013.run.stderr
| > Actual stdout output differs from expected:
| > --- ./recomp013/recomp013.stdout 2013-09-18 12:38:22.000000000 +0100
| > +++ ./recomp013/recomp013.run.stdout 2013-09-19 12:15:22.611120935
| +0100
| > @@ -3,5 +3,3 @@
| >  [2 of 3] Compiling B                ( B.hs, B.o )
| >  [3 of 3] Compiling C                ( C.hs, C.o )
| >  second run
| > -[2 of 3] Compiling B                ( B.hs, B.o )
| > -[3 of 3] Compiling C                ( C.hs, C.o ) [B changed]
| > *** unexpected failure for recomp013(normal)
|
| It works here. So that means either two things:
|  * that the bug described in #8247 is actually present in HEAD, but
|    only under certain circumstances, or
|  * that there is a timing issue with the update of B.hs.
|
| The latter seems to be more likely. I notice that other recomp-tests
| have a "sleep 1" before updating the file: If you insert that in
| recomp013/Makefile, does it go through for you?
|
| Greetings,
| Joachim
|
| --
| Joachim ?nomeata? Breitner
|   mail at joachim-breitner.de ? http://www.joachim-breitner.de/
|   Jabber: nomeata at joachim-breitner.de  ? GPG-Key: 0x4743206C
|   Debian Developer: nomeata at debian.org

Reply | Threaded
Open this post in threaded view
|

recomp013

Simon Peyton Jones
I lied.  Whether or not the 'sleep' is there, the test usually fails, but occasionally (one time in ten or so) succeeds.

SImon

| -----Original Message-----
| From: ghc-devs [mailto:ghc-devs-bounces at haskell.org] On Behalf Of Simon
| Peyton-Jones
| Sent: 19 September 2013 12:50
| To: Joachim Breitner; ghc-devs at haskell.org
| Subject: RE: recomp013
|
| that makes it work.!
|
| | -----Original Message-----
| | From: Joachim Breitner [mailto:mail at joachim-breitner.de]
| | Sent: 19 September 2013 12:41
| | To: Simon Peyton-Jones; ghc-devs at haskell.org
| | Subject: Re: recomp013
| |
| | Dear Simon,
| |
| | Am Donnerstag, den 19.09.2013, 11:33 +0000 schrieb Simon Peyton-Jones:
| | > =====> recomp013(normal) 89 of 114 [0, 0, 0]
| | > cd ./recomp013 && $MAKE -s --no-print-directory recomp013
| | </dev/null >recomp013.run.stdout 2>recomp013.run.stderr
| | > Actual stdout output differs from expected:
| | > --- ./recomp013/recomp013.stdout 2013-09-18 12:38:22.000000000
| +0100
| | > +++ ./recomp013/recomp013.run.stdout 2013-09-19 12:15:22.611120935
| | +0100
| | > @@ -3,5 +3,3 @@
| | >  [2 of 3] Compiling B                ( B.hs, B.o )
| | >  [3 of 3] Compiling C                ( C.hs, C.o )
| | >  second run
| | > -[2 of 3] Compiling B                ( B.hs, B.o )
| | > -[3 of 3] Compiling C                ( C.hs, C.o ) [B changed]
| | > *** unexpected failure for recomp013(normal)
| |
| | It works here. So that means either two things:
| |  * that the bug described in #8247 is actually present in HEAD, but
| |    only under certain circumstances, or
| |  * that there is a timing issue with the update of B.hs.
| |
| | The latter seems to be more likely. I notice that other recomp-tests
| | have a "sleep 1" before updating the file: If you insert that in
| | recomp013/Makefile, does it go through for you?
| |
| | Greetings,
| | Joachim
| |
| | --
| | Joachim ?nomeata? Breitner
| |   mail at joachim-breitner.de ? http://www.joachim-breitner.de/
| |   Jabber: nomeata at joachim-breitner.de  ? GPG-Key: 0x4743206C
| |   Debian Developer: nomeata at debian.org
| _______________________________________________
| ghc-devs mailing list
| ghc-devs at haskell.org
| http://www.haskell.org/mailman/listinfo/ghc-devs

Reply | Threaded
Open this post in threaded view
|

recomp013

Gabor Greif-2
On 9/19/13, Simon Peyton-Jones <simonpj at microsoft.com> wrote:
> I lied.  Whether or not the 'sleep' is there, the test usually fails, but
> occasionally (one time in ten or so) succeeds.

I am the originator of the bug report, and could consistently
reproduce it in a bigger project. Unfortunately I have no time
currently to dive into the issue, but I have it earmarked for later.

Cheers,

    Gabor


>
> SImon
>
> | -----Original Message-----
> | From: ghc-devs [mailto:ghc-devs-bounces at haskell.org] On Behalf Of Simon
> | Peyton-Jones
> | Sent: 19 September 2013 12:50
> | To: Joachim Breitner; ghc-devs at haskell.org
> | Subject: RE: recomp013
> |
> | that makes it work.!
> |
> | | -----Original Message-----
> | | From: Joachim Breitner [mailto:mail at joachim-breitner.de]
> | | Sent: 19 September 2013 12:41
> | | To: Simon Peyton-Jones; ghc-devs at haskell.org
> | | Subject: Re: recomp013
> | |
> | | Dear Simon,
> | |
> | | Am Donnerstag, den 19.09.2013, 11:33 +0000 schrieb Simon Peyton-Jones:
> | | > =====> recomp013(normal) 89 of 114 [0, 0, 0]
> | | > cd ./recomp013 && $MAKE -s --no-print-directory recomp013
> | | </dev/null >recomp013.run.stdout 2>recomp013.run.stderr
> | | > Actual stdout output differs from expected:
> | | > --- ./recomp013/recomp013.stdout 2013-09-18 12:38:22.000000000
> | +0100
> | | > +++ ./recomp013/recomp013.run.stdout 2013-09-19 12:15:22.611120935
> | | +0100
> | | > @@ -3,5 +3,3 @@
> | | >  [2 of 3] Compiling B                ( B.hs, B.o )
> | | >  [3 of 3] Compiling C                ( C.hs, C.o )
> | | >  second run
> | | > -[2 of 3] Compiling B                ( B.hs, B.o )
> | | > -[3 of 3] Compiling C                ( C.hs, C.o ) [B changed]
> | | > *** unexpected failure for recomp013(normal)
> | |
> | | It works here. So that means either two things:
> | |  * that the bug described in #8247 is actually present in HEAD, but
> | |    only under certain circumstances, or
> | |  * that there is a timing issue with the update of B.hs.
> | |
> | | The latter seems to be more likely. I notice that other recomp-tests
> | | have a "sleep 1" before updating the file: If you insert that in
> | | recomp013/Makefile, does it go through for you?
> | |
> | | Greetings,
> | | Joachim
> | |
> | | --
> | | Joachim ?nomeata? Breitner
> | |   mail at joachim-breitner.de ? http://www.joachim-breitner.de/
> | |   Jabber: nomeata at joachim-breitner.de  ? GPG-Key: 0x4743206C
> | |   Debian Developer: nomeata at debian.org
> | _______________________________________________
> | ghc-devs mailing list
> | ghc-devs at haskell.org
> | http://www.haskell.org/mailman/listinfo/ghc-devs
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-devs
>


Reply | Threaded
Open this post in threaded view
|

recomp013

Simon Marlow-7
Is it failing on Windows only?  It could be an issue with the
granularity of timestamps.  I think we use more accurate timestamps on
Linux nowadays, whereas Windows is still using 1 second granularity.  If
that's the case, it probably needs a "sleep 1" somewhere.  If the "sleep
1" didn't help, perhaps it wasn't in the right place - it needs to be
before the second set of echo commands.

On the subject of naming the test, we want two pieces of information in
the name:
   - what it tests
   - the ticket number, if it's a regression test
So rather than just renaming it to the ticket number (which would lose
the information that it's a recomp test), I suggest moving all the
recomp tests into their own directory first.  It's really useful to have
all the tests for a component together, so you can run them quickly when
you're working on that component.

Cheers,
        Simon

On 19/09/2013 08:57, Gabor Greif wrote:

> On 9/19/13, Simon Peyton-Jones <simonpj at microsoft.com> wrote:
>> I lied.  Whether or not the 'sleep' is there, the test usually fails, but
>> occasionally (one time in ten or so) succeeds.
>
> I am the originator of the bug report, and could consistently
> reproduce it in a bigger project. Unfortunately I have no time
> currently to dive into the issue, but I have it earmarked for later.
>
> Cheers,
>
>      Gabor
>
>
>>
>> SImon
>>
>> | -----Original Message-----
>> | From: ghc-devs [mailto:ghc-devs-bounces at haskell.org] On Behalf Of Simon
>> | Peyton-Jones
>> | Sent: 19 September 2013 12:50
>> | To: Joachim Breitner; ghc-devs at haskell.org
>> | Subject: RE: recomp013
>> |
>> | that makes it work.!
>> |
>> | | -----Original Message-----
>> | | From: Joachim Breitner [mailto:mail at joachim-breitner.de]
>> | | Sent: 19 September 2013 12:41
>> | | To: Simon Peyton-Jones; ghc-devs at haskell.org
>> | | Subject: Re: recomp013
>> | |
>> | | Dear Simon,
>> | |
>> | | Am Donnerstag, den 19.09.2013, 11:33 +0000 schrieb Simon Peyton-Jones:
>> | | > =====> recomp013(normal) 89 of 114 [0, 0, 0]
>> | | > cd ./recomp013 && $MAKE -s --no-print-directory recomp013
>> | | </dev/null >recomp013.run.stdout 2>recomp013.run.stderr
>> | | > Actual stdout output differs from expected:
>> | | > --- ./recomp013/recomp013.stdout 2013-09-18 12:38:22.000000000
>> | +0100
>> | | > +++ ./recomp013/recomp013.run.stdout 2013-09-19 12:15:22.611120935
>> | | +0100
>> | | > @@ -3,5 +3,3 @@
>> | | >  [2 of 3] Compiling B                ( B.hs, B.o )
>> | | >  [3 of 3] Compiling C                ( C.hs, C.o )
>> | | >  second run
>> | | > -[2 of 3] Compiling B                ( B.hs, B.o )
>> | | > -[3 of 3] Compiling C                ( C.hs, C.o ) [B changed]
>> | | > *** unexpected failure for recomp013(normal)
>> | |
>> | | It works here. So that means either two things:
>> | |  * that the bug described in #8247 is actually present in HEAD, but
>> | |    only under certain circumstances, or
>> | |  * that there is a timing issue with the update of B.hs.
>> | |
>> | | The latter seems to be more likely. I notice that other recomp-tests
>> | | have a "sleep 1" before updating the file: If you insert that in
>> | | recomp013/Makefile, does it go through for you?
>> | |
>> | | Greetings,
>> | | Joachim
>> | |
>> | | --
>> | | Joachim ?nomeata? Breitner
>> | |   mail at joachim-breitner.de ? http://www.joachim-breitner.de/
>> | |   Jabber: nomeata at joachim-breitner.de  ? GPG-Key: 0x4743206C
>> | |   Debian Developer: nomeata at debian.org
>> | _______________________________________________
>> | ghc-devs mailing list
>> | ghc-devs at haskell.org
>> | http://www.haskell.org/mailman/listinfo/ghc-devs
>> _______________________________________________
>> ghc-devs mailing list
>> ghc-devs at haskell.org
>> http://www.haskell.org/mailman/listinfo/ghc-devs
>>
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-devs
>


Reply | Threaded
Open this post in threaded view
|

recomp013

Simon Peyton Jones
No, it fails on Linux.  Mostly but not invariably.  Running it by hand (ie with TEST=recomp013) fails 9 times out of 10 and succeeds once.  Weird.

Simon

| -----Original Message-----
| From: Simon Marlow [mailto:marlowsd at gmail.com]
| Sent: 23 September 2013 12:08
| To: Gabor Greif; Simon Peyton-Jones
| Cc: Joachim Breitner; ghc-devs at haskell.org
| Subject: Re: recomp013
|
| Is it failing on Windows only?  It could be an issue with the
| granularity of timestamps.  I think we use more accurate timestamps on
| Linux nowadays, whereas Windows is still using 1 second granularity.  If
| that's the case, it probably needs a "sleep 1" somewhere.  If the "sleep
| 1" didn't help, perhaps it wasn't in the right place - it needs to be
| before the second set of echo commands.
|
| On the subject of naming the test, we want two pieces of information in
| the name:
|    - what it tests
|    - the ticket number, if it's a regression test
| So rather than just renaming it to the ticket number (which would lose
| the information that it's a recomp test), I suggest moving all the
| recomp tests into their own directory first.  It's really useful to have
| all the tests for a component together, so you can run them quickly when
| you're working on that component.
|
| Cheers,
| Simon
|
| On 19/09/2013 08:57, Gabor Greif wrote:
| > On 9/19/13, Simon Peyton-Jones <simonpj at microsoft.com> wrote:
| >> I lied.  Whether or not the 'sleep' is there, the test usually fails,
| but
| >> occasionally (one time in ten or so) succeeds.
| >
| > I am the originator of the bug report, and could consistently
| > reproduce it in a bigger project. Unfortunately I have no time
| > currently to dive into the issue, but I have it earmarked for later.
| >
| > Cheers,
| >
| >      Gabor
| >
| >
| >>
| >> SImon
| >>
| >> | -----Original Message-----
| >> | From: ghc-devs [mailto:ghc-devs-bounces at haskell.org] On Behalf Of
| Simon
| >> | Peyton-Jones
| >> | Sent: 19 September 2013 12:50
| >> | To: Joachim Breitner; ghc-devs at haskell.org
| >> | Subject: RE: recomp013
| >> |
| >> | that makes it work.!
| >> |
| >> | | -----Original Message-----
| >> | | From: Joachim Breitner [mailto:mail at joachim-breitner.de]
| >> | | Sent: 19 September 2013 12:41
| >> | | To: Simon Peyton-Jones; ghc-devs at haskell.org
| >> | | Subject: Re: recomp013
| >> | |
| >> | | Dear Simon,
| >> | |
| >> | | Am Donnerstag, den 19.09.2013, 11:33 +0000 schrieb Simon Peyton-
| Jones:
| >> | | > =====> recomp013(normal) 89 of 114 [0, 0, 0]
| >> | | > cd ./recomp013 && $MAKE -s --no-print-directory recomp013
| >> | | </dev/null >recomp013.run.stdout 2>recomp013.run.stderr
| >> | | > Actual stdout output differs from expected:
| >> | | > --- ./recomp013/recomp013.stdout 2013-09-18 12:38:22.000000000
| >> | +0100
| >> | | > +++ ./recomp013/recomp013.run.stdout 2013-09-19
| 12:15:22.611120935
| >> | | +0100
| >> | | > @@ -3,5 +3,3 @@
| >> | | >  [2 of 3] Compiling B                ( B.hs, B.o )
| >> | | >  [3 of 3] Compiling C                ( C.hs, C.o )
| >> | | >  second run
| >> | | > -[2 of 3] Compiling B                ( B.hs, B.o )
| >> | | > -[3 of 3] Compiling C                ( C.hs, C.o ) [B changed]
| >> | | > *** unexpected failure for recomp013(normal)
| >> | |
| >> | | It works here. So that means either two things:
| >> | |  * that the bug described in #8247 is actually present in HEAD,
| but
| >> | |    only under certain circumstances, or
| >> | |  * that there is a timing issue with the update of B.hs.
| >> | |
| >> | | The latter seems to be more likely. I notice that other recomp-
| tests
| >> | | have a "sleep 1" before updating the file: If you insert that in
| >> | | recomp013/Makefile, does it go through for you?
| >> | |
| >> | | Greetings,
| >> | | Joachim
| >> | |
| >> | | --
| >> | | Joachim "nomeata" Breitner
| >> | |   mail at joachim-breitner.de * http://www.joachim-breitner.de/
| >> | |   Jabber: nomeata at joachim-breitner.de  * GPG-Key: 0x4743206C
| >> | |   Debian Developer: nomeata at debian.org
| >> | _______________________________________________
| >> | ghc-devs mailing list
| >> | ghc-devs at haskell.org
| >> | http://www.haskell.org/mailman/listinfo/ghc-devs
| >> _______________________________________________
| >> ghc-devs mailing list
| >> ghc-devs at haskell.org
| >> http://www.haskell.org/mailman/listinfo/ghc-devs
| >>
| > _______________________________________________
| > ghc-devs mailing list
| > ghc-devs at haskell.org
| > http://www.haskell.org/mailman/listinfo/ghc-devs
| >


Reply | Threaded
Open this post in threaded view
|

recomp013

Nicolas Frisby
The test as in the repo also fails on my Mac (18 out of 20 times in a row).
Adding a 'sleep 1' before the second set of echo commands makes it succeed
(20 out of 20 times in a row).


On Mon, Sep 23, 2013 at 7:43 AM, Simon Peyton-Jones
<simonpj at microsoft.com>wrote:

> No, it fails on Linux.  Mostly but not invariably.  Running it by hand (ie
> with TEST=recomp013) fails 9 times out of 10 and succeeds once.  Weird.
>
> Simon
>
> | -----Original Message-----
> | From: Simon Marlow [mailto:marlowsd at gmail.com]
> | Sent: 23 September 2013 12:08
> | To: Gabor Greif; Simon Peyton-Jones
> | Cc: Joachim Breitner; ghc-devs at haskell.org
> | Subject: Re: recomp013
> |
> | Is it failing on Windows only?  It could be an issue with the
> | granularity of timestamps.  I think we use more accurate timestamps on
> | Linux nowadays, whereas Windows is still using 1 second granularity.  If
> | that's the case, it probably needs a "sleep 1" somewhere.  If the "sleep
> | 1" didn't help, perhaps it wasn't in the right place - it needs to be
> | before the second set of echo commands.
> |
> | On the subject of naming the test, we want two pieces of information in
> | the name:
> |    - what it tests
> |    - the ticket number, if it's a regression test
> | So rather than just renaming it to the ticket number (which would lose
> | the information that it's a recomp test), I suggest moving all the
> | recomp tests into their own directory first.  It's really useful to have
> | all the tests for a component together, so you can run them quickly when
> | you're working on that component.
> |
> | Cheers,
> |       Simon
> |
> | On 19/09/2013 08:57, Gabor Greif wrote:
> | > On 9/19/13, Simon Peyton-Jones <simonpj at microsoft.com> wrote:
> | >> I lied.  Whether or not the 'sleep' is there, the test usually fails,
> | but
> | >> occasionally (one time in ten or so) succeeds.
> | >
> | > I am the originator of the bug report, and could consistently
> | > reproduce it in a bigger project. Unfortunately I have no time
> | > currently to dive into the issue, but I have it earmarked for later.
> | >
> | > Cheers,
> | >
> | >      Gabor
> | >
> | >
> | >>
> | >> SImon
> | >>
> | >> | -----Original Message-----
> | >> | From: ghc-devs [mailto:ghc-devs-bounces at haskell.org] On Behalf Of
> | Simon
> | >> | Peyton-Jones
> | >> | Sent: 19 September 2013 12:50
> | >> | To: Joachim Breitner; ghc-devs at haskell.org
> | >> | Subject: RE: recomp013
> | >> |
> | >> | that makes it work.!
> | >> |
> | >> | | -----Original Message-----
> | >> | | From: Joachim Breitner [mailto:mail at joachim-breitner.de]
> | >> | | Sent: 19 September 2013 12:41
> | >> | | To: Simon Peyton-Jones; ghc-devs at haskell.org
> | >> | | Subject: Re: recomp013
> | >> | |
> | >> | | Dear Simon,
> | >> | |
> | >> | | Am Donnerstag, den 19.09.2013, 11:33 +0000 schrieb Simon Peyton-
> | Jones:
> | >> | | > =====> recomp013(normal) 89 of 114 [0, 0, 0]
> | >> | | > cd ./recomp013 && $MAKE -s --no-print-directory recomp013
> | >> | | </dev/null >recomp013.run.stdout 2>recomp013.run.stderr
> | >> | | > Actual stdout output differs from expected:
> | >> | | > --- ./recomp013/recomp013.stdout     2013-09-18
> 12:38:22.000000000
> | >> | +0100
> | >> | | > +++ ./recomp013/recomp013.run.stdout 2013-09-19
> | 12:15:22.611120935
> | >> | | +0100
> | >> | | > @@ -3,5 +3,3 @@
> | >> | | >  [2 of 3] Compiling B                ( B.hs, B.o )
> | >> | | >  [3 of 3] Compiling C                ( C.hs, C.o )
> | >> | | >  second run
> | >> | | > -[2 of 3] Compiling B                ( B.hs, B.o )
> | >> | | > -[3 of 3] Compiling C                ( C.hs, C.o ) [B changed]
> | >> | | > *** unexpected failure for recomp013(normal)
> | >> | |
> | >> | | It works here. So that means either two things:
> | >> | |  * that the bug described in #8247 is actually present in HEAD,
> | but
> | >> | |    only under certain circumstances, or
> | >> | |  * that there is a timing issue with the update of B.hs.
> | >> | |
> | >> | | The latter seems to be more likely. I notice that other recomp-
> | tests
> | >> | | have a "sleep 1" before updating the file: If you insert that in
> | >> | | recomp013/Makefile, does it go through for you?
> | >> | |
> | >> | | Greetings,
> | >> | | Joachim
> | >> | |
> | >> | | --
> | >> | | Joachim "nomeata" Breitner
> | >> | |   mail at joachim-breitner.de * http://www.joachim-breitner.de/
> | >> | |   Jabber: nomeata at joachim-breitner.de  * GPG-Key: 0x4743206C
> | >> | |   Debian Developer: nomeata at debian.org
> | >> | _______________________________________________
> | >> | ghc-devs mailing list
> | >> | ghc-devs at haskell.org
> | >> | http://www.haskell.org/mailman/listinfo/ghc-devs
> | >> _______________________________________________
> | >> ghc-devs mailing list
> | >> ghc-devs at haskell.org
> | >> http://www.haskell.org/mailman/listinfo/ghc-devs
> | >>
> | > _______________________________________________
> | > ghc-devs mailing list
> | > ghc-devs at haskell.org
> | > http://www.haskell.org/mailman/listinfo/ghc-devs
> | >
> _______________________________________________
> ghc-devs mailing list
> ghc-devs at haskell.org
> http://www.haskell.org/mailman/listinfo/ghc-devs
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/ghc-devs/attachments/20130927/2904db07/attachment.htm>

Reply | Threaded
Open this post in threaded view
|

recomp013

Simon Marlow-7
I have the "sleep 1" in my tree, will commit after my next validate round.

Cheers,
Simon

On 27/09/2013 10:14, Nicolas Frisby wrote:

> The test as in the repo also fails on my Mac (18 out of 20 times in a
> row). Adding a 'sleep 1' before the second set of echo commands makes it
> succeed (20 out of 20 times in a row).
>
>
> On Mon, Sep 23, 2013 at 7:43 AM, Simon Peyton-Jones
> <simonpj at microsoft.com <mailto:simonpj at microsoft.com>> wrote:
>
>     No, it fails on Linux.  Mostly but not invariably.  Running it by
>     hand (ie with TEST=recomp013) fails 9 times out of 10 and succeeds
>     once.  Weird.
>
>     Simon
>
>     | -----Original Message-----
>     | From: Simon Marlow [mailto:marlowsd at gmail.com
>     <mailto:marlowsd at gmail.com>]
>     | Sent: 23 September 2013 12:08
>     | To: Gabor Greif; Simon Peyton-Jones
>     | Cc: Joachim Breitner; ghc-devs at haskell.org
>     <mailto:ghc-devs at haskell.org>
>     | Subject: Re: recomp013
>     |
>     | Is it failing on Windows only?  It could be an issue with the
>     | granularity of timestamps.  I think we use more accurate timestamps on
>     | Linux nowadays, whereas Windows is still using 1 second
>     granularity.  If
>     | that's the case, it probably needs a "sleep 1" somewhere.  If the
>     "sleep
>     | 1" didn't help, perhaps it wasn't in the right place - it needs to be
>     | before the second set of echo commands.
>     |
>     | On the subject of naming the test, we want two pieces of
>     information in
>     | the name:
>     |    - what it tests
>     |    - the ticket number, if it's a regression test
>     | So rather than just renaming it to the ticket number (which would lose
>     | the information that it's a recomp test), I suggest moving all the
>     | recomp tests into their own directory first.  It's really useful
>     to have
>     | all the tests for a component together, so you can run them
>     quickly when
>     | you're working on that component.
>     |
>     | Cheers,
>     |       Simon
>     |
>     | On 19/09/2013 08:57, Gabor Greif wrote:
>     | > On 9/19/13, Simon Peyton-Jones <simonpj at microsoft.com
>     <mailto:simonpj at microsoft.com>> wrote:
>     | >> I lied.  Whether or not the 'sleep' is there, the test usually
>     fails,
>     | but
>     | >> occasionally (one time in ten or so) succeeds.
>     | >
>     | > I am the originator of the bug report, and could consistently
>     | > reproduce it in a bigger project. Unfortunately I have no time
>     | > currently to dive into the issue, but I have it earmarked for later.
>     | >
>     | > Cheers,
>     | >
>     | >      Gabor
>     | >
>     | >
>     | >>
>     | >> SImon
>     | >>
>     | >> | -----Original Message-----
>     | >> | From: ghc-devs [mailto:ghc-devs-bounces at haskell.org
>     <mailto:ghc-devs-bounces at haskell.org>] On Behalf Of
>     | Simon
>     | >> | Peyton-Jones
>     | >> | Sent: 19 September 2013 12:50
>     | >> | To: Joachim Breitner; ghc-devs at haskell.org
>     <mailto:ghc-devs at haskell.org>
>     | >> | Subject: RE: recomp013
>     | >> |
>     | >> | that makes it work.!
>     | >> |
>     | >> | | -----Original Message-----
>     | >> | | From: Joachim Breitner [mailto:mail at joachim-breitner.de
>     <mailto:mail at joachim-breitner.de>]
>     | >> | | Sent: 19 September 2013 12:41
>     | >> | | To: Simon Peyton-Jones; ghc-devs at haskell.org
>     <mailto:ghc-devs at haskell.org>
>     | >> | | Subject: Re: recomp013
>     | >> | |
>     | >> | | Dear Simon,
>     | >> | |
>     | >> | | Am Donnerstag, den 19.09.2013, 11:33 +0000 schrieb Simon
>     Peyton-
>     | Jones:
>     | >> | | > =====> recomp013(normal) 89 of 114 [0, 0, 0]
>     | >> | | > cd ./recomp013 && $MAKE -s --no-print-directory recomp013
>     | >> | | </dev/null >recomp013.run.stdout 2>recomp013.run.stderr
>     | >> | | > Actual stdout output differs from expected:
>     | >> | | > --- ./recomp013/recomp013.stdout     2013-09-18
>     12:38:22.000000000
>     | >> | +0100
>     | >> | | > +++ ./recomp013/recomp013.run.stdout 2013-09-19
>     | 12:15:22.611120935
>     | >> | | +0100
>     | >> | | > @@ -3,5 +3,3 @@
>     | >> | | >  [2 of 3] Compiling B                ( B.hs, B.o )
>     | >> | | >  [3 of 3] Compiling C                ( C.hs, C.o )
>     | >> | | >  second run
>     | >> | | > -[2 of 3] Compiling B                ( B.hs, B.o )
>     | >> | | > -[3 of 3] Compiling C                ( C.hs, C.o ) [B
>     changed]
>     | >> | | > *** unexpected failure for recomp013(normal)
>     | >> | |
>     | >> | | It works here. So that means either two things:
>     | >> | |  * that the bug described in #8247 is actually present in HEAD,
>     | but
>     | >> | |    only under certain circumstances, or
>     | >> | |  * that there is a timing issue with the update of B.hs.
>     | >> | |
>     | >> | | The latter seems to be more likely. I notice that other recomp-
>     | tests
>     | >> | | have a "sleep 1" before updating the file: If you insert
>     that in
>     | >> | | recomp013/Makefile, does it go through for you?
>     | >> | |
>     | >> | | Greetings,
>     | >> | | Joachim
>     | >> | |
>     | >> | | --
>     | >> | | Joachim "nomeata" Breitner
>     | >> | | mail at joachim-breitner.de <mailto:mail at joachim-breitner.de>
>     * http://www.joachim-breitner.de/
>     | >> | |   Jabber: nomeata at joachim-breitner.de
>     <mailto:nomeata at joachim-breitner.de>  * GPG-Key: 0x4743206C
>     | >> | |   Debian Developer: nomeata at debian.org
>     <mailto:nomeata at debian.org>
>     | >> | _______________________________________________
>     | >> | ghc-devs mailing list
>     | >> | ghc-devs at haskell.org <mailto:ghc-devs at haskell.org>
>     | >> | http://www.haskell.org/mailman/listinfo/ghc-devs
>     | >> _______________________________________________
>     | >> ghc-devs mailing list
>     | >> ghc-devs at haskell.org <mailto:ghc-devs at haskell.org>
>     | >> http://www.haskell.org/mailman/listinfo/ghc-devs
>     | >>
>     | > _______________________________________________
>     | > ghc-devs mailing list
>     | > ghc-devs at haskell.org <mailto:ghc-devs at haskell.org>
>     | > http://www.haskell.org/mailman/listinfo/ghc-devs
>     | >
>     _______________________________________________
>     ghc-devs mailing list
>     ghc-devs at haskell.org <mailto:ghc-devs at haskell.org>
>     http://www.haskell.org/mailman/listinfo/ghc-devs
>
>